All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Colin King <colin.king@canonical.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ext4: fix two cases where a u32 is being checked for a less than zero error return
Date: Sat, 11 May 2019 02:09:30 +0000	[thread overview]
Message-ID: <20190511020930.GG2534@mit.edu> (raw)
In-Reply-To: <20190426220908.12790-1-colin.king@canonical.com>

On Fri, Apr 26, 2019 at 11:09:08PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There are two cases where u32 variables n and err are being checked
> for less than zero error values, the checks is always false because
> the variables are not signed. Fix this by making the variables ints.
> 
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: 345c0dbf3a30 ("ext4: protect journal inode's blocks using block_validity")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, applied.

					- Ted

WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Ts'o" <tytso@mit.edu>
To: Colin King <colin.king@canonical.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ext4: fix two cases where a u32 is being checked for a less than zero error return
Date: Fri, 10 May 2019 22:09:30 -0400	[thread overview]
Message-ID: <20190511020930.GG2534@mit.edu> (raw)
In-Reply-To: <20190426220908.12790-1-colin.king@canonical.com>

On Fri, Apr 26, 2019 at 11:09:08PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There are two cases where u32 variables n and err are being checked
> for less than zero error values, the checks is always false because
> the variables are not signed. Fix this by making the variables ints.
> 
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: 345c0dbf3a30 ("ext4: protect journal inode's blocks using block_validity")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, applied.

					- Ted

  reply	other threads:[~2019-05-11  2:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26 22:09 [PATCH][next] ext4: fix two cases where a u32 is being checked for a less than zero error return Colin King
2019-04-26 22:09 ` Colin King
2019-05-11  2:09 ` Theodore Ts'o [this message]
2019-05-11  2:09   ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190511020930.GG2534@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.