From: gregkh at linuxfoundation.org (Greg KH)
Subject: [Linux-kernel-mentees] [PATCH v2 2/8] Staging: kpc2000: kpc_dma: Resolve coding style errors reported by checkpatch.
Date: Mon, 13 May 2019 10:42:17 +0200 [thread overview]
Message-ID: <20190513084217.GA17959@kroah.com> (raw)
In-Reply-To: <20190512234000.16555-2-bnvandana@gmail.com>
On Mon, May 13, 2019 at 05:09:54AM +0530, Vandana BN wrote:
> This patch resolves below errors reported by checkpatch
> ERROR: "(foo*)" should be "(foo *)"
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "foo __init bar" should be "foo __init bar"
> ERROR: "foo __exit bar" should be "foo __exit bar"
>
> Signed-off-by: Vandana BN <bnvandana at gmail.com>
Better...
But your subject lines are almost all the same, with some being
identical to others, yet you are doing different things in each of the
patch.
So please provide a better subject line saying, in a unique way, exactly
what you are doing here.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
Subject: [Linux-kernel-mentees] [PATCH v2 2/8] Staging: kpc2000: kpc_dma: Resolve coding style errors reported by checkpatch.
Date: Mon, 13 May 2019 10:42:17 +0200 [thread overview]
Message-ID: <20190513084217.GA17959@kroah.com> (raw)
Message-ID: <20190513084217.kQyEvYhqkqSMqpU4r_VSSmeeiyJbcd7806hl5T1xGCo@z> (raw)
In-Reply-To: <20190512234000.16555-2-bnvandana@gmail.com>
On Mon, May 13, 2019 at 05:09:54AM +0530, Vandana BN wrote:
> This patch resolves below errors reported by checkpatch
> ERROR: "(foo*)" should be "(foo *)"
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "foo __init bar" should be "foo __init bar"
> ERROR: "foo __exit bar" should be "foo __exit bar"
>
> Signed-off-by: Vandana BN <bnvandana at gmail.com>
Better...
But your subject lines are almost all the same, with some being
identical to others, yet you are doing different things in each of the
patch.
So please provide a better subject line saying, in a unique way, exactly
what you are doing here.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Vandana BN <bnvandana@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
lukas.bulwahn@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH v2 2/8] Staging: kpc2000: kpc_dma: Resolve coding style errors reported by checkpatch.
Date: Mon, 13 May 2019 10:42:17 +0200 [thread overview]
Message-ID: <20190513084217.GA17959@kroah.com> (raw)
In-Reply-To: <20190512234000.16555-2-bnvandana@gmail.com>
On Mon, May 13, 2019 at 05:09:54AM +0530, Vandana BN wrote:
> This patch resolves below errors reported by checkpatch
> ERROR: "(foo*)" should be "(foo *)"
> ERROR: "foo * bar" should be "foo *bar"
> ERROR: "foo __init bar" should be "foo __init bar"
> ERROR: "foo __exit bar" should be "foo __exit bar"
>
> Signed-off-by: Vandana BN <bnvandana@gmail.com>
Better...
But your subject lines are almost all the same, with some being
identical to others, yet you are doing different things in each of the
patch.
So please provide a better subject line saying, in a unique way, exactly
what you are doing here.
thanks,
greg k-h
next prev parent reply other threads:[~2019-05-13 8:42 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 19:38 [Linux-kernel-mentees] [PATCH] Staging: kpc2000: kpc_dma: resolve checkpath errors and warnings bnvandana
2019-05-10 19:38 ` Vandana BN
2019-05-10 19:38 ` [Linux-kernel-mentees] " Vandana BN
2019-05-10 20:34 ` lukas.bulwahn
2019-05-10 20:34 ` Lukas Bulwahn
2019-05-10 20:34 ` Lukas Bulwahn
2019-05-12 15:48 ` bnvandana
2019-05-12 15:48 ` Vandana BN
2019-05-12 15:48 ` Vandana BN
2019-05-11 6:04 ` gregkh
2019-05-11 6:04 ` Greg KH
2019-05-11 6:04 ` [Linux-kernel-mentees] " Greg KH
2019-05-12 23:39 ` [Linux-kernel-mentees] [PATCH v2 1/8] Staging: kpc2000: kpc_dma: resolve trailing whitespace error reported by checkpatch bnvandana
2019-05-12 23:39 ` Vandana BN
2019-05-12 23:39 ` [Linux-kernel-mentees] " Vandana BN
2019-05-12 23:39 ` [Linux-kernel-mentees] [PATCH v2 2/8] Staging: kpc2000: kpc_dma: Resolve coding style errors " bnvandana
2019-05-12 23:39 ` Vandana BN
2019-05-12 23:39 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 8:42 ` gregkh [this message]
2019-05-13 8:42 ` Greg KH
2019-05-13 8:42 ` [Linux-kernel-mentees] " Greg KH
2019-05-13 10:43 ` bnvandana
2019-05-13 10:43 ` Vandana BN
2019-05-13 10:43 ` [Linux-kernel-mentees] " Vandana BN
2019-05-12 23:39 ` [Linux-kernel-mentees] [PATCH v2 3/8] " bnvandana
2019-05-12 23:39 ` Vandana BN
2019-05-12 23:39 ` [Linux-kernel-mentees] " Vandana BN
2019-05-12 23:39 ` [Linux-kernel-mentees] [PATCH v2 4/8] Staging: kpc2000: kpc_dma: Resolve code indent error " bnvandana
2019-05-12 23:39 ` Vandana BN
2019-05-12 23:39 ` [Linux-kernel-mentees] " Vandana BN
2019-05-12 23:39 ` [Linux-kernel-mentees] [PATCH v2 5/8] Staging: kpc2000: kpc_dma: Resolve coding style " bnvandana
2019-05-12 23:39 ` Vandana BN
2019-05-12 23:39 ` [Linux-kernel-mentees] " Vandana BN
2019-05-12 23:39 ` [Linux-kernel-mentees] [PATCH v2 6/8] Staging: kpc2000: kpc_dma: Resolve coding style warning " bnvandana
2019-05-12 23:39 ` Vandana BN
2019-05-12 23:39 ` [Linux-kernel-mentees] " Vandana BN
2019-05-12 23:39 ` [Linux-kernel-mentees] [PATCH v2 7/8] " bnvandana
2019-05-12 23:39 ` Vandana BN
2019-05-12 23:39 ` [Linux-kernel-mentees] " Vandana BN
2019-05-12 23:40 ` [Linux-kernel-mentees] [PATCH v2 8/8] " bnvandana
2019-05-12 23:40 ` Vandana BN
2019-05-12 23:40 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] [PATCH v3 1/8] Staging: kpc2000: kpc_dma: Resolve trailing whitespace error " bnvandana
2019-05-13 10:26 ` Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] [PATCH v3 2/8] Staging: kpc2000: kpc_dma: Resolve space errors around pointers and function declarations " bnvandana
2019-05-13 10:26 ` Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] [PATCH v3 3/8] Staging: kpc2000: kpc_dma: Resolve checkpatch space errors around brace '{', '!' and open paranthesis '(' bnvandana
2019-05-13 10:26 ` [PATCH v3 3/8] Staging: kpc2000: kpc_dma: Resolve checkpatch space errors around brace '{','!' " Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] [PATCH v3 3/8] Staging: kpc2000: kpc_dma: Resolve checkpatch space errors around brace '{', '!' " Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] [PATCH v3 4/8] Staging: kpc2000: kpc_dma: Resolve code indent and trailing statements on next line errors reported by checkpatch bnvandana
2019-05-13 10:26 ` Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] [PATCH v3 5/8] Staging: kpc2000: kpc_dma: Resolve checkpath errors Macros in paranthesis & trailing statements on next line bnvandana
2019-05-13 10:26 ` Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] [PATCH v3 6/8] Staging: kpc2000: kpc_dma: Resolve warning Missing blank line after declarations & labels not to be indented bnvandana
2019-05-13 10:26 ` Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] [PATCH v3 7/8] Staging: kpc2000: kpc_dma: Resolve warning to use __func__ insted of funtion name reported by checkpatch bnvandana
2019-05-13 10:26 ` Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] [PATCH v3 8/8] Staging: kpc2000: kpc_dma: Resolve cast warning and use const for file_operation bnvandana
2019-05-13 10:26 ` Vandana BN
2019-05-13 10:26 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 10:49 ` [Linux-kernel-mentees] [PATCH v3 1/8] Staging: kpc2000: kpc_dma: Resolve trailing whitespace error reported by checkpatch dan.carpenter
2019-05-13 10:49 ` Dan Carpenter
2019-05-13 10:49 ` [Linux-kernel-mentees] " Dan Carpenter
2019-05-13 12:00 ` bnvandana
2019-05-13 12:00 ` Vandana BN
2019-05-13 12:00 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] [PATCH v4 " bnvandana
2019-05-13 13:43 ` Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] [PATCH v4 2/8] Staging: kpc2000: kpc_dma: Resolve space errors around pointers and function declarations " bnvandana
2019-05-13 13:43 ` Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] [PATCH v4 3/8] Staging: kpc2000: kpc_dma: Resolve checkpatch space errors around brace '{', '!' and open paranthesis '(' bnvandana
2019-05-13 13:43 ` [PATCH v4 3/8] Staging: kpc2000: kpc_dma: Resolve checkpatch space errors around brace '{','!' " Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] [PATCH v4 3/8] Staging: kpc2000: kpc_dma: Resolve checkpatch space errors around brace '{', '!' " Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] [PATCH v4 4/8] Staging: kpc2000: kpc_dma: Resolve code indent and trailing statements on next line errors reported by checkpatch bnvandana
2019-05-13 13:43 ` Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] [PATCH v4 5/8] Staging: kpc2000: kpc_dma: Resolve checkpath errors Macros in paranthesis & trailing statements on next line bnvandana
2019-05-13 13:43 ` Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] [PATCH v4 6/8] Staging: kpc2000: kpc_dma: Resolve warning Missing blank line after declarations & labels not to be indented bnvandana
2019-05-13 13:43 ` Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] [PATCH v4 7/8] Staging: kpc2000: kpc_dma: Resolve warning to use __func__ insted of funtion name reported by checkpatch bnvandana
2019-05-13 13:43 ` Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] " Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] [PATCH v4 8/8] Staging: kpc2000: kpc_dma: Resolve cast warning and use const for file_operation bnvandana
2019-05-13 13:43 ` Vandana BN
2019-05-13 13:43 ` [Linux-kernel-mentees] " Vandana BN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513084217.GA17959@kroah.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.