* [PATCH] drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry()
@ 2019-05-13 9:22 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2019-05-13 9:22 UTC (permalink / raw)
To: Zhenyu Wang, Aleksei Gimbitskii
Cc: David Airlie, intel-gfx, kernel-janitors, intel-gvt-dev
"ret" is uninitialized on this path but it should be -EINVAL.
Fixes: 930c8dfea4b8 ("drm/i915/gvt: Check if get_next_pt_type() always returns a valid value")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/i915/gvt/gtt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
index 08c74e65836b..244ad1729764 100644
--- a/drivers/gpu/drm/i915/gvt/gtt.c
+++ b/drivers/gpu/drm/i915/gvt/gtt.c
@@ -1076,8 +1076,10 @@ static struct intel_vgpu_ppgtt_spt *ppgtt_populate_spt_by_guest_entry(
} else {
int type = get_next_pt_type(we->type);
- if (!gtt_type_is_pt(type))
+ if (!gtt_type_is_pt(type)) {
+ ret = -EINVAL;
goto err;
+ }
spt = ppgtt_alloc_spt_gfn(vgpu, type, ops->get_pfn(we), ips);
if (IS_ERR(spt)) {
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry()
2019-05-13 9:22 ` Dan Carpenter
(?)
@ 2019-05-13 10:01 ` Patchwork
-1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-05-13 10:01 UTC (permalink / raw)
To: Dan Carpenter; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry()
URL : https://patchwork.freedesktop.org/series/60572/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6073 -> Patchwork_13005
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/
Known issues
------------
Here are the changes found in Patchwork_13005 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: [PASS][1] -> [INCOMPLETE][2] ([fdo#108602] / [fdo#108744])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/fi-skl-iommu/igt@i915_selftest@live_hangcheck.html
#### Possible fixes ####
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [DMESG-FAIL][3] ([fdo#110235]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
* igt@i915_selftest@live_hangcheck:
- {fi-icl-u2}: [INCOMPLETE][5] ([fdo#107713] / [fdo#108569]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (47 -> 45)
------------------------------
Additional (3): fi-icl-y fi-cml-u2 fi-blb-e6850
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper
Build changes
-------------
* Linux: CI_DRM_6073 -> Patchwork_13005
CI_DRM_6073: c059ddabfe60a5072ace44a34a9de9b4202df6ec @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4978: b9b3646d4f04dd0204ead2a1a10f9e1806a0b622 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13005: ee33c4c0dd8d8df29f316d5337709919e63121c2 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ee33c4c0dd8d drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry()
2019-05-13 9:22 ` Dan Carpenter
(?)
(?)
@ 2019-05-13 11:54 ` Patchwork
-1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-05-13 11:54 UTC (permalink / raw)
To: Dan Carpenter; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry()
URL : https://patchwork.freedesktop.org/series/60572/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6073_full -> Patchwork_13005_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_13005_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs0-s3:
- shard-skl: ([PASS][1], [PASS][2]) -> [INCOMPLETE][3] ([fdo#104108] / [fdo#107773])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl3/igt@gem_ctx_isolation@vcs0-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl9/igt@gem_ctx_isolation@vcs0-s3.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-skl4/igt@gem_ctx_isolation@vcs0-s3.html
* igt@i915_pm_rpm@fences-dpms:
- shard-skl: [PASS][4] -> [INCOMPLETE][5] ([fdo#107807])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl7/igt@i915_pm_rpm@fences-dpms.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-skl10/igt@i915_pm_rpm@fences-dpms.html
* igt@i915_pm_rpm@i2c:
- shard-iclb: [PASS][6] -> [DMESG-WARN][7] ([fdo#109982])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb5/igt@i915_pm_rpm@i2c.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-iclb2/igt@i915_pm_rpm@i2c.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#109349])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-iclb8/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_flip@2x-flip-vs-modeset-vs-hang:
- shard-hsw: ([PASS][10], [PASS][11]) -> [INCOMPLETE][12] ([fdo#103540])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-hsw1/igt@kms_flip@2x-flip-vs-modeset-vs-hang.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-hsw2/igt@kms_flip@2x-flip-vs-modeset-vs-hang.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-hsw8/igt@kms_flip@2x-flip-vs-modeset-vs-hang.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: ([PASS][13], [PASS][14]) -> [FAIL][15] ([fdo#105363])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
- shard-glk: ([PASS][16], [PASS][17]) -> [FAIL][18] ([fdo#105363])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:
- shard-iclb: ([PASS][19], [PASS][20]) -> [FAIL][21] ([fdo#103167])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: ([PASS][22], [PASS][23]) -> [DMESG-WARN][24] ([fdo#108566]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-apl1/igt@kms_frontbuffer_tracking@fbc-suspend.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-apl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-apl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
- shard-skl: ([PASS][25], [PASS][26]) -> [INCOMPLETE][27] ([fdo#104108])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-skl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-tilingchange:
- shard-iclb: [PASS][28] -> [FAIL][29] ([fdo#103167]) +4 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-tilingchange.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][30] -> [SKIP][31] ([fdo#109441]) +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
#### Possible fixes ####
* igt@gem_tiled_swapping@non-threaded:
- shard-hsw: ([FAIL][32], [PASS][33]) ([fdo#108686]) -> [PASS][34]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-hsw4/igt@gem_tiled_swapping@non-threaded.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-hsw6/igt@gem_tiled_swapping@non-threaded.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-hsw6/igt@gem_tiled_swapping@non-threaded.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: ([DMESG-WARN][35], [PASS][36]) ([fdo#108566]) -> [PASS][37] +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-apl4/igt@i915_suspend@debugfs-reader.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-apl8/igt@i915_suspend@debugfs-reader.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-apl6/igt@i915_suspend@debugfs-reader.html
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-skl: ([PASS][38], [FAIL][39]) ([fdo#103232]) -> [PASS][40]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl8/igt@kms_cursor_crc@cursor-128x128-onscreen.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl2/igt@kms_cursor_crc@cursor-128x128-onscreen.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-skl2/igt@kms_cursor_crc@cursor-128x128-onscreen.html
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: ([DMESG-WARN][41], [DMESG-WARN][42]) ([fdo#108566]) -> [PASS][43] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-apl8/igt@kms_cursor_crc@cursor-128x128-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-apl1/igt@kms_cursor_crc@cursor-128x128-suspend.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-apl2/igt@kms_cursor_crc@cursor-128x128-suspend.html
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-skl: [INCOMPLETE][44] ([fdo#104108] / [fdo#107773]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl9/igt@kms_cursor_crc@cursor-64x64-suspend.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-skl8/igt@kms_cursor_crc@cursor-64x64-suspend.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic:
- shard-hsw: ([PASS][46], [INCOMPLETE][47]) ([fdo#103540]) -> [PASS][48]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-hsw2/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-atomic.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt:
- shard-iclb: [FAIL][49] ([fdo#103167]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-iclb: ([FAIL][51], [PASS][52]) ([fdo#103167]) -> [PASS][53] +5 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: ([FAIL][54], [PASS][55]) ([fdo#108145] / [fdo#110403]) -> [PASS][56]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: ([FAIL][57], [PASS][58]) ([fdo#103166]) -> [PASS][59]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-y.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-y.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][60] ([fdo#109441]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: ([SKIP][62], [PASS][63]) ([fdo#109441]) -> [PASS][64]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb7/igt@kms_psr@psr2_suspend.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb2/igt@kms_psr@psr2_suspend.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-iclb2/igt@kms_psr@psr2_suspend.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][65] ([fdo#99912]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-kbl7/igt@kms_setmode@basic.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-kbl3/igt@kms_setmode@basic.html
* igt@kms_sysfs_edid_timing:
- shard-iclb: ([FAIL][67], [PASS][68]) ([fdo#100047]) -> [PASS][69]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb3/igt@kms_sysfs_edid_timing.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb5/igt@kms_sysfs_edid_timing.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-iclb7/igt@kms_sysfs_edid_timing.html
#### Warnings ####
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-skl: ([SKIP][70], [SKIP][71]) ([fdo#109271]) -> [INCOMPLETE][72] ([fdo#107807])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl6/igt@i915_pm_rpm@dpms-non-lpsp.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl1/igt@i915_pm_rpm@dpms-non-lpsp.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-skl5/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-skl: [INCOMPLETE][73] ([fdo#107807]) -> [SKIP][74] ([fdo#109271])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl4/igt@i915_pm_rpm@modeset-pc8-residency-stress.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-skl1/igt@i915_pm_rpm@modeset-pc8-residency-stress.html
* igt@i915_pm_rpm@reg-read-ioctl:
- shard-skl: ([PASS][75], [INCOMPLETE][76]) ([fdo#107807]) -> [INCOMPLETE][77] ([fdo#107807])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl6/igt@i915_pm_rpm@reg-read-ioctl.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl1/igt@i915_pm_rpm@reg-read-ioctl.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-skl5/igt@i915_pm_rpm@reg-read-ioctl.html
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-skl: ([PASS][78], [FAIL][79]) ([fdo#103232]) -> [FAIL][80] ([fdo#103232])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl7/igt@kms_cursor_crc@cursor-128x128-suspend.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl9/igt@kms_cursor_crc@cursor-128x128-suspend.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-skl1/igt@kms_cursor_crc@cursor-128x128-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: ([FAIL][81], [PASS][82]) ([fdo#103167]) -> [FAIL][83] ([fdo#103167]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-apl: ([PASS][84], [DMESG-WARN][85]) ([fdo#108566]) -> [DMESG-WARN][86] ([fdo#108566]) +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-apl5/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-apl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: ([PASS][87], [FAIL][88]) ([fdo#108145]) -> [FAIL][89] ([fdo#108145])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: ([SKIP][90], [PASS][91]) ([fdo#109441]) -> [SKIP][92] ([fdo#109441]) +2 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb3/igt@kms_psr@psr2_cursor_render.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-iclb4/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-apl: ([PASS][93], [FAIL][94]) ([fdo#99912]) -> [FAIL][95] ([fdo#99912])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-apl4/igt@kms_setmode@basic.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6073/shard-apl5/igt@kms_setmode@basic.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/shard-apl7/igt@kms_setmode@basic.html
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6073 -> Patchwork_13005
CI_DRM_6073: c059ddabfe60a5072ace44a34a9de9b4202df6ec @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4978: b9b3646d4f04dd0204ead2a1a10f9e1806a0b622 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13005: ee33c4c0dd8d8df29f316d5337709919e63121c2 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13005/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry()
2019-05-13 9:22 ` Dan Carpenter
@ 2019-05-14 6:56 ` Zhenyu Wang
-1 siblings, 0 replies; 6+ messages in thread
From: Zhenyu Wang @ 2019-05-14 6:56 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Aleksei Gimbitskii, intel-gfx, kernel-janitors,
intel-gvt-dev
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
On 2019.05.13 12:22:44 +0300, Dan Carpenter wrote:
> "ret" is uninitialized on this path but it should be -EINVAL.
>
> Fixes: 930c8dfea4b8 ("drm/i915/gvt: Check if get_next_pt_type() always returns a valid value")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/i915/gvt/gtt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
> index 08c74e65836b..244ad1729764 100644
> --- a/drivers/gpu/drm/i915/gvt/gtt.c
> +++ b/drivers/gpu/drm/i915/gvt/gtt.c
> @@ -1076,8 +1076,10 @@ static struct intel_vgpu_ppgtt_spt *ppgtt_populate_spt_by_guest_entry(
> } else {
> int type = get_next_pt_type(we->type);
>
> - if (!gtt_type_is_pt(type))
> + if (!gtt_type_is_pt(type)) {
> + ret = -EINVAL;
> goto err;
> + }
>
> spt = ppgtt_alloc_spt_gfn(vgpu, type, ops->get_pfn(we), ips);
> if (IS_ERR(spt)) {
> --
Applied this, thanks!
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry()
@ 2019-05-14 6:56 ` Zhenyu Wang
0 siblings, 0 replies; 6+ messages in thread
From: Zhenyu Wang @ 2019-05-14 6:56 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Aleksei Gimbitskii, intel-gfx, kernel-janitors,
intel-gvt-dev
[-- Attachment #1.1: Type: text/plain, Size: 1100 bytes --]
On 2019.05.13 12:22:44 +0300, Dan Carpenter wrote:
> "ret" is uninitialized on this path but it should be -EINVAL.
>
> Fixes: 930c8dfea4b8 ("drm/i915/gvt: Check if get_next_pt_type() always returns a valid value")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/i915/gvt/gtt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
> index 08c74e65836b..244ad1729764 100644
> --- a/drivers/gpu/drm/i915/gvt/gtt.c
> +++ b/drivers/gpu/drm/i915/gvt/gtt.c
> @@ -1076,8 +1076,10 @@ static struct intel_vgpu_ppgtt_spt *ppgtt_populate_spt_by_guest_entry(
> } else {
> int type = get_next_pt_type(we->type);
>
> - if (!gtt_type_is_pt(type))
> + if (!gtt_type_is_pt(type)) {
> + ret = -EINVAL;
> goto err;
> + }
>
> spt = ppgtt_alloc_spt_gfn(vgpu, type, ops->get_pfn(we), ips);
> if (IS_ERR(spt)) {
> --
Applied this, thanks!
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread