All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg at kroah.com (Greg KH)
Subject: [Linux-kernel-mentees] [PATCH v2] Staging: rtl8192u: ieee80211: Fix coding style warning
Date: Mon, 13 May 2019 11:36:20 +0200	[thread overview]
Message-ID: <20190513093620.GA833@kroah.com> (raw)
In-Reply-To: <20190502184534.GA10842@arch>

On Fri, May 03, 2019 at 12:15:34AM +0530, Puranjay Mohan wrote:
> Remove braces around a single if statement to fix following
> checkpatch.pl warning.
> WARNING: braces {} are not necessary for single statement blocks
> 
> Signed-off-by: Puranjay Mohan <puranjay12 at gmail.com>
> ---
> v2- Removed trailing whitespace.
> 
>  drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 0e762e559675..bd97531a254f 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
>  	spin_unlock_irqrestore(&ieee->lock, flags);
>  	if (is_beacon(beacon->header.frame_ctl)&&is_same_network(&ieee->current_network, network, ieee)&&\
>  		(ieee->state == IEEE80211_LINKED)) {
> -		if (ieee->handle_beacon != NULL) {
> +		if (ieee->handle_beacon != NULL)
>  			ieee->handle_beacon(ieee->dev,beacon,&ieee->current_network);
> -		}
> +
>  	}
> 
>  out:
> --
> 2.21.0
> 

You sent 5 patches for the same driver, yet no way of providing me the
information as to what order to apply them in.  I tried to guess, and
got it wrong, and so they would not all apply.

Please fix this up and resend all of them, as a numbered patch series,
so that I have a chance to get it right.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: greg@kroah.com (Greg KH)
Subject: [Linux-kernel-mentees] [PATCH v2] Staging: rtl8192u: ieee80211: Fix coding style warning
Date: Mon, 13 May 2019 11:36:20 +0200	[thread overview]
Message-ID: <20190513093620.GA833@kroah.com> (raw)
Message-ID: <20190513093620.03XiF-IcivmQy6UxLp5cwC9MBacUaKDE1hjVXG97PH8@z> (raw)
In-Reply-To: <20190502184534.GA10842@arch>

On Fri, May 03, 2019 at 12:15:34AM +0530, Puranjay Mohan wrote:
> Remove braces around a single if statement to fix following
> checkpatch.pl warning.
> WARNING: braces {} are not necessary for single statement blocks
> 
> Signed-off-by: Puranjay Mohan <puranjay12 at gmail.com>
> ---
> v2- Removed trailing whitespace.
> 
>  drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> index 0e762e559675..bd97531a254f 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
> @@ -2577,9 +2577,9 @@ static inline void ieee80211_process_probe_response(
>  	spin_unlock_irqrestore(&ieee->lock, flags);
>  	if (is_beacon(beacon->header.frame_ctl)&&is_same_network(&ieee->current_network, network, ieee)&&\
>  		(ieee->state == IEEE80211_LINKED)) {
> -		if (ieee->handle_beacon != NULL) {
> +		if (ieee->handle_beacon != NULL)
>  			ieee->handle_beacon(ieee->dev,beacon,&ieee->current_network);
> -		}
> +
>  	}
> 
>  out:
> --
> 2.21.0
> 

You sent 5 patches for the same driver, yet no way of providing me the
information as to what order to apply them in.  I tried to guess, and
got it wrong, and so they would not all apply.

Please fix this up and resend all of them, as a numbered patch series,
so that I have a chance to get it right.

thanks,

greg k-h

  reply	other threads:[~2019-05-13  9:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-02 18:45 [Linux-kernel-mentees] [PATCH v2] Staging: rtl8192u: ieee80211: Fix coding style warning puranjay12
2019-05-02 18:45 ` Puranjay Mohan
2019-05-13  9:36 ` greg [this message]
2019-05-13  9:36   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190513093620.GA833@kroah.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.