From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout
Date: Mon, 13 May 2019 07:52:35 -0600 [thread overview]
Message-ID: <20190513135235.GD15318@localhost.localdomain> (raw)
In-Reply-To: <1557676457-4195-7-git-send-email-akinobu.mita@gmail.com>
On Sun, May 12, 2019@08:54:16AM -0700, Akinobu Mita wrote:
> @@ -2536,6 +2539,9 @@ static void nvme_reset_work(struct work_struct *work)
> if (result)
> goto out;
>
> + nvme_coredump_logs(dev);
If you change nvme_coredump_logs to return an int, check it here for < 0
and abandon the reset if true.
> + nvme_coredump_complete(dev);
> +
> if (dev->ctrl.oacs & NVME_CTRL_OACS_SEC_SUPP) {
> if (!dev->ctrl.opal_dev)
> dev->ctrl.opal_dev =
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
"Busch, Keith" <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Minwoo Im <minwoo.im.dev@gmail.com>,
"Heitke, Kenneth" <kenneth.heitke@intel.com>
Subject: Re: [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout
Date: Mon, 13 May 2019 07:52:35 -0600 [thread overview]
Message-ID: <20190513135235.GD15318@localhost.localdomain> (raw)
In-Reply-To: <1557676457-4195-7-git-send-email-akinobu.mita@gmail.com>
On Sun, May 12, 2019 at 08:54:16AM -0700, Akinobu Mita wrote:
> @@ -2536,6 +2539,9 @@ static void nvme_reset_work(struct work_struct *work)
> if (result)
> goto out;
>
> + nvme_coredump_logs(dev);
If you change nvme_coredump_logs to return an int, check it here for < 0
and abandon the reset if true.
> + nvme_coredump_complete(dev);
> +
> if (dev->ctrl.oacs & NVME_CTRL_OACS_SEC_SUPP) {
> if (!dev->ctrl.opal_dev)
> dev->ctrl.opal_dev =
next prev parent reply other threads:[~2019-05-13 13:52 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 15:54 [PATCH v3 0/7] nvme-pci: support device coredump Akinobu Mita
2019-05-12 15:54 ` Akinobu Mita
2019-05-12 15:54 ` [PATCH v3 1/7] devcoredump: use memory_read_from_buffer Akinobu Mita
2019-05-12 15:54 ` Akinobu Mita
2019-05-13 15:28 ` Chaitanya Kulkarni
2019-05-13 15:28 ` Chaitanya Kulkarni
2019-05-12 15:54 ` [PATCH v3 2/7] devcoredump: fix typo in comment Akinobu Mita
2019-05-12 15:54 ` Akinobu Mita
2019-05-13 15:24 ` Chaitanya Kulkarni
2019-05-13 15:24 ` Chaitanya Kulkarni
2019-05-12 15:54 ` [PATCH v3 3/7] devcoredump: allow to create several coredump files in one device Akinobu Mita
2019-05-12 15:54 ` Akinobu Mita
2019-05-12 15:54 ` [PATCH v3 4/7] nvme: add basic facility to get telemetry log page Akinobu Mita
2019-05-12 15:54 ` Akinobu Mita
2019-05-13 15:34 ` Chaitanya Kulkarni
2019-05-13 15:34 ` Chaitanya Kulkarni
2019-05-14 14:04 ` Akinobu Mita
2019-05-14 14:04 ` Akinobu Mita
2019-05-12 15:54 ` [PATCH v3 5/7] nvme-pci: add device coredump infrastructure Akinobu Mita
2019-05-12 15:54 ` Akinobu Mita
2019-05-13 7:46 ` Minwoo Im
2019-05-13 7:46 ` Minwoo Im
2019-05-13 15:23 ` Chaitanya Kulkarni
2019-05-13 15:23 ` Chaitanya Kulkarni
2019-05-14 14:06 ` Akinobu Mita
2019-05-14 14:06 ` Akinobu Mita
2019-05-13 13:50 ` Keith Busch
2019-05-13 13:50 ` Keith Busch
2019-05-13 15:01 ` Akinobu Mita
2019-05-13 15:01 ` Akinobu Mita
2019-05-13 14:02 ` Christoph Hellwig
2019-05-13 14:02 ` Christoph Hellwig
2019-05-13 15:01 ` Akinobu Mita
2019-05-13 15:01 ` Akinobu Mita
2019-05-12 15:54 ` [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout Akinobu Mita
2019-05-12 15:54 ` Akinobu Mita
2019-05-13 7:41 ` Minwoo Im
2019-05-13 7:41 ` Minwoo Im
2019-05-13 14:59 ` Akinobu Mita
2019-05-13 14:59 ` Akinobu Mita
2019-05-13 13:52 ` Keith Busch [this message]
2019-05-13 13:52 ` Keith Busch
2019-05-12 15:54 ` [PATCH v3 7/7] nvme-pci: enable to trigger device coredump by hand Akinobu Mita
2019-05-12 15:54 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513135235.GD15318@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.