[PATCH 0/4] Misc patches

[PATCH 0/4] Misc patches

[Wei Liu]

Wei Liu (4):
  gitignore: ignore .vscode directory
  public/tmem.h: fix version number in comment
  README: document that `python` is required
  INSTALL: remove duplicate sentence

 .gitignore                | 1 +
 INSTALL                   | 1 -
 README                    | 4 ++++
 xen/include/public/tmem.h | 2 +-
 4 files changed, 6 insertions(+), 2 deletions(-)

-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 0/4] Misc patches

[Wei Liu]

Wei Liu (4):
  gitignore: ignore .vscode directory
  public/tmem.h: fix version number in comment
  README: document that `python` is required
  INSTALL: remove duplicate sentence

 .gitignore                | 1 +
 INSTALL                   | 1 -
 README                    | 4 ++++
 xen/include/public/tmem.h | 2 +-
 4 files changed, 6 insertions(+), 2 deletions(-)

-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH 1/4] gitignore: ignore .vscode directory

[Wei Liu]

The directory is created by Visual Studio Code editor to store its
local state.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 26bc583f74..3822bb75ba 100644
--- a/.gitignore
+++ b/.gitignore
@@ -30,6 +30,7 @@ cscope.out
 cscope.po.out
 .config
 .vimrc
+.vscode
 
 dist
 stubdom/*.tar.gz
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 1/4] gitignore: ignore .vscode directory

[Wei Liu]

The directory is created by Visual Studio Code editor to store its
local state.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 26bc583f74..3822bb75ba 100644
--- a/.gitignore
+++ b/.gitignore
@@ -30,6 +30,7 @@ cscope.out
 cscope.po.out
 .config
 .vimrc
+.vscode
 
 dist
 stubdom/*.tar.gz
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 1/4] gitignore: ignore .vscode directory

[Anthony PERARD]

On Mon, May 13, 2019 at 02:47:11PM +0100, Wei Liu wrote:
> The directory is created by Visual Studio Code editor to store its
> local state.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 26bc583f74..3822bb75ba 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -30,6 +30,7 @@ cscope.out
>  cscope.po.out
>  .config
>  .vimrc
> +.vscode

Shouldn't this go in "~/.config/git/ignore" instead? Or whatever `git
config core.excludesFile` point to.

`git help ignore` for more detail.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 1/4] gitignore: ignore .vscode directory

[Anthony PERARD]

On Mon, May 13, 2019 at 02:47:11PM +0100, Wei Liu wrote:
> The directory is created by Visual Studio Code editor to store its
> local state.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 26bc583f74..3822bb75ba 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -30,6 +30,7 @@ cscope.out
>  cscope.po.out
>  .config
>  .vimrc
> +.vscode

Shouldn't this go in "~/.config/git/ignore" instead? Or whatever `git
config core.excludesFile` point to.

`git help ignore` for more detail.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 1/4] gitignore: ignore .vscode directory

[Wei Liu]

On Mon, May 13, 2019 at 03:13:06PM +0100, Anthony PERARD wrote:
> On Mon, May 13, 2019 at 02:47:11PM +0100, Wei Liu wrote:
> > The directory is created by Visual Studio Code editor to store its
> > local state.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  .gitignore | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/.gitignore b/.gitignore
> > index 26bc583f74..3822bb75ba 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -30,6 +30,7 @@ cscope.out
> >  cscope.po.out
> >  .config
> >  .vimrc
> > +.vscode
> 
> Shouldn't this go in "~/.config/git/ignore" instead? Or whatever `git
> config core.excludesFile` point to.
> 
> `git help ignore` for more detail.

We already put a bunch of files for various tools in xen.git's
gitignore. I don't see why this can't be done for vscode.

Wei.

> 
> -- 
> Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 1/4] gitignore: ignore .vscode directory

[Wei Liu]

On Mon, May 13, 2019 at 03:13:06PM +0100, Anthony PERARD wrote:
> On Mon, May 13, 2019 at 02:47:11PM +0100, Wei Liu wrote:
> > The directory is created by Visual Studio Code editor to store its
> > local state.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  .gitignore | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/.gitignore b/.gitignore
> > index 26bc583f74..3822bb75ba 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -30,6 +30,7 @@ cscope.out
> >  cscope.po.out
> >  .config
> >  .vimrc
> > +.vscode
> 
> Shouldn't this go in "~/.config/git/ignore" instead? Or whatever `git
> config core.excludesFile` point to.
> 
> `git help ignore` for more detail.

We already put a bunch of files for various tools in xen.git's
gitignore. I don't see why this can't be done for vscode.

Wei.

> 
> -- 
> Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH 2/4] public/tmem.h: fix version number in comment

[Wei Liu]

The version number has been changed above due to rebasing onto 4.13
branch, but the one in the matching comment was left unchanged.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/include/public/tmem.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/public/tmem.h b/xen/include/public/tmem.h
index d9b1c266f6..362ba45d5a 100644
--- a/xen/include/public/tmem.h
+++ b/xen/include/public/tmem.h
@@ -107,7 +107,7 @@ typedef struct tmem_op tmem_op_t;
 DEFINE_XEN_GUEST_HANDLE(tmem_op_t);
 #endif
 
-#endif  /* __XEN_INTERFACE_VERSION__ < 0x00041200 */
+#endif  /* __XEN_INTERFACE_VERSION__ < 0x00041300 */
 
 #endif /* __XEN_PUBLIC_TMEM_H__ */
 
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 2/4] public/tmem.h: fix version number in comment

[Wei Liu]

The version number has been changed above due to rebasing onto 4.13
branch, but the one in the matching comment was left unchanged.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 xen/include/public/tmem.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/public/tmem.h b/xen/include/public/tmem.h
index d9b1c266f6..362ba45d5a 100644
--- a/xen/include/public/tmem.h
+++ b/xen/include/public/tmem.h
@@ -107,7 +107,7 @@ typedef struct tmem_op tmem_op_t;
 DEFINE_XEN_GUEST_HANDLE(tmem_op_t);
 #endif
 
-#endif  /* __XEN_INTERFACE_VERSION__ < 0x00041200 */
+#endif  /* __XEN_INTERFACE_VERSION__ < 0x00041300 */
 
 #endif /* __XEN_PUBLIC_TMEM_H__ */
 
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 2/4] public/tmem.h: fix version number in comment

[Jan Beulich]

>>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote:
> The version number has been changed above due to rebasing onto 4.13
> branch, but the one in the matching comment was left unchanged.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 2/4] public/tmem.h: fix version number in comment

[Jan Beulich]

>>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote:
> The version number has been changed above due to rebasing onto 4.13
> branch, but the one in the matching comment was left unchanged.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH 3/4] README: document that `python` is required

[Wei Liu]

The hypervisor build system requires `python`. To avoid putting too
much (confusing) information in README, mandate availability of
`python`.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 README | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/README b/README
index 23e4f7c3dc..a60ccf6e9c 100644
--- a/README
+++ b/README
@@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies:
           URL:    http://www.python.org/
           Debian: python
 
+Note that the build system expects `python` to be available. If your system
+only has `python2` or `python3` but not `python` (as in Linux From Scratch),
+you will need to create a symlink for it.
+
 Intel(R) Trusted Execution Technology Support
 =============================================
 
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 3/4] README: document that `python` is required

[Wei Liu]

The hypervisor build system requires `python`. To avoid putting too
much (confusing) information in README, mandate availability of
`python`.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 README | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/README b/README
index 23e4f7c3dc..a60ccf6e9c 100644
--- a/README
+++ b/README
@@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies:
           URL:    http://www.python.org/
           Debian: python
 
+Note that the build system expects `python` to be available. If your system
+only has `python2` or `python3` but not `python` (as in Linux From Scratch),
+you will need to create a symlink for it.
+
 Intel(R) Trusted Execution Technology Support
 =============================================
 
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 3/4] README: document that `python` is required

[Jan Beulich]

>>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote:
> --- a/README
> +++ b/README
> @@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies:
>            URL:    http://www.python.org/ 
>            Debian: python
>  
> +Note that the build system expects `python` to be available. If your system
> +only has `python2` or `python3` but not `python` (as in Linux From Scratch),
> +you will need to create a symlink for it.

Is creating a symlink indeed the only option? What about specifying
PYTHON= on the make cmdline? I don't mean to say the set of
workarounds needs to be exhaustive here, but perhaps add at
least "e.g." if there are other options as well?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 3/4] README: document that `python` is required

[Jan Beulich]

>>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote:
> --- a/README
> +++ b/README
> @@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies:
>            URL:    http://www.python.org/ 
>            Debian: python
>  
> +Note that the build system expects `python` to be available. If your system
> +only has `python2` or `python3` but not `python` (as in Linux From Scratch),
> +you will need to create a symlink for it.

Is creating a symlink indeed the only option? What about specifying
PYTHON= on the make cmdline? I don't mean to say the set of
workarounds needs to be exhaustive here, but perhaps add at
least "e.g." if there are other options as well?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 3/4] README: document that `python` is required

[Wei Liu]

On Mon, May 13, 2019 at 08:27:16AM -0600, Jan Beulich wrote:
> >>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote:
> > --- a/README
> > +++ b/README
> > @@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies:
> >            URL:    http://www.python.org/ 
> >            Debian: python
> >  
> > +Note that the build system expects `python` to be available. If your system
> > +only has `python2` or `python3` but not `python` (as in Linux From Scratch),
> > +you will need to create a symlink for it.
> 
> Is creating a symlink indeed the only option? What about specifying
> PYTHON= on the make cmdline? I don't mean to say the set of
> workarounds needs to be exhaustive here, but perhaps add at
> least "e.g." if there are other options as well?

Xen's build system is strange in that

   make A=B

is not the same as 

   A=B make

.

In practice this has bitten a few people in the past. That's why I opted
to not mention that variant.

But since you ask, I can add it to next version.

Wei.

> 
> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 3/4] README: document that `python` is required

[Wei Liu]

On Mon, May 13, 2019 at 08:27:16AM -0600, Jan Beulich wrote:
> >>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote:
> > --- a/README
> > +++ b/README
> > @@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies:
> >            URL:    http://www.python.org/ 
> >            Debian: python
> >  
> > +Note that the build system expects `python` to be available. If your system
> > +only has `python2` or `python3` but not `python` (as in Linux From Scratch),
> > +you will need to create a symlink for it.
> 
> Is creating a symlink indeed the only option? What about specifying
> PYTHON= on the make cmdline? I don't mean to say the set of
> workarounds needs to be exhaustive here, but perhaps add at
> least "e.g." if there are other options as well?

Xen's build system is strange in that

   make A=B

is not the same as 

   A=B make

.

In practice this has bitten a few people in the past. That's why I opted
to not mention that variant.

But since you ask, I can add it to next version.

Wei.

> 
> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 3/4] README: document that `python` is required

[George Dunlap]

On 5/13/19 2:47 PM, Wei Liu wrote:
> The hypervisor build system requires `python`. To avoid putting too
> much (confusing) information in README, mandate availability of
> `python`.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  README | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/README b/README
> index 23e4f7c3dc..a60ccf6e9c 100644
> --- a/README
> +++ b/README
> @@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies:
>            URL:    http://www.python.org/
>            Debian: python
>  
> +Note that the build system expects `python` to be available. If your system
> +only has `python2` or `python3` but not `python` (as in Linux From Scratch),
> +you will need to create a symlink for it.

Since we're not in a release crunch any more, it seems like updating
./configure to look for ""python3", "python2", and "python" (probably in
that order) would be a better solution here.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 3/4] README: document that `python` is required

[George Dunlap]

On 5/13/19 2:47 PM, Wei Liu wrote:
> The hypervisor build system requires `python`. To avoid putting too
> much (confusing) information in README, mandate availability of
> `python`.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  README | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/README b/README
> index 23e4f7c3dc..a60ccf6e9c 100644
> --- a/README
> +++ b/README
> @@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies:
>            URL:    http://www.python.org/
>            Debian: python
>  
> +Note that the build system expects `python` to be available. If your system
> +only has `python2` or `python3` but not `python` (as in Linux From Scratch),
> +you will need to create a symlink for it.

Since we're not in a release crunch any more, it seems like updating
./configure to look for ""python3", "python2", and "python" (probably in
that order) would be a better solution here.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 3/4] README: document that `python` is required

[Wei Liu]

On Mon, May 13, 2019 at 03:38:24PM +0100, George Dunlap wrote:
> On 5/13/19 2:47 PM, Wei Liu wrote:
> > The hypervisor build system requires `python`. To avoid putting too
> > much (confusing) information in README, mandate availability of
> > `python`.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  README | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/README b/README
> > index 23e4f7c3dc..a60ccf6e9c 100644
> > --- a/README
> > +++ b/README
> > @@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies:
> >            URL:    http://www.python.org/
> >            Debian: python
> >  
> > +Note that the build system expects `python` to be available. If your system
> > +only has `python2` or `python3` but not `python` (as in Linux From Scratch),
> > +you will need to create a symlink for it.
> 
> Since we're not in a release crunch any more, it seems like updating
> ./configure to look for ""python3", "python2", and "python" (probably in
> that order) would be a better solution here.

No, it is not about tools build. Hypervisor build depends on `python`
but we don't want it to depend on configure.

See "Hypervisor build can't work without `python` (Was: Re: Xen commit
9b0bc91b3 possibly removed too much info from README)"

Wei.

> 
>  -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 3/4] README: document that `python` is required

[Wei Liu]

On Mon, May 13, 2019 at 03:38:24PM +0100, George Dunlap wrote:
> On 5/13/19 2:47 PM, Wei Liu wrote:
> > The hypervisor build system requires `python`. To avoid putting too
> > much (confusing) information in README, mandate availability of
> > `python`.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  README | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/README b/README
> > index 23e4f7c3dc..a60ccf6e9c 100644
> > --- a/README
> > +++ b/README
> > @@ -181,6 +181,10 @@ Various tools, such as pygrub, have the following runtime dependencies:
> >            URL:    http://www.python.org/
> >            Debian: python
> >  
> > +Note that the build system expects `python` to be available. If your system
> > +only has `python2` or `python3` but not `python` (as in Linux From Scratch),
> > +you will need to create a symlink for it.
> 
> Since we're not in a release crunch any more, it seems like updating
> ./configure to look for ""python3", "python2", and "python" (probably in
> that order) would be a better solution here.

No, it is not about tools build. Hypervisor build depends on `python`
but we don't want it to depend on configure.

See "Hypervisor build can't work without `python` (Was: Re: Xen commit
9b0bc91b3 possibly removed too much info from README)"

Wei.

> 
>  -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[PATCH 4/4] INSTALL: remove duplicate sentence

[Wei Liu]

The same sentence is repeated in the next paragraph.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 INSTALL | 1 -
 1 file changed, 1 deletion(-)

diff --git a/INSTALL b/INSTALL
index 9aa9ebdddc..1665ddd6a4 100644
--- a/INSTALL
+++ b/INSTALL
@@ -225,7 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss
 SMBIOS_REL_DATE=mm/dd/yyyy
 VGABIOS_REL_DATE="dd Mon yyyy"
 
-During tools build external repos will be cloned into the source tree.
 This variable can be used to point to a different git binary to be used.
 GIT=
 
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 4/4] INSTALL: remove duplicate sentence

[Wei Liu]

The same sentence is repeated in the next paragraph.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 INSTALL | 1 -
 1 file changed, 1 deletion(-)

diff --git a/INSTALL b/INSTALL
index 9aa9ebdddc..1665ddd6a4 100644
--- a/INSTALL
+++ b/INSTALL
@@ -225,7 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss
 SMBIOS_REL_DATE=mm/dd/yyyy
 VGABIOS_REL_DATE="dd Mon yyyy"
 
-During tools build external repos will be cloned into the source tree.
 This variable can be used to point to a different git binary to be used.
 GIT=
 
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 4/4] INSTALL: remove duplicate sentence

[Jan Beulich]

>>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote:
> --- a/INSTALL
> +++ b/INSTALL
> @@ -225,7 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss
>  SMBIOS_REL_DATE=mm/dd/yyyy
>  VGABIOS_REL_DATE="dd Mon yyyy"
>  
> -During tools build external repos will be cloned into the source tree.
>  This variable can be used to point to a different git binary to be used.
>  GIT=

To me it would seem more logical to delete the other, later
instance of the sentence. You wouldn't need $(GIT) if there
was no cloning.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 4/4] INSTALL: remove duplicate sentence

[Jan Beulich]

>>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote:
> --- a/INSTALL
> +++ b/INSTALL
> @@ -225,7 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss
>  SMBIOS_REL_DATE=mm/dd/yyyy
>  VGABIOS_REL_DATE="dd Mon yyyy"
>  
> -During tools build external repos will be cloned into the source tree.
>  This variable can be used to point to a different git binary to be used.
>  GIT=

To me it would seem more logical to delete the other, later
instance of the sentence. You wouldn't need $(GIT) if there
was no cloning.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 4/4] INSTALL: remove duplicate sentence

[Wei Liu]

On Mon, May 13, 2019 at 08:29:14AM -0600, Jan Beulich wrote:
> >>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote:
> > --- a/INSTALL
> > +++ b/INSTALL
> > @@ -225,7 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss
> >  SMBIOS_REL_DATE=mm/dd/yyyy
> >  VGABIOS_REL_DATE="dd Mon yyyy"
> >  
> > -During tools build external repos will be cloned into the source tree.
> >  This variable can be used to point to a different git binary to be used.
> >  GIT=
> 
> To me it would seem more logical to delete the other, later
> instance of the sentence. You wouldn't need $(GIT) if there
> was no cloning.

But deleting that one would be wrong -- it would make that paragraph
seems to be only about stubdom, while in fact most of those envars are
about tools build.

Wei.

> 
> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 4/4] INSTALL: remove duplicate sentence

[Wei Liu]

On Mon, May 13, 2019 at 08:29:14AM -0600, Jan Beulich wrote:
> >>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote:
> > --- a/INSTALL
> > +++ b/INSTALL
> > @@ -225,7 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss
> >  SMBIOS_REL_DATE=mm/dd/yyyy
> >  VGABIOS_REL_DATE="dd Mon yyyy"
> >  
> > -During tools build external repos will be cloned into the source tree.
> >  This variable can be used to point to a different git binary to be used.
> >  GIT=
> 
> To me it would seem more logical to delete the other, later
> instance of the sentence. You wouldn't need $(GIT) if there
> was no cloning.

But deleting that one would be wrong -- it would make that paragraph
seems to be only about stubdom, while in fact most of those envars are
about tools build.

Wei.

> 
> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel