From: Rob Herring <robh@kernel.org>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Li Yang <leoyang.li@nxp.com>, Scott Wood <oss@buserror.net>,
Rasmus Villemoes <Rasmus.Villemoes@prevas.se>,
Mark Rutland <mark.rutland@arm.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Qiang Zhao <qiang.zhao@nxp.com>
Subject: Re: [PATCH v3 4/6] dt-bindings: soc/fsl: qe: document new fsl,qe-snums binding
Date: Mon, 13 May 2019 12:51:17 -0500 [thread overview]
Message-ID: <20190513175117.GA22288@bogus> (raw)
In-Reply-To: <20190513111442.25724-5-rasmus.villemoes@prevas.dk>
On Mon, 13 May 2019 11:14:58 +0000, Rasmus Villemoes wrote:
> Reading table 4-30, and its footnotes, of the QUICC Engine Block
> Reference Manual shows that the set of snum _values_ is not
> necessarily just a function of the _number_ of snums, as given in the
> fsl,qe-num-snums property.
>
> As an alternative, to make it easier to add support for other variants
> of the QUICC engine IP, this introduces a new binding fsl,qe-snums,
> which automatically encodes both the number of snums and the actual
> values to use.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> ---
> Rob, thanks for the review of v2. However, since I moved the example
> from the commit log to the binding (per Joakim's request), I didn't
> add a Reviewed-by tag for this revision.
>
> .../devicetree/bindings/soc/fsl/cpm_qe/qe.txt | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Li Yang <leoyang.li@nxp.com>, Scott Wood <oss@buserror.net>,
Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
Rasmus Villemoes <Rasmus.Villemoes@prevas.se>,
Mark Rutland <mark.rutland@arm.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Qiang Zhao <qiang.zhao@nxp.com>
Subject: Re: [PATCH v3 4/6] dt-bindings: soc/fsl: qe: document new fsl,qe-snums binding
Date: Mon, 13 May 2019 12:51:17 -0500 [thread overview]
Message-ID: <20190513175117.GA22288@bogus> (raw)
In-Reply-To: <20190513111442.25724-5-rasmus.villemoes@prevas.dk>
On Mon, 13 May 2019 11:14:58 +0000, Rasmus Villemoes wrote:
> Reading table 4-30, and its footnotes, of the QUICC Engine Block
> Reference Manual shows that the set of snum _values_ is not
> necessarily just a function of the _number_ of snums, as given in the
> fsl,qe-num-snums property.
>
> As an alternative, to make it easier to add support for other variants
> of the QUICC engine IP, this introduces a new binding fsl,qe-snums,
> which automatically encodes both the number of snums and the actual
> values to use.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> ---
> Rob, thanks for the review of v2. However, since I moved the example
> from the commit log to the binding (per Joakim's request), I didn't
> add a Reviewed-by tag for this revision.
>
> .../devicetree/bindings/soc/fsl/cpm_qe/qe.txt | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Scott Wood <oss@buserror.net>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Mark Rutland <mark.rutland@arm.com>,
Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
Rasmus Villemoes <Rasmus.Villemoes@prevas.se>
Subject: Re: [PATCH v3 4/6] dt-bindings: soc/fsl: qe: document new fsl,qe-snums binding
Date: Mon, 13 May 2019 12:51:17 -0500 [thread overview]
Message-ID: <20190513175117.GA22288@bogus> (raw)
In-Reply-To: <20190513111442.25724-5-rasmus.villemoes@prevas.dk>
On Mon, 13 May 2019 11:14:58 +0000, Rasmus Villemoes wrote:
> Reading table 4-30, and its footnotes, of the QUICC Engine Block
> Reference Manual shows that the set of snum _values_ is not
> necessarily just a function of the _number_ of snums, as given in the
> fsl,qe-num-snums property.
>
> As an alternative, to make it easier to add support for other variants
> of the QUICC engine IP, this introduces a new binding fsl,qe-snums,
> which automatically encodes both the number of snums and the actual
> values to use.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> ---
> Rob, thanks for the review of v2. However, since I moved the example
> from the commit log to the binding (per Joakim's request), I didn't
> add a Reviewed-by tag for this revision.
>
> .../devicetree/bindings/soc/fsl/cpm_qe/qe.txt | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2019-05-13 17:52 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 13:36 [PATCH RESEND 0/5] soc/fsl/qe: cleanups and new DT binding Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 13:36 ` [PATCH 1/5] soc/fsl/qe: qe.c: drop useless static qualifier Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 17:03 ` Christophe Leroy
2019-04-30 17:03 ` Christophe Leroy
2019-04-30 13:36 ` [PATCH 2/5] soc/fsl/qe: qe.c: reduce static memory footprint by 1.7K Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 17:12 ` Christophe Leroy
2019-04-30 17:12 ` Christophe Leroy
2019-05-01 5:51 ` Rasmus Villemoes
2019-05-01 5:51 ` Rasmus Villemoes
2019-05-01 5:51 ` Rasmus Villemoes
2019-04-30 13:36 ` [PATCH 3/5] soc/fsl/qe: qe.c: introduce qe_get_device_node helper Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 17:14 ` Christophe Leroy
2019-04-30 17:14 ` Christophe Leroy
2019-04-30 13:36 ` [PATCH 4/5] soc/fsl/qe: qe.c: support fsl,qe-snums property Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 17:19 ` Christophe Leroy
2019-04-30 17:19 ` Christophe Leroy
2019-05-01 6:00 ` Rasmus Villemoes
2019-05-01 6:00 ` Rasmus Villemoes
2019-05-01 6:00 ` Rasmus Villemoes
2019-04-30 13:36 ` [PATCH 5/5] soc/fsl/qe: qe.c: fold qe_get_num_of_snums into qe_snums_init Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 13:36 ` Rasmus Villemoes
2019-04-30 17:27 ` Christophe Leroy
2019-04-30 17:27 ` Christophe Leroy
2019-05-01 9:29 ` [PATCH v2 0/6] soc/fsl/qe: cleanups and new DT binding Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-01 9:29 ` [PATCH v2 1/6] soc/fsl/qe: qe.c: drop useless static qualifier Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-01 9:29 ` [PATCH v2 2/6] soc/fsl/qe: qe.c: reduce static memory footprint by 1.7K Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-02 4:51 ` Christophe Leroy
2019-05-02 4:51 ` Christophe Leroy
2019-05-02 4:51 ` Christophe Leroy
2019-05-01 9:29 ` [PATCH v2 3/6] soc/fsl/qe: qe.c: introduce qe_get_device_node helper Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-01 9:29 ` [PATCH v2 4/6] dt-bindings: soc/fsl: qe: document new fsl,qe-snums binding Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-01 15:12 ` Joakim Tjernlund
2019-05-01 15:12 ` Joakim Tjernlund
2019-05-01 15:12 ` Joakim Tjernlund
2019-05-01 18:47 ` Rasmus Villemoes
2019-05-01 18:47 ` Rasmus Villemoes
2019-05-01 18:47 ` Rasmus Villemoes
2019-05-01 21:00 ` Rob Herring
2019-05-01 21:00 ` Rob Herring
2019-05-01 21:00 ` Rob Herring
2019-05-01 9:29 ` [PATCH v2 5/6] soc/fsl/qe: qe.c: support fsl,qe-snums property Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-02 4:52 ` Christophe Leroy
2019-05-02 4:52 ` Christophe Leroy
2019-05-02 4:52 ` Christophe Leroy
2019-05-01 9:29 ` [PATCH v2 6/6] soc/fsl/qe: qe.c: fold qe_get_num_of_snums into qe_snums_init Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-01 9:29 ` Rasmus Villemoes
2019-05-02 4:54 ` Christophe Leroy
2019-05-02 4:54 ` Christophe Leroy
2019-05-02 4:54 ` Christophe Leroy
2019-05-09 2:35 ` [EXT] " Qiang Zhao
2019-05-09 2:35 ` Qiang Zhao
2019-05-09 2:35 ` Qiang Zhao
2019-05-13 11:14 ` [PATCH v3 0/6] soc/fsl/qe: cleanups and new DT binding Rasmus Villemoes
2019-05-13 11:14 ` Rasmus Villemoes
2019-05-13 11:14 ` Rasmus Villemoes
2019-05-13 11:14 ` [PATCH v3 1/6] soc/fsl/qe: qe.c: drop useless static qualifier Rasmus Villemoes
2019-05-13 11:14 ` Rasmus Villemoes
2019-05-13 11:14 ` Rasmus Villemoes
2019-05-13 11:14 ` Rasmus Villemoes
2019-05-13 11:14 ` [PATCH v3 2/6] soc/fsl/qe: qe.c: reduce static memory footprint by 1.7K Rasmus Villemoes
2019-05-13 11:14 ` Rasmus Villemoes
2019-05-13 11:14 ` Rasmus Villemoes
2019-05-13 11:14 ` [PATCH v3 3/6] soc/fsl/qe: qe.c: introduce qe_get_device_node helper Rasmus Villemoes
2019-05-13 11:14 ` Rasmus Villemoes
2019-05-13 11:14 ` Rasmus Villemoes
2019-05-13 11:14 ` [PATCH v3 4/6] dt-bindings: soc/fsl: qe: document new fsl,qe-snums binding Rasmus Villemoes
2019-05-13 11:14 ` Rasmus Villemoes
2019-05-13 11:14 ` Rasmus Villemoes
2019-05-13 11:39 ` Joakim Tjernlund
2019-05-13 11:39 ` Joakim Tjernlund
2019-05-13 11:39 ` Joakim Tjernlund
2019-05-13 17:51 ` Rob Herring [this message]
2019-05-13 17:51 ` Rob Herring
2019-05-13 17:51 ` Rob Herring
2019-05-13 11:15 ` [PATCH v3 5/6] soc/fsl/qe: qe.c: support fsl,qe-snums property Rasmus Villemoes
2019-05-13 11:15 ` Rasmus Villemoes
2019-05-13 11:15 ` Rasmus Villemoes
2019-05-13 11:15 ` [PATCH v3 6/6] soc/fsl/qe: qe.c: fold qe_get_num_of_snums into qe_snums_init Rasmus Villemoes
2019-05-13 11:15 ` Rasmus Villemoes
2019-05-13 11:15 ` Rasmus Villemoes
2019-06-03 19:53 ` [PATCH v3 0/6] soc/fsl/qe: cleanups and new DT binding Rasmus Villemoes
2019-06-03 19:53 ` Rasmus Villemoes
2019-06-03 19:53 ` Rasmus Villemoes
2019-06-03 19:55 ` Leo Li
2019-06-03 19:55 ` Leo Li
2019-06-03 19:55 ` Leo Li
2019-06-04 20:29 ` Li Yang
2019-06-04 20:29 ` Li Yang
2019-06-04 20:29 ` Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513175117.GA22288@bogus \
--to=robh@kernel.org \
--cc=Rasmus.Villemoes@prevas.se \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=oss@buserror.net \
--cc=qiang.zhao@nxp.com \
--cc=rasmus.villemoes@prevas.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.