Re: [PATCH v3] ARM: dts: imx: Fix the AR803X phy-mode

From: Sasha Levin <sashal@kernel.org>
To: "George G. Davis" <george_davis@mentor.com>
Cc: andrew@lunn.ch, baruch@tkos.co.il,
	Fabio Estevam <festevam@gmail.com>,
	ken.lin@advantech.com, stable@vger.kernel.org, smoch@web.de,
	stwiss.opensource@diasemi.com, linux-imx@nxp.com,
	kernel@pengutronix.de, aford173@gmail.com,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] ARM: dts: imx: Fix the AR803X phy-mode
Date: Mon, 13 May 2019 20:45:39 -0400	[thread overview]
Message-ID: <20190514004539.GG11972@sasha-vm> (raw)
In-Reply-To: <20190513171826.GA18591@mam-gdavis-lt>

On Mon, May 13, 2019 at 01:18:27PM -0400, George G. Davis wrote:
>Hello,
>
>On Wed, Apr 03, 2019 at 07:12:41PM -0300, Fabio Estevam wrote:
>> Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
>> exposed an issue on imx DTS files using AR8031/AR8035 PHYs.
>>
>> The end result is that the boards can no longer obtain an IP address
>> via UDHCP, for example.
>>
>> Quoting Andrew Lunn:
>>
>> "The problem here is, all the DTs were broken since day 0. However,
>> because the PHY driver was also broken, nobody noticed and it
>> worked. Now that the PHY driver has been fixed, all the bugs in the
>> DTs now become an issue"
>>
>> To fix this problem, the phy-mode property needs to be "rgmii-id",  which
>> has the following meaning as per
>> Documentation/devicetree/bindings/net/ethernet.txt:
>>
>> "RGMII with internal RX and TX delays provided by the PHY, the MAC should
>> not add the RX or TX delays in this case)"
>>
>> Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with
>> successfully restored networking.
>>
>> Based on the initial submission from Steve Twiss for the
>> imx6qdl-sabresd.
>>
>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
>> Tested-by: Baruch Siach <baruch@tkos.co.il>
>> Tested-by: Soeren Moch <smoch@web.de>
>> Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
>> Tested-by: Adam Thomson <Adam.Thomson@diasemi.com>
>> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
>> Tested-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>> Changes since v2:
>> - Also fixed imx6q-ba16
>> - Removed stable tag as it does not apply cleanly on older
>> stable trees. I can manually generate versions for stable
>> trees after this one hits mainline.
>
>Please add this commit to the v5.1.x stable queue to resolve NFS root breakage
>in v5.1. I can confirm that it applies cleanly to v5.1.1 and resolves NFS root
>breakage that occurs on i.MX6 boards in v5.1.x, tested on imx6q-sabreauto.dts
>and imx6q-sabresd.dts. Although the fix should be backported to pre-v5.1.x
>stable series as well, it does not cause problems for pre-v5.1 but results in
>NFS root breakage for v5.1.x.

What's the commit id in Linus's tree? I don't see it.

--
Thanks,
Sasha

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel