* [PATCH] powerpc/security: Fix build break
@ 2019-05-15 4:52 ` Joel Stanley
0 siblings, 0 replies; 6+ messages in thread
From: Joel Stanley @ 2019-05-15 4:52 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linuxppc-dev, linux-kernel, stable, Josh Poimboeuf
This fixes a build break introduced in with the recent round of CPU
bug patches.
arch/powerpc/kernel/security.c: In function ‘setup_barrier_nospec’:
arch/powerpc/kernel/security.c:59:21: error: implicit declaration of
function ‘cpu_mitigations_off’ [-Werror=implicit-function-declaration]
if (!no_nospec && !cpu_mitigations_off())
^~~~~~~~~~~~~~~~~~~
Fixes: 782e69efb3df ("powerpc/speculation: Support 'mitigations=' cmdline option")
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
This should be applied to the 4.14 and 4.19 trees. There is no issue
with 5.1. The commit message contains a fixes line for the commit in
Linus tree.
---
arch/powerpc/kernel/security.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/security.c b/arch/powerpc/kernel/security.c
index e9af5d9badf2..68d4ec373cfc 100644
--- a/arch/powerpc/kernel/security.c
+++ b/arch/powerpc/kernel/security.c
@@ -4,6 +4,7 @@
//
// Copyright 2018, Michael Ellerman, IBM Corporation.
+#include <linux/cpu.h>
#include <linux/kernel.h>
#include <linux/device.h>
#include <linux/seq_buf.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] powerpc/security: Fix build break
@ 2019-05-15 4:52 ` Joel Stanley
0 siblings, 0 replies; 6+ messages in thread
From: Joel Stanley @ 2019-05-15 4:52 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Josh Poimboeuf, Michael Ellerman, linux-kernel, stable,
linuxppc-dev
This fixes a build break introduced in with the recent round of CPU
bug patches.
arch/powerpc/kernel/security.c: In function ‘setup_barrier_nospec’:
arch/powerpc/kernel/security.c:59:21: error: implicit declaration of
function ‘cpu_mitigations_off’ [-Werror=implicit-function-declaration]
if (!no_nospec && !cpu_mitigations_off())
^~~~~~~~~~~~~~~~~~~
Fixes: 782e69efb3df ("powerpc/speculation: Support 'mitigations=' cmdline option")
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
This should be applied to the 4.14 and 4.19 trees. There is no issue
with 5.1. The commit message contains a fixes line for the commit in
Linus tree.
---
arch/powerpc/kernel/security.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/security.c b/arch/powerpc/kernel/security.c
index e9af5d9badf2..68d4ec373cfc 100644
--- a/arch/powerpc/kernel/security.c
+++ b/arch/powerpc/kernel/security.c
@@ -4,6 +4,7 @@
//
// Copyright 2018, Michael Ellerman, IBM Corporation.
+#include <linux/cpu.h>
#include <linux/kernel.h>
#include <linux/device.h>
#include <linux/seq_buf.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc/security: Fix build break
2019-05-15 4:52 ` Joel Stanley
@ 2019-05-15 5:18 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2019-05-15 5:18 UTC (permalink / raw)
To: Joel Stanley; +Cc: linuxppc-dev, linux-kernel, stable, Josh Poimboeuf
On Wed, May 15, 2019 at 02:22:06PM +0930, Joel Stanley wrote:
> This fixes a build break introduced in with the recent round of CPU
> bug patches.
>
> arch/powerpc/kernel/security.c: In function ‘setup_barrier_nospec’:
> arch/powerpc/kernel/security.c:59:21: error: implicit declaration of
> function ‘cpu_mitigations_off’ [-Werror=implicit-function-declaration]
> if (!no_nospec && !cpu_mitigations_off())
> ^~~~~~~~~~~~~~~~~~~
>
> Fixes: 782e69efb3df ("powerpc/speculation: Support 'mitigations=' cmdline option")
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> This should be applied to the 4.14 and 4.19 trees. There is no issue
> with 5.1. The commit message contains a fixes line for the commit in
> Linus tree.
> ---
> arch/powerpc/kernel/security.c | 1 +
> 1 file changed, 1 insertion(+)
Isn't this just commit 42e2acde1237 ("powerpc/64s: Include cpu header")?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc/security: Fix build break
@ 2019-05-15 5:18 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2019-05-15 5:18 UTC (permalink / raw)
To: Joel Stanley
Cc: Josh Poimboeuf, Michael Ellerman, linux-kernel, stable,
linuxppc-dev
On Wed, May 15, 2019 at 02:22:06PM +0930, Joel Stanley wrote:
> This fixes a build break introduced in with the recent round of CPU
> bug patches.
>
> arch/powerpc/kernel/security.c: In function ‘setup_barrier_nospec’:
> arch/powerpc/kernel/security.c:59:21: error: implicit declaration of
> function ‘cpu_mitigations_off’ [-Werror=implicit-function-declaration]
> if (!no_nospec && !cpu_mitigations_off())
> ^~~~~~~~~~~~~~~~~~~
>
> Fixes: 782e69efb3df ("powerpc/speculation: Support 'mitigations=' cmdline option")
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> This should be applied to the 4.14 and 4.19 trees. There is no issue
> with 5.1. The commit message contains a fixes line for the commit in
> Linus tree.
> ---
> arch/powerpc/kernel/security.c | 1 +
> 1 file changed, 1 insertion(+)
Isn't this just commit 42e2acde1237 ("powerpc/64s: Include cpu header")?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc/security: Fix build break
2019-05-15 5:18 ` Greg Kroah-Hartman
@ 2019-05-15 6:08 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2019-05-15 6:08 UTC (permalink / raw)
To: Joel Stanley; +Cc: linuxppc-dev, linux-kernel, stable, Josh Poimboeuf
On Wed, May 15, 2019 at 07:18:30AM +0200, Greg Kroah-Hartman wrote:
> On Wed, May 15, 2019 at 02:22:06PM +0930, Joel Stanley wrote:
> > This fixes a build break introduced in with the recent round of CPU
> > bug patches.
> >
> > arch/powerpc/kernel/security.c: In function ‘setup_barrier_nospec’:
> > arch/powerpc/kernel/security.c:59:21: error: implicit declaration of
> > function ‘cpu_mitigations_off’ [-Werror=implicit-function-declaration]
> > if (!no_nospec && !cpu_mitigations_off())
> > ^~~~~~~~~~~~~~~~~~~
> >
> > Fixes: 782e69efb3df ("powerpc/speculation: Support 'mitigations=' cmdline option")
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > ---
> > This should be applied to the 4.14 and 4.19 trees. There is no issue
> > with 5.1. The commit message contains a fixes line for the commit in
> > Linus tree.
> > ---
> > arch/powerpc/kernel/security.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Isn't this just commit 42e2acde1237 ("powerpc/64s: Include cpu header")?
Which I have now queued up.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc/security: Fix build break
@ 2019-05-15 6:08 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2019-05-15 6:08 UTC (permalink / raw)
To: Joel Stanley
Cc: Josh Poimboeuf, Michael Ellerman, linux-kernel, stable,
linuxppc-dev
On Wed, May 15, 2019 at 07:18:30AM +0200, Greg Kroah-Hartman wrote:
> On Wed, May 15, 2019 at 02:22:06PM +0930, Joel Stanley wrote:
> > This fixes a build break introduced in with the recent round of CPU
> > bug patches.
> >
> > arch/powerpc/kernel/security.c: In function ‘setup_barrier_nospec’:
> > arch/powerpc/kernel/security.c:59:21: error: implicit declaration of
> > function ‘cpu_mitigations_off’ [-Werror=implicit-function-declaration]
> > if (!no_nospec && !cpu_mitigations_off())
> > ^~~~~~~~~~~~~~~~~~~
> >
> > Fixes: 782e69efb3df ("powerpc/speculation: Support 'mitigations=' cmdline option")
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > ---
> > This should be applied to the 4.14 and 4.19 trees. There is no issue
> > with 5.1. The commit message contains a fixes line for the commit in
> > Linus tree.
> > ---
> > arch/powerpc/kernel/security.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> Isn't this just commit 42e2acde1237 ("powerpc/64s: Include cpu header")?
Which I have now queued up.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-15 6:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-15 4:52 [PATCH] powerpc/security: Fix build break Joel Stanley
2019-05-15 4:52 ` Joel Stanley
2019-05-15 5:18 ` Greg Kroah-Hartman
2019-05-15 5:18 ` Greg Kroah-Hartman
2019-05-15 6:08 ` Greg Kroah-Hartman
2019-05-15 6:08 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.