From: Petr Vorel <pvorel@suse.cz>
To: Ignaz Forster <iforster@suse.de>
Cc: ltp@lists.linux.it, Mimi Zohar <zohar@linux.vnet.ibm.com>,
Fabian Vogt <FVogt@suse.com>, Marcus Meissner <meissner@suse.com>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2 3/3] ima: Add overlay test
Date: Wed, 15 May 2019 13:32:29 +0200 [thread overview]
Message-ID: <20190515113229.GA22920@dell5510> (raw)
In-Reply-To: <810d4df7-1e5e-dd24-8b87-e0fa3edbd25f@suse.de>
Hi Ignaz,
> thanks a lot for your continued work on the IMA / EVM tests and sorry for
> missing feedback - the mail got lost in my stack of TODO items.
Not a big deal and thanks a lot for a feedback and info.
> Am 05.04.19 um 18:52 Uhr schrieb Petr Vorel:
> > Should I check EVM enabled?
> As these tests require an appropriately prepared machine anyway: How about
> printing a message whether only IMA or both IMA and EVM are enabled. These
> tests make sense in both cases, so I wouldn't block them on either setup.
> > /sys/kernel/security/evm should be 1?
> Yes, that should be enough to detect whether EVM is enabled.
> > +test1()
> > +{
> > + local file="foo1.txt"
> > +
> > + tst_res TINFO "overwrite file in overlay"
> > + ROD echo lower \> $lower/$file
> > + EXPECT_PASS echo overlay \> $merged/$file
> It seems the redirection / escaping is wrong here: the string "overlay"
> never ends up in the target file.
I'm pretty sure that '>' should be escaped for both ROD and EXPECT_PASS.
EXPECT_PASS should fail (something like "evm_overlay 1 TFAIL: echo overlay ...
failed unexpectedly") if "overlay" string didn't get into $merged/$file file.
Can you sent whole output?
Kind regards,
Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 3/3] ima: Add overlay test
Date: Wed, 15 May 2019 13:32:29 +0200 [thread overview]
Message-ID: <20190515113229.GA22920@dell5510> (raw)
In-Reply-To: <810d4df7-1e5e-dd24-8b87-e0fa3edbd25f@suse.de>
Hi Ignaz,
> thanks a lot for your continued work on the IMA / EVM tests and sorry for
> missing feedback - the mail got lost in my stack of TODO items.
Not a big deal and thanks a lot for a feedback and info.
> Am 05.04.19 um 18:52 Uhr schrieb Petr Vorel:
> > Should I check EVM enabled?
> As these tests require an appropriately prepared machine anyway: How about
> printing a message whether only IMA or both IMA and EVM are enabled. These
> tests make sense in both cases, so I wouldn't block them on either setup.
> > /sys/kernel/security/evm should be 1?
> Yes, that should be enough to detect whether EVM is enabled.
> > +test1()
> > +{
> > + local file="foo1.txt"
> > +
> > + tst_res TINFO "overwrite file in overlay"
> > + ROD echo lower \> $lower/$file
> > + EXPECT_PASS echo overlay \> $merged/$file
> It seems the redirection / escaping is wrong here: the string "overlay"
> never ends up in the target file.
I'm pretty sure that '>' should be escaped for both ROD and EXPECT_PASS.
EXPECT_PASS should fail (something like "evm_overlay 1 TFAIL: echo overlay ...
failed unexpectedly") if "overlay" string didn't get into $merged/$file file.
Can you sent whole output?
Kind regards,
Petr
next prev parent reply other threads:[~2019-05-15 11:32 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 16:52 [PATCH v2 0/3] LTP reproducer on broken IMA on overlayfs Petr Vorel
2019-04-05 16:52 ` [LTP] " Petr Vorel
2019-04-05 16:52 ` [PATCH v2 1/3] ima: Call test's cleanup inside ima_setup.sh cleanup Petr Vorel
2019-04-05 16:52 ` [LTP] " Petr Vorel
2019-04-11 0:59 ` Mimi Zohar
2019-04-11 0:59 ` [LTP] " Mimi Zohar
2019-04-11 5:51 ` Petr Vorel
2019-04-11 5:51 ` [LTP] " Petr Vorel
2019-04-11 12:22 ` Mimi Zohar
2019-04-11 12:22 ` [LTP] " Mimi Zohar
2019-04-11 20:21 ` Petr Vorel
2019-04-11 20:21 ` [LTP] " Petr Vorel
2019-04-05 16:52 ` [PATCH v2 2/3] shell: Add $TST_DEVICE as default parameter to tst_umount Petr Vorel
2019-04-05 16:52 ` [LTP] " Petr Vorel
2019-04-05 16:52 ` [PATCH v2 3/3] ima: Add overlay test Petr Vorel
2019-04-05 16:52 ` [LTP] " Petr Vorel
2019-05-14 18:42 ` Ignaz Forster
2019-05-14 18:42 ` [LTP] " Ignaz Forster
2019-05-15 11:32 ` Petr Vorel [this message]
2019-05-15 11:32 ` Petr Vorel
2019-05-14 12:12 ` [PATCH v2 0/3] LTP reproducer on broken IMA on overlayfs Petr Vorel
2019-05-14 12:12 ` [LTP] " Petr Vorel
2019-05-14 19:19 ` Ignaz Forster
2019-05-14 19:19 ` [LTP] " Ignaz Forster
2019-05-15 11:34 ` Petr Vorel
2019-05-15 11:34 ` [LTP] " Petr Vorel
2019-05-15 3:01 ` Mimi Zohar
2019-05-15 3:01 ` [LTP] " Mimi Zohar
2019-05-15 12:08 ` Petr Vorel
2019-05-15 12:08 ` [LTP] " Petr Vorel
2019-05-16 22:10 ` Mimi Zohar
2019-05-16 22:10 ` [LTP] " Mimi Zohar
2019-05-17 7:50 ` Petr Vorel
2019-05-17 7:50 ` [LTP] " Petr Vorel
2019-05-17 11:00 ` Mimi Zohar
2019-05-17 11:00 ` [LTP] " Mimi Zohar
2019-05-17 15:41 ` Petr Vorel
2019-05-17 15:41 ` [LTP] " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515113229.GA22920@dell5510 \
--to=pvorel@suse.cz \
--cc=FVogt@suse.com \
--cc=iforster@suse.de \
--cc=linux-integrity@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=meissner@suse.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.