From: Greg KH <gregkh@linuxfoundation.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: erhard_f@mailbox.org, Michael Neuling <mikey@neuling.org>,
linux-kernel@vger.kernel.org,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH stable 4.9] powerpc/lib: fix book3s/32 boot failure due to code patching
Date: Wed, 15 May 2019 15:08:25 +0200 [thread overview]
Message-ID: <20190515130825.GA3794@kroah.com> (raw)
In-Reply-To: <9e58348f-da2d-34bc-d016-7817b3566e01@c-s.fr>
On Wed, May 15, 2019 at 02:35:36PM +0200, Christophe Leroy wrote:
>
>
> Le 15/05/2019 à 10:29, Greg KH a écrit :
> > On Wed, May 15, 2019 at 06:40:47AM +0000, Christophe Leroy wrote:
> > > [Backport of upstream commit b45ba4a51cde29b2939365ef0c07ad34c8321789]
> > >
> > > On powerpc32, patch_instruction() is called by apply_feature_fixups()
> > > which is called from early_init()
> > >
> > > There is the following note in front of early_init():
> > > * Note that the kernel may be running at an address which is different
> > > * from the address that it was linked at, so we must use RELOC/PTRRELOC
> > > * to access static data (including strings). -- paulus
> > >
> > > Therefore init_mem_is_free must be accessed with PTRRELOC()
> > >
> > > Fixes: 1c38a84d4586 ("powerpc: Avoid code patching freed init sections")
> > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=203597
> > > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> > >
> > > ---
> > > Can't apply the upstream commit as such due to several other unrelated stuff
> > > like for instance STRICT_KERNEL_RWX which are missing.
> > > So instead, using same approach as for commit 252eb55816a6f69ef9464cad303cdb3326cdc61d
> >
> > Now queued up, thanks.
> >
>
> Should go to 4.4 as well since the commit it fixes is now queued for 4.4
> ([PATCH 4.4 056/266] powerpc: Avoid code patching freed init sections)
Ok, can someone send me a backport that actually applies there?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
erhard_f@mailbox.org, Michael Neuling <mikey@neuling.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH stable 4.9] powerpc/lib: fix book3s/32 boot failure due to code patching
Date: Wed, 15 May 2019 15:08:25 +0200 [thread overview]
Message-ID: <20190515130825.GA3794@kroah.com> (raw)
In-Reply-To: <9e58348f-da2d-34bc-d016-7817b3566e01@c-s.fr>
On Wed, May 15, 2019 at 02:35:36PM +0200, Christophe Leroy wrote:
>
>
> Le 15/05/2019 à 10:29, Greg KH a écrit :
> > On Wed, May 15, 2019 at 06:40:47AM +0000, Christophe Leroy wrote:
> > > [Backport of upstream commit b45ba4a51cde29b2939365ef0c07ad34c8321789]
> > >
> > > On powerpc32, patch_instruction() is called by apply_feature_fixups()
> > > which is called from early_init()
> > >
> > > There is the following note in front of early_init():
> > > * Note that the kernel may be running at an address which is different
> > > * from the address that it was linked at, so we must use RELOC/PTRRELOC
> > > * to access static data (including strings). -- paulus
> > >
> > > Therefore init_mem_is_free must be accessed with PTRRELOC()
> > >
> > > Fixes: 1c38a84d4586 ("powerpc: Avoid code patching freed init sections")
> > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=203597
> > > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> > >
> > > ---
> > > Can't apply the upstream commit as such due to several other unrelated stuff
> > > like for instance STRICT_KERNEL_RWX which are missing.
> > > So instead, using same approach as for commit 252eb55816a6f69ef9464cad303cdb3326cdc61d
> >
> > Now queued up, thanks.
> >
>
> Should go to 4.4 as well since the commit it fixes is now queued for 4.4
> ([PATCH 4.4 056/266] powerpc: Avoid code patching freed init sections)
Ok, can someone send me a backport that actually applies there?
thanks,
greg k-h
next prev parent reply other threads:[~2019-05-15 13:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 6:39 [PATCH] powerpc/lib: fix book3s/32 boot failure due to code patching Christophe Leroy
2019-05-15 6:40 ` [PATCH stable 4.9] " Christophe Leroy
2019-05-15 6:41 ` [PATCH] " Christophe Leroy
2019-05-15 8:29 ` [PATCH stable 4.9] " Greg KH
2019-05-15 8:29 ` Greg KH
2019-05-15 12:35 ` Christophe Leroy
2019-05-15 12:35 ` Christophe Leroy
2019-05-15 13:08 ` Greg KH [this message]
2019-05-15 13:08 ` Greg KH
2019-05-15 13:31 ` Christophe Leroy
2019-05-15 13:31 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515130825.GA3794@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=christophe.leroy@c-s.fr \
--cc=erhard_f@mailbox.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.