All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH] protobuf: Fix ptest compilation
@ 2019-04-16 15:34 Oleksiy Obitotskyy
  2019-05-16  8:32 ` Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco)
  0 siblings, 1 reply; 7+ messages in thread
From: Oleksiy Obitotskyy @ 2019-04-16 15:34 UTC (permalink / raw)
  To: openembedded-core

Tests require c++11 support, so add -std=c++11
to compiler flags.

Upstream-Status: Pending
Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
---
 meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb b/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
index cf72d9ca7..4791e13ca 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
@@ -40,8 +40,8 @@ do_compile_ptest() {
 	# which haven't been installed yet.
 	cp "${B}/protobuf.pc" "${B}/${TEST_SRC_DIR}/protobuf.pc"
 	sed -e 's|libdir=|libdir=${PKG_CONFIG_SYSROOT_DIR}|' -i "${B}/${TEST_SRC_DIR}/protobuf.pc"
-	sed -e 's|Cflags:|Cflags: -I${S}/src|' -i "${B}/${TEST_SRC_DIR}/protobuf.pc"
-	sed -e 's|Libs:|Libs: -L${B}/src/.libs|' -i "${B}/${TEST_SRC_DIR}/protobuf.pc"
+	sed -e 's|Cflags:|Cflags: -std=c++11 -I${S}/src|' -i "${B}/${TEST_SRC_DIR}/protobuf.pc"
+	sed -e 's|Libs:|Libs: -std=c++11 -L${B}/src/.libs|' -i "${B}/${TEST_SRC_DIR}/protobuf.pc"
 	export PKG_CONFIG_PATH="${B}/${TEST_SRC_DIR}"
 
 	# Save the pkgcfg sysroot variable, and update it to nothing so
-- 
2.19.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [meta-oe][PATCH] protobuf: Fix ptest compilation
  2019-04-16 15:34 Oleksiy Obitotskyy
@ 2019-05-16  8:32 ` Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco)
  2019-05-16  8:36   ` Richard Purdie
  0 siblings, 1 reply; 7+ messages in thread
From: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco) @ 2019-05-16  8:32 UTC (permalink / raw)
  To: openembedded-core@lists.openembedded.org

Any comments?

Regards,
Oleksiy

On 16.04.19 18:34, Oleksiy Obitotskyy wrote:
> Tests require c++11 support, so add -std=c++11
> to compiler flags.
>
> Upstream-Status: Pending
> Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
> ---
>  meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb b/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
> index cf72d9ca7..4791e13ca 100644
> --- a/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
> +++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
> @@ -40,8 +40,8 @@ do_compile_ptest() {
>  	# which haven't been installed yet.
>  	cp "${B}/protobuf.pc" "${B}/${TEST_SRC_DIR}/protobuf.pc"
>  	sed -e 's|libdir=|libdir=${PKG_CONFIG_SYSROOT_DIR}|' -i "${B}/${TEST_SRC_DIR}/protobuf.pc"
> -	sed -e 's|Cflags:|Cflags: -I${S}/src|' -i "${B}/${TEST_SRC_DIR}/protobuf.pc"
> -	sed -e 's|Libs:|Libs: -L${B}/src/.libs|' -i "${B}/${TEST_SRC_DIR}/protobuf.pc"
> +	sed -e 's|Cflags:|Cflags: -std=c++11 -I${S}/src|' -i "${B}/${TEST_SRC_DIR}/protobuf.pc"
> +	sed -e 's|Libs:|Libs: -std=c++11 -L${B}/src/.libs|' -i "${B}/${TEST_SRC_DIR}/protobuf.pc"
>  	export PKG_CONFIG_PATH="${B}/${TEST_SRC_DIR}"
>  
>  	# Save the pkgcfg sysroot variable, and update it to nothing so



^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [meta-oe][PATCH] protobuf: Fix ptest compilation
  2019-05-16  8:32 ` Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco)
@ 2019-05-16  8:36   ` Richard Purdie
  0 siblings, 0 replies; 7+ messages in thread
From: Richard Purdie @ 2019-05-16  8:36 UTC (permalink / raw)
  To: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco),
	openembedded-core@lists.openembedded.org

On Thu, 2019-05-16 at 08:32 +0000, Oleksiy Obitotskyi -X (oobitots -
GLOBALLOGIC INC at Cisco) via Openembedded-core wrote:
> Any comments?

meta-oe changes need to go to openembedded-devel, not openembedded-
core.

Cheers,

Richard




^ permalink raw reply	[flat|nested] 7+ messages in thread
* [meta-oe][PATCH] protobuf: Fix ptest compilation
@ 2019-05-16  8:57 Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco)
  2019-05-16 11:23 ` Adrian Bunk
  2019-05-18 19:41 ` Khem Raj
  0 siblings, 2 replies; 7+ messages in thread
From: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco) @ 2019-05-16  8:57 UTC (permalink / raw)
  To: openembedded-devel@lists.openembedded.org

Tests require c++11 support, so add -std=c++11
to compiler flags.

Upstream-Status: Pending
Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
---
meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
b/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
index cf72d9ca7..4791e13ca 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
@@ -40,8 +40,8 @@ do_compile_ptest() {
# which haven't been installed yet.
cp "${B}/protobuf.pc" "${B}/${TEST_SRC_DIR}/protobuf.pc"
sed -e 's|libdir=|libdir=${PKG_CONFIG_SYSROOT_DIR}|' -i
"${B}/${TEST_SRC_DIR}/protobuf.pc"
- sed -e 's|Cflags:|Cflags: -I${S}/src|' -i
"${B}/${TEST_SRC_DIR}/protobuf.pc"
- sed -e 's|Libs:|Libs: -L${B}/src/.libs|' -i
"${B}/${TEST_SRC_DIR}/protobuf.pc"
+ sed -e 's|Cflags:|Cflags: -std=c++11 -I${S}/src|' -i
"${B}/${TEST_SRC_DIR}/protobuf.pc"
+ sed -e 's|Libs:|Libs: -std=c++11 -L${B}/src/.libs|' -i
"${B}/${TEST_SRC_DIR}/protobuf.pc"
export PKG_CONFIG_PATH="${B}/${TEST_SRC_DIR}"
# Save the pkgcfg sysroot variable, and update it to nothing so

-- 
2.19.1




^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [meta-oe][PATCH] protobuf: Fix ptest compilation
  2019-05-16  8:57 [meta-oe][PATCH] protobuf: Fix ptest compilation Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco)
@ 2019-05-16 11:23 ` Adrian Bunk
  2019-05-16 11:43   ` Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco)
  2019-05-18 19:41 ` Khem Raj
  1 sibling, 1 reply; 7+ messages in thread
From: Adrian Bunk @ 2019-05-16 11:23 UTC (permalink / raw)
  To: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco)
  Cc: openembedded-devel@lists.openembedded.org

On Thu, May 16, 2019 at 08:57:04AM +0000, Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC at Cisco) via Openembedded-devel wrote:
> Tests require c++11 support, so add -std=c++11
> to compiler flags.
>...

What compiler are you using to compile for your target?

The description sounds as if it would be gcc < 6.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [meta-oe][PATCH] protobuf: Fix ptest compilation
  2019-05-16 11:23 ` Adrian Bunk
@ 2019-05-16 11:43   ` Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco)
  0 siblings, 0 replies; 7+ messages in thread
From: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco) @ 2019-05-16 11:43 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: openembedded-devel@lists.openembedded.org

It was clang 4.0.0

Regards,
Oleksiy

On 16.05.19 14:27, Adrian Bunk wrote:
> On Thu, May 16, 2019 at 08:57:04AM +0000, Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC at Cisco) via Openembedded-devel wrote:
>> Tests require c++11 support, so add -std=c++11
>> to compiler flags.
>> ...
> What compiler are you using to compile for your target?
>
> The description sounds as if it would be gcc < 6.
>
> cu
> Adrian
>



^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [meta-oe][PATCH] protobuf: Fix ptest compilation
  2019-05-16  8:57 [meta-oe][PATCH] protobuf: Fix ptest compilation Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco)
  2019-05-16 11:23 ` Adrian Bunk
@ 2019-05-18 19:41 ` Khem Raj
  1 sibling, 0 replies; 7+ messages in thread
From: Khem Raj @ 2019-05-18 19:41 UTC (permalink / raw)
  To: Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco)
  Cc: openembedded-devel@lists.openembedded.org

On Thu, May 16, 2019 at 2:04 AM Oleksiy Obitotskyi -X (oobitots -
GLOBALLOGIC INC at Cisco) via Openembedded-devel
<openembedded-devel@lists.openembedded.org> wrote:
>
> Tests require c++11 support, so add -std=c++11
> to compiler flags.
>
This does not apply cleanly on top of master, can you rebase and send again ?

> Upstream-Status: Pending
> Signed-off-by: Oleksiy Obitotskyy <oobitots@cisco.com>
> ---
> meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
> b/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
> index cf72d9ca7..4791e13ca 100644
> --- a/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
> +++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.6.1.bb
> @@ -40,8 +40,8 @@ do_compile_ptest() {
> # which haven't been installed yet.
> cp "${B}/protobuf.pc" "${B}/${TEST_SRC_DIR}/protobuf.pc"
> sed -e 's|libdir=|libdir=${PKG_CONFIG_SYSROOT_DIR}|' -i
> "${B}/${TEST_SRC_DIR}/protobuf.pc"
> - sed -e 's|Cflags:|Cflags: -I${S}/src|' -i
> "${B}/${TEST_SRC_DIR}/protobuf.pc"
> - sed -e 's|Libs:|Libs: -L${B}/src/.libs|' -i
> "${B}/${TEST_SRC_DIR}/protobuf.pc"
> + sed -e 's|Cflags:|Cflags: -std=c++11 -I${S}/src|' -i
> "${B}/${TEST_SRC_DIR}/protobuf.pc"
> + sed -e 's|Libs:|Libs: -std=c++11 -L${B}/src/.libs|' -i
> "${B}/${TEST_SRC_DIR}/protobuf.pc"
> export PKG_CONFIG_PATH="${B}/${TEST_SRC_DIR}"
> # Save the pkgcfg sysroot variable, and update it to nothing so
>
> --
> 2.19.1
>
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-05-18 19:42 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-16  8:57 [meta-oe][PATCH] protobuf: Fix ptest compilation Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco)
2019-05-16 11:23 ` Adrian Bunk
2019-05-16 11:43   ` Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco)
2019-05-18 19:41 ` Khem Raj
  -- strict thread matches above, loose matches on Subject: below --
2019-04-16 15:34 Oleksiy Obitotskyy
2019-05-16  8:32 ` Oleksiy Obitotskyi -X (oobitots - GLOBALLOGIC INC@Cisco)
2019-05-16  8:36   ` Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.