[meta-oe][PATCH 1/3] gtkwave: add distro_features_check

[meta-oe][PATCH 1/3] gtkwave: add distro_features_check

[Martin Jansa]

* fixes:
ERROR: Nothing PROVIDES 'gtk+' (but /OE/build/luneos-warrior/webos-ports/meta-openembedded/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb DEPENDS on or otherwise requires it)
gtk+ was skipped: one of 'x11 directfb' needs to be in DISTRO_FEATURES
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'gtkwave', 'gtk+']

and

ERROR: Nothing PROVIDES 'tk' (but /OE/build/luneos-warrior/webos-ports/meta-openembedded/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb DEPENDS on or otherwise requires it)
tk was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'gtkwave', 'tk']

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb b/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
index 60df6f773b..b9aae0f6c8 100644
--- a/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
+++ b/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
@@ -14,6 +14,10 @@ inherit pkgconfig autotools gettext texinfo
 DEPENDS = "tcl tk gperf-native bzip2 xz pango zlib gtk+ gdk-pixbuf glib-2.0"
 RDEPENDS_${PN} = "tk-lib"
 
+# depends on gtk+ which has this restriction
+inherit distro_features_check
+ANY_OF_DISTRO_FEATURES = "${GTK2DISTROFEATURES}"
+
 EXTRA_OECONF = "--with-tcl=${STAGING_BINDIR_CROSS} --with-tk=${STAGING_BINDIR_CROSS}"
 
 FILES_${PN} = "${bindir} ${datadir}"
-- 
2.17.1

[meta-oe][PATCH 2/3] ndctl: make MACHINE_ARCH and ignore from libblockdev

[Martin Jansa]

* fixes:
ERROR: libblockdev different signature for task do_configure.sigdata between hammerhead and mako
Hash for dependent task libblockdev/libblockdev_2.20.bb.do_prepare_recipe_sysroot changed from bee357e6fd2c8479c9dbf9ccef6f30c416df1eb608b53a775383069a4215286b to 23a2ff7864fbd6d38b77918829651cff8d009702894ee670fab145c520d05be8
Unable to find matching sigdata for /OE/build/luneos-master/webos-ports/meta-openembedded/meta-oe/recipes-extended/libblockdev/libblockdev_2.20.bb.do_prepare_recipe_sysroot with hashes bee357e6fd2c8479c9dbf9ccef6f30c416df1eb608b53a775383069a4215286b or 23a2ff7864fbd6d38b77918829651cff8d009702894ee670fab145c520d05be8

ERROR: ndctl different signature for task do_configure.sigdata between hammerhead and mako
Hash for dependent task ndctl/ndctl_v63.bb.do_prepare_recipe_sysroot changed from ea34e9d64a9f30c3ed898bd3850e43e95297dacc560732e1d6bdfa961a6b357b to f886d72844b05c99cd241b8402d760d2c02e0264bfc66503d1e8742815463b3c
Unable to find matching sigdata for /OE/build/luneos-master/webos-ports/meta-openembedded/meta-oe/recipes-core/ndctl/ndctl_v63.bb.do_prepare_recipe_sysroot with hashes ea34e9d64a9f30c3ed898bd3850e43e95297dacc560732e1d6bdfa961a6b357b or f886d72844b05c99cd241b8402d760d2c02e0264bfc66503d1e8742815463b3c

$ bitbake-diffsigs /OE/build/luneos-master/webos-ports/tmp-glibc/sstate-diff/1557963509/[hm]*/*/ndctl/*do_prepare*.sigdata*
runtaskdeps changed:
['autoconf/autoconf_2.69.bb.do_populate_sysroot:virtual:native automake/automake_1.16.1.bb.do_populate_sysroot:virtual:native bash-completion/bash-completion_2.8.bb.do_populate_sysroot gcc/gcc-cross_7.3.bb.do_populate_sysroot gcc/gcc-runtime_7.3.bb.do_populate_sysroot glibc/glibc_2.29.bb.do_populate_sysroot gnu-config/gnu-config_git.bb.do_populate_sysroot:virtual:native json-c/json-c_0.13.1.bb.do_populate_sysroot kmod/kmod_git.bb.do_populate_sysroot libtool/libtool-cross_2.4.6.bb.do_populate_sysroot libtool/libtool-native_2.4.6.bb.do_populate_sysroot', -linux/linux-lg-hammerhead_git.bb.do_populate_sysroot, +linux/linux-lg-mako_git.bb.do_populate_sysroot, 'ndctl/ndctl_v63.bb.do_fetch pkgconfig/pkgconfig_git.bb.do_populate_sysroot:virtual:native systemd/systemd-systemctl-native.bb.do_populate_sysroot systemd/systemd_242.bb.do_populate_sysroot']
linux/linux-lg-hammerhead_git.bb.do_populate_sysroot with hash e58e94601af73831ea51ca6cc18578c26b9b491bcadb82a2c590b22498447438
 changed to
linux/linux-lg-mako_git.bb.do_populate_sysroot with hash 4c7372d0063be9d5c96bfad20a2052ded3a7121a06027c21a75e79a4f6a678e3
Dependency on task linux/linux-lg-mako_git.bb.do_populate_sysroot was added with hash 4c7372d0063be9d5c96bfad20a2052ded3a7121a06027c21a75e79a4f6a678e3
Dependency on task linux/linux-lg-hammerhead_git.bb.do_populate_sysroot was removed with hash e58e94601af73831ea51ca6cc18578c26b9b491bcadb82a2c590b22498447438

$ bitbake-diffsigs /OE/build/luneos-master/webos-ports/tmp-glibc/sstate-diff/1557963509/[hm]*/*/libblockdev/*do_prepare*.sigdata*
Hash for dependent task ndctl/ndctl_v63.bb.do_populate_sysroot changed from 0d123eb0e330a9e34d199eb012da9ae2eb614063f9412725ef39a06b152341f1 to 40077996bc35ac047210928559ad692f4eb20e37b07ef675bf49c9c39c46fe1e
Unable to find matching sigdata for /OE/build/luneos-master/webos-ports/meta-openembedded/meta-oe/recipes-core/ndctl/ndctl_v63.bb.do_populate_sysroot with hashes 0d123eb0e330a9e34d199eb012da9ae2eb614063f9412725ef39a06b152341f1 or 40077996bc35ac047210928559ad692f4eb20e37b07ef675bf49c9c39c46fe1e

as detected with:
openembedded-core/scripts/sstate-diff-machines.sh --targets=world --tmpdir=tmp-glibc/ --analyze --machines="hammerhead mako qemux86"

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta-oe/conf/layer.conf                 | 6 ++++++
 meta-oe/recipes-core/ndctl/ndctl_v63.bb | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/meta-oe/conf/layer.conf b/meta-oe/conf/layer.conf
index 31f2f17fc8..507ac50eca 100644
--- a/meta-oe/conf/layer.conf
+++ b/meta-oe/conf/layer.conf
@@ -51,6 +51,12 @@ SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
   phoronix-test-suite->php \
 "
 
+# Depends on ndctl (through nvdimm PACKAGECONFIG) which depends on MACHINE_ARCH kernel
+# and making libblockdev MACHINE_ARCH is not an option as python3-blivet, udisks2, gvfs
+# would be MACHINE_ARCH as well
+SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
+  libblockdev->ndctl \
+"
 # ttf.inc inherits fontcache which adds fontconfig-utils to RDEPENDS
 SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS += " \
   terminus-font->fontconfig \
diff --git a/meta-oe/recipes-core/ndctl/ndctl_v63.bb b/meta-oe/recipes-core/ndctl/ndctl_v63.bb
index 1f3abf5143..61e53029b3 100644
--- a/meta-oe/recipes-core/ndctl/ndctl_v63.bb
+++ b/meta-oe/recipes-core/ndctl/ndctl_v63.bb
@@ -19,6 +19,9 @@ S = "${WORKDIR}/git"
 
 EXTRA_OECONF += "--enable-test --enable-destructive --disable-docs"
 
+# Depends on MACHINE_ARCH kernel
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
 PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES','systemd','systemd','',d)}"
 PACKAGECONFIG[systemd] = "--with-systemd, --without-systemd, systemd"
 
-- 
2.17.1

[meta-oe][PATCH 3/3] oprofile: make MACHINE_ARCH

[Martin Jansa]

* fixes:
ERROR: oprofile different signature for task do_configure.sigdata between hammerhead and mako
Hash for dependent task oprofile/oprofile_1.3.0.bb.do_prepare_recipe_sysroot changed from deecd34bc94f47935ce3dc7f83f9a8407269959e446518bd9700a2ebae4324bb to d4d6301a72fcd061c167a6715372a6e35f57bf08152a6223b1571957834428f0
Unable to find matching sigdata for /OE/build/luneos-master/webos-ports/meta-openembedded/meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb.do_prepare_recipe_sysroot with hashes deecd34bc94f47935ce3dc7f83f9a8407269959e446518bd9700a2ebae4324bb or d4d6301a72fcd061c167a6715372a6e35f57bf08152a6223b1571957834428f0

$ bitbake-diffsigs /OE/build/luneos-master/webos-ports/tmp-glibc/sstate-diff/1557963509/[hm]*/*/oprofile/*do_prepare*.sigdata*
runtaskdeps changed:
['autoconf/autoconf_2.69.bb.do_populate_sysroot:virtual:native automake/automake_1.16.1.bb.do_populate_sysroot:virtual:native binutils/binutils_2.32.bb.do_populate_sysroot gcc/gcc-cross_7.3.bb.do_populate_sysroot gcc/gcc-runtime_7.3.bb.do_populate_sysroot glibc/glibc_2.29.bb.do_populate_sysroot gnu-config/gnu-config_git.bb.do_populate_sysroot:virtual:native libtool/libtool-cross_2.4.6.bb.do_populate_sysroot libtool/libtool-native_2.4.6.bb.do_populate_sysroot', -linux/linux-lg-hammerhead_git.bb.do_populate_sysroot, +linux/linux-lg-mako_git.bb.do_populate_sysroot, 'oprofile/oprofile_1.3.0.bb.do_fetch pkgconfig/pkgconfig_git.bb.do_populate_sysroot:virtual:native popt/popt_1.16.bb.do_populate_sysroot']
linux/linux-lg-hammerhead_git.bb.do_populate_sysroot with hash e58e94601af73831ea51ca6cc18578c26b9b491bcadb82a2c590b22498447438
 changed to
linux/linux-lg-mako_git.bb.do_populate_sysroot with hash 4c7372d0063be9d5c96bfad20a2052ded3a7121a06027c21a75e79a4f6a678e3
Dependency on task linux/linux-lg-mako_git.bb.do_populate_sysroot was added with hash 4c7372d0063be9d5c96bfad20a2052ded3a7121a06027c21a75e79a4f6a678e3
Dependency on task linux/linux-lg-hammerhead_git.bb.do_populate_sysroot was removed with hash e58e94601af73831ea51ca6cc18578c26b9b491bcadb82a2c590b22498447438

* as detected with:
openembedded-core/scripts/sstate-diff-machines.sh --targets=world --tmpdir=tmp-glibc/ --analyze --machines="hammerhead mako qemux86"

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb b/meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb
index 1dc535ed8d..8d706e4a50 100644
--- a/meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb
+++ b/meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb
@@ -3,6 +3,9 @@ require oprofile.inc
 DEPENDS += "virtual/kernel"
 DEPENDS_append_powerpc64 = " libpfm4"
 
+# Depends on MACHINE_ARCH kernel
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
 SRC_URI[md5sum] = "bd998df5521ebedae31e71cd3fb6200b"
 SRC_URI[sha256sum] = "95ded8bde1ec39922f0af015981a67aec63e025a501e4dc04cd65d38f73647e6"
 
-- 
2.17.1

Re: [meta-oe][PATCH 1/3] gtkwave: add distro_features_check

[Adrian Bunk]

On Thu, May 16, 2019 at 07:06:22AM +0000, Martin Jansa wrote:
> * fixes:
> ERROR: Nothing PROVIDES 'gtk+' (but /OE/build/luneos-warrior/webos-ports/meta-openembedded/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb DEPENDS on or otherwise requires it)
> gtk+ was skipped: one of 'x11 directfb' needs to be in DISTRO_FEATURES
> ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'gtkwave', 'gtk+']
> 
> and
> 
> ERROR: Nothing PROVIDES 'tk' (but /OE/build/luneos-warrior/webos-ports/meta-openembedded/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb DEPENDS on or otherwise requires it)
> tk was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
> ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'gtkwave', 'tk']
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb b/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
> index 60df6f773b..b9aae0f6c8 100644
> --- a/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
> +++ b/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
> @@ -14,6 +14,10 @@ inherit pkgconfig autotools gettext texinfo
>  DEPENDS = "tcl tk gperf-native bzip2 xz pango zlib gtk+ gdk-pixbuf glib-2.0"
>  RDEPENDS_${PN} = "tk-lib"
>  
> +# depends on gtk+ which has this restriction
> +inherit distro_features_check
> +ANY_OF_DISTRO_FEATURES = "${GTK2DISTROFEATURES}"
>...

Shouldn't this be x11 (without the directfb alternative)
due to tk?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [meta-oe][PATCH 1/3] gtkwave: add distro_features_check

[Andreas Müller]

On Thu, May 16, 2019 at 9:25 AM Adrian Bunk <bunk@stusta.de> wrote:
>
> On Thu, May 16, 2019 at 07:06:22AM +0000, Martin Jansa wrote:
> > * fixes:
> > ERROR: Nothing PROVIDES 'gtk+' (but /OE/build/luneos-warrior/webos-ports/meta-openembedded/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb DEPENDS on or otherwise requires it)
> > gtk+ was skipped: one of 'x11 directfb' needs to be in DISTRO_FEATURES
> > ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> > Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'gtkwave', 'gtk+']
> >
> > and
> >
> > ERROR: Nothing PROVIDES 'tk' (but /OE/build/luneos-warrior/webos-ports/meta-openembedded/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb DEPENDS on or otherwise requires it)
> > tk was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
> > ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> > Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'gtkwave', 'tk']
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb b/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
> > index 60df6f773b..b9aae0f6c8 100644
> > --- a/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
> > +++ b/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
> > @@ -14,6 +14,10 @@ inherit pkgconfig autotools gettext texinfo
> >  DEPENDS = "tcl tk gperf-native bzip2 xz pango zlib gtk+ gdk-pixbuf glib-2.0"
> >  RDEPENDS_${PN} = "tk-lib"
> >
> > +# depends on gtk+ which has this restriction
> > +inherit distro_features_check
> > +ANY_OF_DISTRO_FEATURES = "${GTK2DISTROFEATURES}"
> >...
>
> Shouldn't this be x11 (without the directfb alternative)
> due to tk?
>
It is slightly off-top and maybe I missed something but from my
opinion these type of patches are wrong - and we have many of them.
The origin of the issue is gtk+ not gtkwave.

Would it be a big issue if recipes inherit distro-feature-check
settings from the recipes they depend on?

I ask this because this is definitely a maintenance burden and such a
mechanism would make life much easier.

Cheers

Andreas

Re: [meta-oe][PATCH 1/3] gtkwave: add distro_features_check

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2025 bytes --]

On Thu, May 16, 2019 at 10:24:41AM +0300, Adrian Bunk wrote:
> On Thu, May 16, 2019 at 07:06:22AM +0000, Martin Jansa wrote:
> > * fixes:
> > ERROR: Nothing PROVIDES 'gtk+' (but /OE/build/luneos-warrior/webos-ports/meta-openembedded/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb DEPENDS on or otherwise requires it)
> > gtk+ was skipped: one of 'x11 directfb' needs to be in DISTRO_FEATURES
> > ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> > Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'gtkwave', 'gtk+']
> > 
> > and
> > 
> > ERROR: Nothing PROVIDES 'tk' (but /OE/build/luneos-warrior/webos-ports/meta-openembedded/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb DEPENDS on or otherwise requires it)
> > tk was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
> > ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> > Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'gtkwave', 'tk']
> > 
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb b/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
> > index 60df6f773b..b9aae0f6c8 100644
> > --- a/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
> > +++ b/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
> > @@ -14,6 +14,10 @@ inherit pkgconfig autotools gettext texinfo
> >  DEPENDS = "tcl tk gperf-native bzip2 xz pango zlib gtk+ gdk-pixbuf glib-2.0"
> >  RDEPENDS_${PN} = "tk-lib"
> >  
> > +# depends on gtk+ which has this restriction
> > +inherit distro_features_check
> > +ANY_OF_DISTRO_FEATURES = "${GTK2DISTROFEATURES}"
> >...
> 
> Shouldn't this be x11 (without the directfb alternative)
> due to tk?

Makes sense, will send v2, thanks.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

Re: [meta-oe][PATCH 1/3] gtkwave: add distro_features_check

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 4616 bytes --]

On Thu, May 16, 2019 at 10:21:14AM +0200, Andreas Müller wrote:
> On Thu, May 16, 2019 at 9:25 AM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > On Thu, May 16, 2019 at 07:06:22AM +0000, Martin Jansa wrote:
> > > * fixes:
> > > ERROR: Nothing PROVIDES 'gtk+' (but /OE/build/luneos-warrior/webos-ports/meta-openembedded/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb DEPENDS on or otherwise requires it)
> > > gtk+ was skipped: one of 'x11 directfb' needs to be in DISTRO_FEATURES
> > > ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> > > Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'gtkwave', 'gtk+']
> > >
> > > and
> > >
> > > ERROR: Nothing PROVIDES 'tk' (but /OE/build/luneos-warrior/webos-ports/meta-openembedded/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb DEPENDS on or otherwise requires it)
> > > tk was skipped: missing required distro feature 'x11' (not in DISTRO_FEATURES)
> > > ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
> > > Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'gtkwave', 'tk']
> > >
> > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > ---
> > >  meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb b/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
> > > index 60df6f773b..b9aae0f6c8 100644
> > > --- a/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
> > > +++ b/meta-oe/recipes-graphics/gtkwave/gtkwave_3.3.98.bb
> > > @@ -14,6 +14,10 @@ inherit pkgconfig autotools gettext texinfo
> > >  DEPENDS = "tcl tk gperf-native bzip2 xz pango zlib gtk+ gdk-pixbuf glib-2.0"
> > >  RDEPENDS_${PN} = "tk-lib"
> > >
> > > +# depends on gtk+ which has this restriction
> > > +inherit distro_features_check
> > > +ANY_OF_DISTRO_FEATURES = "${GTK2DISTROFEATURES}"
> > >...
> >
> > Shouldn't this be x11 (without the directfb alternative)
> > due to tk?
> >
> It is slightly off-top and maybe I missed something but from my
> opinion these type of patches are wrong - and we have many of them.
> The origin of the issue is gtk+ not gtkwave.

I think this was discussed (long time ago) when adding x11 to required
distro features to all recipes depending on libx11, but I haven't found
that thread with quick search.

You're right that the gtk+ restriction is the root cause of this, but
gtk+ already has the restriction correct defined (hence the "gtk+ was
skipped: one of 'x11 directfb' needs to be in DISTRO_FEATURES" error
message when parsing gtkwave).

The automatic propagation of such restriction to recipes which depend on
it sounds good, but it also makes sense to explicitly acknowledge that
there is such restriction caused by some dependency in the recipe.
That's why I'm at least putting a comment above REQUIRED_DISTRO_FEATURES
saying why I've added it in first place.

In most cases I just want to be able to do:
bitbake world without any errors shown for MACHINEs which I care about
or something like:
openembedded-core/scripts/sstate-diff-machines.sh --targets=world --tmpdir=tmp-glibc/ --analyze --machines="hammerhead mako qemux86"
which works correctly only if it can parse the dependency tree of whole
world.

> Would it be a big issue if recipes inherit distro-feature-check
> settings from the recipes they depend on?
> 
> I ask this because this is definitely a maintenance burden and such a
> mechanism would make life much easier.

Agreed, especially in cases where the problematic dependency is also
optional and the required distro features should be set with respect to
e.g. PACKAGECONFIG as well.

But me being used to a lot of burden I don't see this type of
patches to be so big deal.

Just compare:
https://github.com/openwebos/meta-webos/blob/master/conf/distro/include/webos-recipe-blacklist-world.inc
https://github.com/webosose/meta-webosose/blob/master/meta-webos/conf/distro/include/webos-recipe-blacklist-world.inc
https://github.com/webOS-ports/meta-webos-ports/blob/master/meta-luneos/conf/distro/include/luneos-recipe-blacklist-world.inc

just having the distro-feature-check bbclass and the restriction in the
recipes (instead of PNBLACKLIST for all recipes incompatible with the
DISTRO_FEATURES we have) made my life so much easier (that I never got
around to cleanup some of these 6+ old entries which were already
resolved elsewhere since then).

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]