All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <ohering@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: "Juergen Gross" <jgross@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	"Ian Jackson" <ian.jackson@eu.citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: Regression in xen-unstable due to commit 3802ecbaa9eb36
Date: Thu, 16 May 2019 14:04:51 +0200	[thread overview]
Message-ID: <20190516140451.06cfcbfe.ohering@suse.com> (raw)
In-Reply-To: <20190516115043.GB2798@zion.uk.xensource.com>


[-- Attachment #1.1: Type: text/plain, Size: 798 bytes --]

Am Thu, 16 May 2019 12:50:43 +0100
schrieb Wei Liu <wei.liu2@citrix.com>:

> Adding new APIs and defining LIBXL_HAVE won't get you out of this hole.

From what I see, src/libxl/libxl_conf.c:libxlBuildDomainConfig would need
to call libxl_domain_config_finish(libxl_domain_config*) at the end of
that function, wrapped in a #ifdef.

But your are right, old libvirt and new libxl need a solution without
introducing a new API.

There are quite a few checks for device_model_version, they would be all
wrong if the assert is removed, or changed back to QEMU_XEN. Perhaps we
can continue to live with that error. device_model_version could become
a local variable. If it is not set, assume the caller just wants the
memory size and enforce QEMU_XEN again within that function.

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Olaf Hering <ohering@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: "Juergen Gross" <jgross@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	"Ian Jackson" <ian.jackson@eu.citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] Regression in xen-unstable due to commit 3802ecbaa9eb36
Date: Thu, 16 May 2019 14:04:51 +0200	[thread overview]
Message-ID: <20190516140451.06cfcbfe.ohering@suse.com> (raw)
Message-ID: <20190516120451.PyXFzcKzqmADu17q_l2x3Y68G7hYNsXKWBi_8PGsL2o@z> (raw)
In-Reply-To: <20190516115043.GB2798@zion.uk.xensource.com>


[-- Attachment #1.1: Type: text/plain, Size: 798 bytes --]

Am Thu, 16 May 2019 12:50:43 +0100
schrieb Wei Liu <wei.liu2@citrix.com>:

> Adding new APIs and defining LIBXL_HAVE won't get you out of this hole.

From what I see, src/libxl/libxl_conf.c:libxlBuildDomainConfig would need
to call libxl_domain_config_finish(libxl_domain_config*) at the end of
that function, wrapped in a #ifdef.

But your are right, old libvirt and new libxl need a solution without
introducing a new API.

There are quite a few checks for device_model_version, they would be all
wrong if the assert is removed, or changed back to QEMU_XEN. Perhaps we
can continue to live with that error. device_model_version could become
a local variable. If it is not set, assume the caller just wants the
memory size and enforce QEMU_XEN again within that function.

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-05-16 12:04 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16  8:09 Regression in xen-unstable due to commit 3802ecbaa9eb36 Juergen Gross
2019-05-16  8:09 ` [Xen-devel] " Juergen Gross
2019-05-16  8:27 ` Olaf Hering
2019-05-16  8:27   ` [Xen-devel] " Olaf Hering
2019-05-16  8:29   ` Juergen Gross
2019-05-16  8:29     ` [Xen-devel] " Juergen Gross
2019-05-16  8:30   ` Olaf Hering
2019-05-16  8:30     ` [Xen-devel] " Olaf Hering
2019-05-16  8:34     ` Juergen Gross
2019-05-16  8:34       ` [Xen-devel] " Juergen Gross
2019-05-16  8:40 ` Olaf Hering
2019-05-16  8:40   ` [Xen-devel] " Olaf Hering
2019-05-16  8:50   ` Olaf Hering
2019-05-16  8:50     ` [Xen-devel] " Olaf Hering
2019-05-16  8:54   ` Juergen Gross
2019-05-16  8:54     ` [Xen-devel] " Juergen Gross
2019-05-16  9:07 ` Olaf Hering
2019-05-16  9:07   ` [Xen-devel] " Olaf Hering
2019-05-16 10:45   ` Roger Pau Monné
2019-05-16 10:45     ` [Xen-devel] " Roger Pau Monné
2019-05-16 10:57     ` Olaf Hering
2019-05-16 10:57       ` [Xen-devel] " Olaf Hering
2019-05-16 11:24       ` Wei Liu
2019-05-16 11:24         ` [Xen-devel] " Wei Liu
2019-05-16 11:38         ` Olaf Hering
2019-05-16 11:38           ` [Xen-devel] " Olaf Hering
2019-05-16 11:50           ` Wei Liu
2019-05-16 11:50             ` [Xen-devel] " Wei Liu
2019-05-16 12:04             ` Olaf Hering [this message]
2019-05-16 12:04               ` Olaf Hering
2019-05-16 12:18               ` Olaf Hering
2019-05-16 12:18                 ` [Xen-devel] " Olaf Hering
2019-05-16 12:50                 ` Wei Liu
2019-05-16 12:50                   ` [Xen-devel] " Wei Liu
2019-05-16 11:52           ` Olaf Hering
2019-05-16 11:52             ` [Xen-devel] " Olaf Hering
2019-05-16 11:42         ` Roger Pau Monné
2019-05-16 11:42           ` [Xen-devel] " Roger Pau Monné
2019-05-16 12:42           ` Wei Liu
2019-05-16 12:42             ` [Xen-devel] " Wei Liu
2019-05-16 11:24     ` Wei Liu
2019-05-16 11:24       ` [Xen-devel] " Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190516140451.06cfcbfe.ohering@suse.com \
    --to=ohering@suse.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jgross@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.