From: Andre Przywara <andre.przywara@arm.com>
To: Amit Tomer <amittomer25@gmail.com>
Cc: Oleksandr <olekstysh@gmail.com>,
xen-devel@lists.xenproject.org,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] xen/arm: Black list everything with a PPI
Date: Thu, 16 May 2019 14:17:36 +0100 [thread overview]
Message-ID: <20190516141736.486f8a06@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <CABHD4K_DybrEQBeG2pn9D68pFoPH9e0ior17uy3A-_mXeSA+cQ@mail.gmail.com>
On Thu, 16 May 2019 17:15:36 +0530
Amit Tomer <amittomer25@gmail.com> wrote:
Hi,
> Thanks for having a look at it.
>
> On Thu, May 16, 2019 at 12:25 AM Oleksandr <olekstysh@gmail.com> wrote:
> >
> >
> > On 03.05.19 20:02, Amit Singh Tomar wrote:
> >
> > Hi, Amit
> >
> > > XEN should not forward PPIs to Dom0 as it only support SPIs.
> > > One of solution to this problem is to skip any device that
> > > uses PPI source completely while building domain itself.
> > >
> > > This patch goes through all the interrupt sources of device and skip it
> > > if one of interrupt source is PPI. It fixes XEN boot on i.MX8MQ by
> > > skipping PMU node.
> > >
> > > Suggested-by: Julien Grall <julien.grall@arm.com>
> > > Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
> > > ---
> > > * This replaces following patch.
> > > https://patchwork.kernel.org/patch/10899881/
> > > ---
> > > xen/arch/arm/domain_build.c | 16 +++++++++++++++-
> > > 1 file changed, 15 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > > index d983677..8f54472 100644
> > > --- a/xen/arch/arm/domain_build.c
> > > +++ b/xen/arch/arm/domain_build.c
> > > @@ -1353,7 +1353,7 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo,
> > > { /* sentinel */ },
> > > };
> > > struct dt_device_node *child;
> > > - int res;
> > > + int res, i, nirq, irq_id;
> > > const char *name;
> > > const char *path;
> > >
> > > @@ -1399,6 +1399,20 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo,
> > > return 0;
> > > }
> > >
> > > + /* Skip the node, using PPI source */
> > > + nirq = dt_number_of_irq(node);
> > > +
> > > + for ( i = 0 ; i < nirq ; i++ )
> > > + {
> > > + irq_id = platform_get_irq(node, i);
> >
> > Do we need to do something here if platform_get_irq() returns -1?
>
> Yeah, I should have done it. some think like following:
> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/domain_build.c;h=d9836779d17c90e84b94ba32e4a20f028189fc5b;hb=HEAD#l1284
Why would that (or any actual check against -1) be necessary?
If irq_id is < 0, then it would surely not match the condition below and
*nothing* would happen. So I'd say: Keep it like it is, no action necessary.
> > > +
> > > + if ( irq_id >= 16 && irq_id < 32 )
Any chance you can put names there? Or at least add a comment that PPIs range from 16 to 31?
> > > + {
> > > + dt_dprintk(" Skip node with (PPI source)\n");
> > > + return 0;
> > > + }
> > > + }
> > > +
> > > /*
> > > * Xen is using some path for its own purpose. Warn if a node
> > > * already exists with the same path.
> >
> > Patch looks good. Although R-Car H3 seems to not use PPIs for PMU, I
> > have tested your patch just to be sure it wouldn't skip anything by a
> > mistake)
>
> Ok, Thanks for testing it. I would resend it with error condition check.
Please don't ;-)
Cheers,
Andre
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com>
To: Amit Tomer <amittomer25@gmail.com>
Cc: Oleksandr <olekstysh@gmail.com>,
xen-devel@lists.xenproject.org,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen/arm: Black list everything with a PPI
Date: Thu, 16 May 2019 14:17:36 +0100 [thread overview]
Message-ID: <20190516141736.486f8a06@donnerap.cambridge.arm.com> (raw)
Message-ID: <20190516131736.cClLJuvfTjGQlkseqzZ-6_wHVl323hzdsGMwWLCAML0@z> (raw)
In-Reply-To: <CABHD4K_DybrEQBeG2pn9D68pFoPH9e0ior17uy3A-_mXeSA+cQ@mail.gmail.com>
On Thu, 16 May 2019 17:15:36 +0530
Amit Tomer <amittomer25@gmail.com> wrote:
Hi,
> Thanks for having a look at it.
>
> On Thu, May 16, 2019 at 12:25 AM Oleksandr <olekstysh@gmail.com> wrote:
> >
> >
> > On 03.05.19 20:02, Amit Singh Tomar wrote:
> >
> > Hi, Amit
> >
> > > XEN should not forward PPIs to Dom0 as it only support SPIs.
> > > One of solution to this problem is to skip any device that
> > > uses PPI source completely while building domain itself.
> > >
> > > This patch goes through all the interrupt sources of device and skip it
> > > if one of interrupt source is PPI. It fixes XEN boot on i.MX8MQ by
> > > skipping PMU node.
> > >
> > > Suggested-by: Julien Grall <julien.grall@arm.com>
> > > Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
> > > ---
> > > * This replaces following patch.
> > > https://patchwork.kernel.org/patch/10899881/
> > > ---
> > > xen/arch/arm/domain_build.c | 16 +++++++++++++++-
> > > 1 file changed, 15 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > > index d983677..8f54472 100644
> > > --- a/xen/arch/arm/domain_build.c
> > > +++ b/xen/arch/arm/domain_build.c
> > > @@ -1353,7 +1353,7 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo,
> > > { /* sentinel */ },
> > > };
> > > struct dt_device_node *child;
> > > - int res;
> > > + int res, i, nirq, irq_id;
> > > const char *name;
> > > const char *path;
> > >
> > > @@ -1399,6 +1399,20 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo,
> > > return 0;
> > > }
> > >
> > > + /* Skip the node, using PPI source */
> > > + nirq = dt_number_of_irq(node);
> > > +
> > > + for ( i = 0 ; i < nirq ; i++ )
> > > + {
> > > + irq_id = platform_get_irq(node, i);
> >
> > Do we need to do something here if platform_get_irq() returns -1?
>
> Yeah, I should have done it. some think like following:
> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/domain_build.c;h=d9836779d17c90e84b94ba32e4a20f028189fc5b;hb=HEAD#l1284
Why would that (or any actual check against -1) be necessary?
If irq_id is < 0, then it would surely not match the condition below and
*nothing* would happen. So I'd say: Keep it like it is, no action necessary.
> > > +
> > > + if ( irq_id >= 16 && irq_id < 32 )
Any chance you can put names there? Or at least add a comment that PPIs range from 16 to 31?
> > > + {
> > > + dt_dprintk(" Skip node with (PPI source)\n");
> > > + return 0;
> > > + }
> > > + }
> > > +
> > > /*
> > > * Xen is using some path for its own purpose. Warn if a node
> > > * already exists with the same path.
> >
> > Patch looks good. Although R-Car H3 seems to not use PPIs for PMU, I
> > have tested your patch just to be sure it wouldn't skip anything by a
> > mistake)
>
> Ok, Thanks for testing it. I would resend it with error condition check.
Please don't ;-)
Cheers,
Andre
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-16 13:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 17:02 [PATCH] xen/arm: Black list everything with a PPI Amit Singh Tomar
2019-05-03 17:02 ` [Xen-devel] " Amit Singh Tomar
2019-05-15 18:54 ` Oleksandr
2019-05-15 18:54 ` [Xen-devel] " Oleksandr
2019-05-16 11:45 ` Amit Tomer
2019-05-16 11:45 ` [Xen-devel] " Amit Tomer
2019-05-16 13:17 ` Andre Przywara [this message]
2019-05-16 13:17 ` Andre Przywara
2019-05-16 13:59 ` Julien Grall
2019-05-16 13:59 ` [Xen-devel] " Julien Grall
2019-05-29 17:47 ` Julien Grall
2019-05-29 17:47 ` [Xen-devel] " Julien Grall
2019-05-29 18:56 ` Amit Tomer
2019-05-29 18:56 ` [Xen-devel] " Amit Tomer
-- strict thread matches above, loose matches on Subject: below --
2019-05-03 16:42 Amit Singh Tomar
2019-05-03 16:48 ` Amit Tomer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190516141736.486f8a06@donnerap.cambridge.arm.com \
--to=andre.przywara@arm.com \
--cc=amittomer25@gmail.com \
--cc=julien.grall@arm.com \
--cc=olekstysh@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.