Re: gcc9.1 and f2fs

[Michael Chang <mchang@suse.com>]

Hello John,

Except for lacking commit message and SOB, the fix is LGTM. 

You could add my Reviewed-by: Michael Chang <mchang@suse.com> if you
resend the patch to mailing list with those missing message fixed.

Thanks,
Michael

On Mon, May 06, 2019 at 07:59:42PM +0200, John Paul Adrian Glaubitz wrote:
> On 5/6/19 7:15 PM, Neil MacLeod wrote:
> > Does anyone have a patch?
> 
> Try the attached patch.
> 
> Adrian
> 
> -- 
>  .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer - glaubitz@debian.org
> `. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
>   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

> >From b0d03dd5605220d0d23d72e662f10ce7b02a54a6 Mon Sep 17 00:00:00 2001
> From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Date: Mon, 6 May 2019 19:55:01 +0200
> Subject: [PATCH] f2fs: Disable gcc9 -Waddress-of-packed-member
> 
> ---
>  grub-core/fs/f2fs.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/grub-core/fs/f2fs.c b/grub-core/fs/f2fs.c
> index 1cad2615f..0dd09bc23 100644
> --- a/grub-core/fs/f2fs.c
> +++ b/grub-core/fs/f2fs.c
> @@ -1235,6 +1235,12 @@ grub_f2fs_utf16_to_utf8 (grub_uint16_t *in_buf_le)
>    return out_buf;
>  }
>  
> + 
> +#if __GNUC__ >= 9
> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Waddress-of-packed-member"
> +#endif
> +
>  static grub_err_t
>  grub_f2fs_label (grub_device_t device, char **label)
>  {
> @@ -1255,6 +1261,10 @@ grub_f2fs_label (grub_device_t device, char **label)
>    return grub_errno;
>  }
>  
> +#if __GNUC__ >= 9
> +#pragma GCC diagnostic pop
> +#endif
> +
>  static grub_err_t
>  grub_f2fs_uuid (grub_device_t device, char **uuid)
>  {
> -- 
> 2.20.1
> 

> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel