* [Qemu-devel] [PATCH] migration: Fix typo in migrate_add_blocker() error message
@ 2019-05-16 10:58 ` Greg Kurz
0 siblings, 0 replies; 8+ messages in thread
From: Greg Kurz @ 2019-05-16 10:58 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Dr. David Alan Gilbert, Juan Quintela
Signed-off-by: Greg Kurz <groug@kaod.org>
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 609e0df5d0c0..c15e75e0eebe 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1714,7 +1714,7 @@ int migrate_add_blocker(Error *reason, Error **errp)
if (only_migratable) {
error_propagate_prepend(errp, error_copy(reason),
"disallowing migration blocker "
- "(--only_migratable) for: ");
+ "(--only-migratable) for: ");
return -EACCES;
}
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] migration: Fix typo in migrate_add_blocker() error message
2019-05-16 10:58 ` [Qemu-devel] " Greg Kurz
@ 2019-05-17 8:53 ` Stefano Garzarella
-1 siblings, 0 replies; 8+ messages in thread
From: Stefano Garzarella @ 2019-05-17 8:53 UTC (permalink / raw)
To: Greg Kurz; +Cc: qemu-devel, qemu-trivial, Dr. David Alan Gilbert, Juan Quintela
On Thu, May 16, 2019 at 12:58:05PM +0200, Greg Kurz wrote:
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 609e0df5d0c0..c15e75e0eebe 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1714,7 +1714,7 @@ int migrate_add_blocker(Error *reason, Error **errp)
> if (only_migratable) {
> error_propagate_prepend(errp, error_copy(reason),
> "disallowing migration blocker "
> - "(--only_migratable) for: ");
> + "(--only-migratable) for: ");
> return -EACCES;
> }
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] migration: Fix typo in migrate_add_blocker() error message
@ 2019-05-17 8:53 ` Stefano Garzarella
0 siblings, 0 replies; 8+ messages in thread
From: Stefano Garzarella @ 2019-05-17 8:53 UTC (permalink / raw)
To: Greg Kurz; +Cc: qemu-trivial, Juan Quintela, qemu-devel, Dr. David Alan Gilbert
On Thu, May 16, 2019 at 12:58:05PM +0200, Greg Kurz wrote:
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 609e0df5d0c0..c15e75e0eebe 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1714,7 +1714,7 @@ int migrate_add_blocker(Error *reason, Error **errp)
> if (only_migratable) {
> error_propagate_prepend(errp, error_copy(reason),
> "disallowing migration blocker "
> - "(--only_migratable) for: ");
> + "(--only-migratable) for: ");
> return -EACCES;
> }
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] migration: Fix typo in migrate_add_blocker() error message
2019-05-16 10:58 ` [Qemu-devel] " Greg Kurz
@ 2019-05-17 14:52 ` Dr. David Alan Gilbert
-1 siblings, 0 replies; 8+ messages in thread
From: Dr. David Alan Gilbert @ 2019-05-17 14:52 UTC (permalink / raw)
To: Greg Kurz; +Cc: qemu-devel, qemu-trivial, Juan Quintela
* Greg Kurz (groug@kaod.org) wrote:
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 609e0df5d0c0..c15e75e0eebe 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1714,7 +1714,7 @@ int migrate_add_blocker(Error *reason, Error **errp)
> if (only_migratable) {
> error_propagate_prepend(errp, error_copy(reason),
> "disallowing migration blocker "
> - "(--only_migratable) for: ");
> + "(--only-migratable) for: ");
Thanks.
Trivial: Please take this.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> return -EACCES;
> }
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] migration: Fix typo in migrate_add_blocker() error message
@ 2019-05-17 14:52 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 8+ messages in thread
From: Dr. David Alan Gilbert @ 2019-05-17 14:52 UTC (permalink / raw)
To: Greg Kurz; +Cc: qemu-trivial, qemu-devel, Juan Quintela
* Greg Kurz (groug@kaod.org) wrote:
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 609e0df5d0c0..c15e75e0eebe 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1714,7 +1714,7 @@ int migrate_add_blocker(Error *reason, Error **errp)
> if (only_migratable) {
> error_propagate_prepend(errp, error_copy(reason),
> "disallowing migration blocker "
> - "(--only_migratable) for: ");
> + "(--only-migratable) for: ");
Thanks.
Trivial: Please take this.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> return -EACCES;
> }
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] migration: Fix typo in migrate_add_blocker() error message
2019-05-16 10:58 ` [Qemu-devel] " Greg Kurz
@ 2019-05-22 15:17 ` Laurent Vivier
-1 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2019-05-22 15:17 UTC (permalink / raw)
To: Greg Kurz, qemu-devel; +Cc: qemu-trivial, Dr. David Alan Gilbert, Juan Quintela
On 16/05/2019 12:58, Greg Kurz wrote:
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 609e0df5d0c0..c15e75e0eebe 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1714,7 +1714,7 @@ int migrate_add_blocker(Error *reason, Error **errp)
> if (only_migratable) {
> error_propagate_prepend(errp, error_copy(reason),
> "disallowing migration blocker "
> - "(--only_migratable) for: ");
> + "(--only-migratable) for: ");
> return -EACCES;
> }
>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix typo in migrate_add_blocker() error message
@ 2019-05-22 15:17 ` Laurent Vivier
0 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2019-05-22 15:17 UTC (permalink / raw)
To: Greg Kurz, qemu-devel; +Cc: qemu-trivial, Dr. David Alan Gilbert, Juan Quintela
On 16/05/2019 12:58, Greg Kurz wrote:
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 609e0df5d0c0..c15e75e0eebe 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1714,7 +1714,7 @@ int migrate_add_blocker(Error *reason, Error **errp)
> if (only_migratable) {
> error_propagate_prepend(errp, error_copy(reason),
> "disallowing migration blocker "
> - "(--only_migratable) for: ");
> + "(--only-migratable) for: ");
> return -EACCES;
> }
>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 8+ messages in thread