From: Pavel Machek <pavel@ucw.cz>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: sboyd@kernel.org, mturquette@baylibre.com,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-clk@vger.kernel.org, Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH v2] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver
Date: Sun, 19 May 2019 23:25:28 +0200 [thread overview]
Message-ID: <20190519212527.GD31403@amd> (raw)
In-Reply-To: <20190513213001.23956-1-paul.walmsley@sifive.com>
[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]
On Mon 2019-05-13 14:30:04, Paul Walmsley wrote:
> Restrict Kconfig scope for SiFive clock and reset IP block drivers
> such that they won't appear on most configurations that are unlikely
> to support them. This is based on a suggestion from Pavel Machek
> <pavel@ucw.cz>. Ideally this should be dependent on
> CONFIG_ARCH_SIFIVE, but since that Kconfig directive does not yet
> exist, add dependencies on RISCV or COMPILE_TEST for now.
>
> Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
Thanks for doing this.
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
> ---
> This second version incorporates non-functional changes requested
> by Stephen Boyd <sboyd@kernel.org>.
>
> drivers/clk/sifive/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sifive/Kconfig b/drivers/clk/sifive/Kconfig
> index 8db4a3eb4782..f3b4eb9cb0f5 100644
> --- a/drivers/clk/sifive/Kconfig
> +++ b/drivers/clk/sifive/Kconfig
> @@ -2,6 +2,7 @@
>
> menuconfig CLK_SIFIVE
> bool "SiFive SoC driver support"
> + depends on RISCV || COMPILE_TEST
> help
> SoC drivers for SiFive Linux-capable SoCs.
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Paul Walmsley <paul@pwsan.com>,
sboyd@kernel.org, mturquette@baylibre.com,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v2] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver
Date: Sun, 19 May 2019 23:25:28 +0200 [thread overview]
Message-ID: <20190519212527.GD31403@amd> (raw)
In-Reply-To: <20190513213001.23956-1-paul.walmsley@sifive.com>
[-- Attachment #1.1: Type: text/plain, Size: 1492 bytes --]
On Mon 2019-05-13 14:30:04, Paul Walmsley wrote:
> Restrict Kconfig scope for SiFive clock and reset IP block drivers
> such that they won't appear on most configurations that are unlikely
> to support them. This is based on a suggestion from Pavel Machek
> <pavel@ucw.cz>. Ideally this should be dependent on
> CONFIG_ARCH_SIFIVE, but since that Kconfig directive does not yet
> exist, add dependencies on RISCV or COMPILE_TEST for now.
>
> Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
Thanks for doing this.
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
> ---
> This second version incorporates non-functional changes requested
> by Stephen Boyd <sboyd@kernel.org>.
>
> drivers/clk/sifive/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sifive/Kconfig b/drivers/clk/sifive/Kconfig
> index 8db4a3eb4782..f3b4eb9cb0f5 100644
> --- a/drivers/clk/sifive/Kconfig
> +++ b/drivers/clk/sifive/Kconfig
> @@ -2,6 +2,7 @@
>
> menuconfig CLK_SIFIVE
> bool "SiFive SoC driver support"
> + depends on RISCV || COMPILE_TEST
> help
> SoC drivers for SiFive Linux-capable SoCs.
>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-05-19 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 21:30 [PATCH v2] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver Paul Walmsley
2019-05-13 21:30 ` Paul Walmsley
2019-05-19 21:25 ` Pavel Machek [this message]
2019-05-19 21:25 ` Pavel Machek
2019-05-21 18:34 ` Stephen Boyd
2019-05-21 18:34 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190519212527.GD31403@amd \
--to=pavel@ucw.cz \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=paul.walmsley@sifive.com \
--cc=paul@pwsan.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.