* [PATCH net-next] macvlan: Mark expected switch fall-through
@ 2019-05-20 14:44 Gustavo A. R. Silva
2019-05-20 18:38 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-05-20 14:44 UTC (permalink / raw)
To: David S. Miller, Hangbin Liu; +Cc: netdev, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/net/macvlan.c: In function ‘macvlan_do_ioctl’:
drivers/net/macvlan.c:839:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (!net_eq(dev_net(dev), &init_net))
^
drivers/net/macvlan.c:841:2: note: here
case SIOCGHWTSTAMP:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/macvlan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 92efa93649f0..61550122b563 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -838,6 +838,7 @@ static int macvlan_do_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
case SIOCSHWTSTAMP:
if (!net_eq(dev_net(dev), &init_net))
break;
+ /* fall through */
case SIOCGHWTSTAMP:
if (netif_device_present(real_dev) && ops->ndo_do_ioctl)
err = ops->ndo_do_ioctl(real_dev, &ifrr, cmd);
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] macvlan: Mark expected switch fall-through
2019-05-20 14:44 [PATCH net-next] macvlan: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-05-20 18:38 ` David Miller
2019-05-20 18:48 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2019-05-20 18:38 UTC (permalink / raw)
To: gustavo; +Cc: liuhangbin, netdev, linux-kernel
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Mon, 20 May 2019 09:44:49 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/net/macvlan.c: In function ‘macvlan_do_ioctl’:
> drivers/net/macvlan.c:839:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (!net_eq(dev_net(dev), &init_net))
> ^
> drivers/net/macvlan.c:841:2: note: here
> case SIOCGHWTSTAMP:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
I'll apply this to 'net' since it was introduced actually by arecent
change.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] macvlan: Mark expected switch fall-through
2019-05-20 18:38 ` David Miller
@ 2019-05-20 18:48 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-05-20 18:48 UTC (permalink / raw)
To: David Miller; +Cc: liuhangbin, netdev, linux-kernel
On 5/20/19 1:38 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Mon, 20 May 2019 09:44:49 -0500
>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/net/macvlan.c: In function ‘macvlan_do_ioctl’:
>> drivers/net/macvlan.c:839:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (!net_eq(dev_net(dev), &init_net))
>> ^
>> drivers/net/macvlan.c:841:2: note: here
>> case SIOCGHWTSTAMP:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> I'll apply this to 'net' since it was introduced actually by arecent
> change.
>
OK, great. :)
Thank you.
--
Gsutavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-20 18:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-20 14:44 [PATCH net-next] macvlan: Mark expected switch fall-through Gustavo A. R. Silva
2019-05-20 18:38 ` David Miller
2019-05-20 18:48 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.