From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Kamal Dasu <kdasu.kdev@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/2] dt-bindings: mtd: brcmnand: Make nand-ecc-strength and nand-ecc-step-size optional
Date: Mon, 20 May 2019 14:45:42 +0200 [thread overview]
Message-ID: <20190520144542.05d10e4b@xps13> (raw)
In-Reply-To: <1558117914-35807-1-git-send-email-kdasu.kdev@gmail.com>
Hi Kamal,
Kamal Dasu <kdasu.kdev@gmail.com> wrote on Fri, 17 May 2019 14:29:54
-0400:
> nand-ecc-strength and nand-ecc-step-size can be made optional as
> brcmanand driver can support using the nand_base driver detected
^ typo raw NAND layer
> values.
>
> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
> ---
With this addressed:
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> index bcda1df..29feaba 100644
> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> @@ -101,10 +101,10 @@ Required properties:
> number (e.g., 0, 1, 2, etc.)
> - #address-cells : see partition.txt
> - #size-cells : see partition.txt
> -- nand-ecc-strength : see nand.txt
> -- nand-ecc-step-size : must be 512 or 1024. See nand.txt
>
> Optional properties:
> +- nand-ecc-strength : see nand.txt
> +- nand-ecc-step-size : must be 512 or 1024. See nand.txt
> - nand-on-flash-bbt : boolean, to enable the on-flash BBT for this
> chip-select. See nand.txt
> - brcm,nand-oob-sector-size : integer, to denote the spare area sector size
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Kamal Dasu <kdasu.kdev@gmail.com>
Cc: linux-mtd@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mtd: brcmnand: Make nand-ecc-strength and nand-ecc-step-size optional
Date: Mon, 20 May 2019 14:45:42 +0200 [thread overview]
Message-ID: <20190520144542.05d10e4b@xps13> (raw)
In-Reply-To: <1558117914-35807-1-git-send-email-kdasu.kdev@gmail.com>
Hi Kamal,
Kamal Dasu <kdasu.kdev@gmail.com> wrote on Fri, 17 May 2019 14:29:54
-0400:
> nand-ecc-strength and nand-ecc-step-size can be made optional as
> brcmanand driver can support using the nand_base driver detected
^ typo raw NAND layer
> values.
>
> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
> ---
With this addressed:
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> index bcda1df..29feaba 100644
> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> @@ -101,10 +101,10 @@ Required properties:
> number (e.g., 0, 1, 2, etc.)
> - #address-cells : see partition.txt
> - #size-cells : see partition.txt
> -- nand-ecc-strength : see nand.txt
> -- nand-ecc-step-size : must be 512 or 1024. See nand.txt
>
> Optional properties:
> +- nand-ecc-strength : see nand.txt
> +- nand-ecc-step-size : must be 512 or 1024. See nand.txt
> - nand-on-flash-bbt : boolean, to enable the on-flash BBT for this
> chip-select. See nand.txt
> - brcm,nand-oob-sector-size : integer, to denote the spare area sector size
Thanks,
Miquèl
next prev parent reply other threads:[~2019-05-20 12:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 18:29 [PATCH 1/2] dt-bindings: mtd: brcmnand: Make nand-ecc-strength and nand-ecc-step-size optional Kamal Dasu
2019-05-17 18:29 ` Kamal Dasu
2019-05-17 18:29 ` [PATCH 2/2] mtd: nand: raw: brcmnand: fallback to detected ecc-strength, ecc-step-size Kamal Dasu
2019-05-17 18:29 ` Kamal Dasu
2019-05-20 12:44 ` Miquel Raynal
2019-05-20 12:44 ` Miquel Raynal
2019-05-20 17:31 ` Kamal Dasu
2019-05-20 17:31 ` Kamal Dasu
2019-05-20 17:34 ` Miquel Raynal
2019-05-20 17:34 ` Miquel Raynal
2019-05-20 17:51 ` Kamal Dasu
2019-05-20 17:51 ` Kamal Dasu
2019-05-20 12:45 ` Miquel Raynal [this message]
2019-05-20 12:45 ` [PATCH 1/2] dt-bindings: mtd: brcmnand: Make nand-ecc-strength and nand-ecc-step-size optional Miquel Raynal
2019-06-13 22:51 ` Rob Herring
2019-06-13 22:51 ` Rob Herring
2019-06-13 22:51 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520144542.05d10e4b@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=kdasu.kdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.