All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree@vger.kernel.org, f.fainelli@gmail.com,
	Kevin Hilman <khilman@baylibre.com>,
	linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
	hkallweit1@gmail.com, Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v2 3/5] arm64: dts: meson: g12a: add mdio multiplexer
Date: Mon, 20 May 2019 21:05:33 +0200	[thread overview]
Message-ID: <20190520190533.GF22024@lunn.ch> (raw)
In-Reply-To: <CAFBinCA_XE86eqCMpEFc3xMZDH8J7wVQPRj7bFZyqDxQx-w-qw@mail.gmail.com>

> > +                               int_mdio: mdio@1 {
> > +                                       reg = <1>;
> > +                                       #address-cells = <1>;
> > +                                       #size-cells = <0>;
> > +
> > +                                       internal_ephy: ethernet_phy@8 {
> > +                                               compatible = "ethernet-phy-id0180.3301",
> > +                                                            "ethernet-phy-ieee802.3-c22";
> Based on your comment on v1 of this patch [0] the Ethernet PHY ID is
> defined by this "mdio-multiplexer" (write arbitrary value to a
> register then that's the PHY ID which will show up on the bus)
> I'm fine with explicitly listing the ID which the PHY driver binds to
> because I don't know a better way.

Does reading the ID registers give the correct ID, once you have poked
registers in the mdio-multiplexer? If so, you don't need this
compatible string.

If the read is giving the wrong ID, then yes, you do want this. But
then please add a comment in the DT blob. This is very unusual, so
should have some explanation why it is needed.

Thanks
	Andrew

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-kernel@vger.kernel.org, f.fainelli@gmail.com,
	hkallweit1@gmail.com
Subject: Re: [PATCH v2 3/5] arm64: dts: meson: g12a: add mdio multiplexer
Date: Mon, 20 May 2019 21:05:33 +0200	[thread overview]
Message-ID: <20190520190533.GF22024@lunn.ch> (raw)
In-Reply-To: <CAFBinCA_XE86eqCMpEFc3xMZDH8J7wVQPRj7bFZyqDxQx-w-qw@mail.gmail.com>

> > +                               int_mdio: mdio@1 {
> > +                                       reg = <1>;
> > +                                       #address-cells = <1>;
> > +                                       #size-cells = <0>;
> > +
> > +                                       internal_ephy: ethernet_phy@8 {
> > +                                               compatible = "ethernet-phy-id0180.3301",
> > +                                                            "ethernet-phy-ieee802.3-c22";
> Based on your comment on v1 of this patch [0] the Ethernet PHY ID is
> defined by this "mdio-multiplexer" (write arbitrary value to a
> register then that's the PHY ID which will show up on the bus)
> I'm fine with explicitly listing the ID which the PHY driver binds to
> because I don't know a better way.

Does reading the ID registers give the correct ID, once you have poked
registers in the mdio-multiplexer? If so, you don't need this
compatible string.

If the read is giving the wrong ID, then yes, you do want this. But
then please add a comment in the DT blob. This is very unusual, so
should have some explanation why it is needed.

Thanks
	Andrew

  reply	other threads:[~2019-05-20 19:05 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 13:13 [PATCH v2 0/5] arm64: dts: meson: g12a: add ethernet support Jerome Brunet
2019-05-20 13:13 ` Jerome Brunet
2019-05-20 13:13 ` [PATCH v2 1/5] arm64: dts: meson: g12a: add ethernet mac controller Jerome Brunet
2019-05-20 13:13   ` Jerome Brunet
2019-05-20 17:29   ` Martin Blumenstingl
2019-05-20 17:29     ` Martin Blumenstingl
2019-05-20 13:13 ` [PATCH v2 2/5] arm64: dts: meson: g12a: add ethernet pinctrl definitions Jerome Brunet
2019-05-20 13:13   ` Jerome Brunet
2019-05-20 17:29   ` Martin Blumenstingl
2019-05-20 17:29     ` Martin Blumenstingl
2019-05-20 13:13 ` [PATCH v2 3/5] arm64: dts: meson: g12a: add mdio multiplexer Jerome Brunet
2019-05-20 13:13   ` Jerome Brunet
2019-05-20 17:37   ` Martin Blumenstingl
2019-05-20 17:37     ` Martin Blumenstingl
2019-05-20 19:05     ` Andrew Lunn [this message]
2019-05-20 19:05       ` Andrew Lunn
2019-05-20 21:51       ` Jerome Brunet
2019-05-20 21:51         ` Jerome Brunet
2019-05-23 17:18         ` Kevin Hilman
2019-05-23 17:18           ` Kevin Hilman
2019-05-20 13:14 ` [PATCH v2 4/5] arm64: dts: meson: u200: add internal network Jerome Brunet
2019-05-20 13:14   ` Jerome Brunet
2019-05-20 17:38   ` Martin Blumenstingl
2019-05-20 17:38     ` Martin Blumenstingl
2019-05-20 13:14 ` [PATCH v2 5/5] arm64: dts: meson: sei510: add network support Jerome Brunet
2019-05-20 13:14   ` Jerome Brunet
2019-05-20 17:38   ` Martin Blumenstingl
2019-05-20 17:38     ` Martin Blumenstingl
2019-05-20 17:49 ` [PATCH v2 0/5] arm64: dts: meson: g12a: add ethernet support Kevin Hilman
2019-05-20 17:49   ` Kevin Hilman
2019-05-20 17:49   ` Kevin Hilman
2019-05-20 18:50   ` Kevin Hilman
2019-05-20 18:50     ` Kevin Hilman
2019-05-20 18:50     ` Kevin Hilman
2019-05-23 17:20 ` Kevin Hilman
2019-05-23 17:20   ` Kevin Hilman
2019-05-23 17:20   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520190533.GF22024@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.