From: Brian Norris <briannorris@chromium.org>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: Douglas Anderson <dianders@chromium.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Kalle Valo <kvalo@codeaurora.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
Double Lo <double.lo@cypress.com>,
Madhan Mohan R <madhanmohan.r@cypress.com>,
"mka@chromium.org" <mka@chromium.org>,
Wright Feng <wright.feng@cypress.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
"brcm80211-dev-list@cypress.com" <brcm80211-dev-list@cypress.com>,
YueHaibing <yuehaibing@huawei.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Martin Hicks <mort@bork.org>
Subject: Re: [PATCH 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from sleep
Date: Mon, 20 May 2019 17:23:14 -0700 [thread overview]
Message-ID: <20190521002312.GA89786@google.com> (raw)
In-Reply-To: <SN6PR04MB49258D4FBE0B4D739E8BAF7EFC040@SN6PR04MB4925.namprd04.prod.outlook.com>
On Sat, May 18, 2019 at 03:09:44PM +0000, Avri Altman wrote:
> >
> > This series attempts to deal better with the expected transmission
> > errors that we get when waking up the SDIO-based WiFi on
> > rk3288-veyron-minnie, rk3288-veyron-speedy, and rk3288-veyron-mickey.
> >
> > Some details about those errors can be found in
> > <https://crbug.com/960222>, but to summarize it here: if we try to
> > send the wakeup command to the WiFi card at the same time it has
> > decided to wake up itself then it will behave badly on the SDIO bus.
> > This can cause timeouts or CRC errors.
> Wake-up itself: as part of a WoWlan, or d0i3?
Neither, IIUC. (It's definitely not WoWLAN, and D0i3 sounds like an
Intel thing.)
I believe it's a Broadcom-specific mode. See also Arend's response to
this thread:
http://lkml.kernel.org/linux-wireless/8c3fa57a-3843-947c-ec6b-a6144ccde1e9@broadcom.com
> Looks like this calls for a wifi driver fix, and not WA in the mmc driver.
Basically asked and answered in patch 2's thread:
https://lkml.kernel.org/lkml/20190520085201.GA1021@kunai/
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: Douglas Anderson <dianders@chromium.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Kalle Valo <kvalo@codeaurora.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
Double Lo <double.lo@cypress.com>,
Madhan Mohan R <madhanmohan.r@cypress.com>,
"mka@chromium.org" <mka@chromium.org>,
Wright Feng <wright.feng@cypress.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
"brcm80211-dev-list@cypress.com" <brcm80211-dev-list@cypress.com>,
YueHaibing <yuehaibing@huawei.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Martin Hicks <mort@bork.org>,
Ritesh Harjani <riteshh@codeaurora.org>,
Michael Trimarchi <michael@amarulasolutions.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Franky Lin <franky.lin@broadcom.com>,
Jiong Wu <lohengrin1024@gmail.com>,
"brcm80211-dev-list.pdl@broadcom.com"
<brcm80211-dev-list.pdl@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Naveen Gupta <naveen.gupta@cypress.com>
Subject: Re: [PATCH 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from sleep
Date: Mon, 20 May 2019 17:23:14 -0700 [thread overview]
Message-ID: <20190521002312.GA89786@google.com> (raw)
In-Reply-To: <SN6PR04MB49258D4FBE0B4D739E8BAF7EFC040@SN6PR04MB4925.namprd04.prod.outlook.com>
On Sat, May 18, 2019 at 03:09:44PM +0000, Avri Altman wrote:
> >
> > This series attempts to deal better with the expected transmission
> > errors that we get when waking up the SDIO-based WiFi on
> > rk3288-veyron-minnie, rk3288-veyron-speedy, and rk3288-veyron-mickey.
> >
> > Some details about those errors can be found in
> > <https://crbug.com/960222>, but to summarize it here: if we try to
> > send the wakeup command to the WiFi card at the same time it has
> > decided to wake up itself then it will behave badly on the SDIO bus.
> > This can cause timeouts or CRC errors.
> Wake-up itself: as part of a WoWlan, or d0i3?
Neither, IIUC. (It's definitely not WoWLAN, and D0i3 sounds like an
Intel thing.)
I believe it's a Broadcom-specific mode. See also Arend's response to
this thread:
http://lkml.kernel.org/linux-wireless/8c3fa57a-3843-947c-ec6b-a6144ccde1e9@broadcom.com
> Looks like this calls for a wifi driver fix, and not WA in the mmc driver.
Basically asked and answered in patch 2's thread:
https://lkml.kernel.org/lkml/20190520085201.GA1021@kunai/
next prev parent reply other threads:[~2019-05-21 0:23 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 22:54 [PATCH 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from sleep Douglas Anderson
2019-05-17 22:54 ` Douglas Anderson
2019-05-17 22:54 ` [PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 Douglas Anderson
2019-05-20 8:09 ` Arend Van Spriel
2019-05-20 18:20 ` Doug Anderson
2019-05-20 18:20 ` Doug Anderson
2019-05-28 12:18 ` Kalle Valo
2019-05-28 12:18 ` Kalle Valo
[not found] ` <20190517225420.176893-2-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2019-05-28 12:18 ` Kalle Valo
2019-05-28 15:51 ` Doug Anderson
2019-05-28 15:51 ` Doug Anderson
2019-05-28 16:09 ` Arend Van Spriel
2019-05-28 16:09 ` Arend Van Spriel
2019-05-28 16:11 ` Arend Van Spriel
2019-05-28 16:11 ` Arend Van Spriel
2019-06-04 3:20 ` Wright Feng
2019-06-04 3:20 ` Wright Feng
2019-06-04 16:01 ` Doug Anderson
2019-06-04 16:01 ` Doug Anderson
2019-06-04 16:48 ` Arend Van Spriel
2019-06-04 16:48 ` Arend Van Spriel
2019-05-29 14:51 ` Kalle Valo
2019-05-29 14:51 ` Kalle Valo
[not found] ` <20190517225420.176893-1-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2019-05-17 22:54 ` [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors Douglas Anderson
2019-05-17 22:54 ` Douglas Anderson
[not found] ` <20190517225420.176893-3-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2019-05-19 9:06 ` Wolfram Sang
2019-05-19 9:06 ` Wolfram Sang
2019-05-20 8:46 ` Arend Van Spriel
[not found] ` <36cae1d3-f11c-3c71-3f04-23fdc74f8866-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2019-05-20 8:52 ` Wolfram Sang
2019-05-20 8:52 ` Wolfram Sang
2019-05-26 18:42 ` Arend Van Spriel
2019-05-26 18:42 ` Arend Van Spriel
2019-05-28 10:04 ` Adrian Hunter
2019-05-28 11:21 ` Arend Van Spriel
2019-05-28 11:45 ` Adrian Hunter
2019-05-28 15:42 ` Doug Anderson
2019-05-17 22:54 ` [PATCH 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail Douglas Anderson
2019-05-18 15:09 ` [PATCH 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from sleep Avri Altman
2019-05-18 15:09 ` Avri Altman
2019-05-21 0:23 ` Brian Norris [this message]
2019-05-21 0:23 ` Brian Norris
2019-05-20 8:55 ` Arend Van Spriel
2019-05-20 8:55 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521002312.GA89786@google.com \
--to=briannorris@chromium.org \
--cc=Avri.Altman@wdc.com \
--cc=adrian.hunter@intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=dianders@chromium.org \
--cc=double.lo@cypress.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=madhanmohan.r@cypress.com \
--cc=mka@chromium.org \
--cc=mort@bork.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=wright.feng@cypress.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.