From: Kees Cook <keescook@chromium.org>
To: Philippe Mazenauer <philippe.mazenauer@outlook.de>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Russell King <linux@armlinux.org.uk>,
open list <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm: add missing include <linux/elf-randomize.h>
Date: Tue, 21 May 2019 13:23:51 -0700 [thread overview]
Message-ID: <201905211323.7064F60D@keescook> (raw)
In-Reply-To: <VI1PR07MB44324E07A6AFE89A920444AFFD070@VI1PR07MB4432.eurprd07.prod.outlook.com>
On Tue, May 21, 2019 at 03:54:36PM +0000, Philippe Mazenauer wrote:
> Include corresponding header file <linux/elf-randomize.h> for function
> arch_randomize_brk().
>
> ../arch/arm/kernel/process.c:325:15: warning: no previous prototype for ‘arch_randomize_brk’ [-Wmissing-prototypes]
> unsigned long arch_randomize_brk(struct mm_struct *mm)
> ^~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
Acked-by: Kees Cook <keescook@chromium.org>
> ---
> arch/arm/kernel/process.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 72cc0862a30e..73782012d403 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -23,6 +23,7 @@
> #include <linux/interrupt.h>
> #include <linux/init.h>
> #include <linux/elfcore.h>
> +#include <linux/elf-randomize.h>
> #include <linux/pm.h>
> #include <linux/tick.h>
> #include <linux/utsname.h>
> --
> 2.17.1
>
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Philippe Mazenauer <philippe.mazenauer@outlook.de>
Cc: Russell King <linux@armlinux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm: add missing include <linux/elf-randomize.h>
Date: Tue, 21 May 2019 13:23:51 -0700 [thread overview]
Message-ID: <201905211323.7064F60D@keescook> (raw)
In-Reply-To: <VI1PR07MB44324E07A6AFE89A920444AFFD070@VI1PR07MB4432.eurprd07.prod.outlook.com>
On Tue, May 21, 2019 at 03:54:36PM +0000, Philippe Mazenauer wrote:
> Include corresponding header file <linux/elf-randomize.h> for function
> arch_randomize_brk().
>
> ../arch/arm/kernel/process.c:325:15: warning: no previous prototype for ‘arch_randomize_brk’ [-Wmissing-prototypes]
> unsigned long arch_randomize_brk(struct mm_struct *mm)
> ^~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
Acked-by: Kees Cook <keescook@chromium.org>
> ---
> arch/arm/kernel/process.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 72cc0862a30e..73782012d403 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -23,6 +23,7 @@
> #include <linux/interrupt.h>
> #include <linux/init.h>
> #include <linux/elfcore.h>
> +#include <linux/elf-randomize.h>
> #include <linux/pm.h>
> #include <linux/tick.h>
> #include <linux/utsname.h>
> --
> 2.17.1
>
--
Kees Cook
next prev parent reply other threads:[~2019-05-21 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 15:54 [PATCH] arm: add missing include <linux/elf-randomize.h> Philippe Mazenauer
2019-05-21 15:54 ` Philippe Mazenauer
2019-05-21 20:23 ` Kees Cook [this message]
2019-05-21 20:23 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201905211323.7064F60D@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=philippe.mazenauer@outlook.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.