From: Johannes Weiner <hannes@cmpxchg.org>
To: lkp@lists.01.org
Subject: Re: [mm] 42a3003535: will-it-scale.per_process_ops -25.9% regression
Date: Tue, 21 May 2019 11:13:55 -0400 [thread overview]
Message-ID: <20190521151355.GA2870@cmpxchg.org> (raw)
In-Reply-To: <20190521134646.GE19312@shao2-debian>
[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]
On Tue, May 21, 2019 at 09:46:46PM +0800, kernel test robot wrote:
> On Mon, May 20, 2019 at 05:53:28PM -0400, Johannes Weiner wrote:
> > Hello,
> >
> > On Mon, May 20, 2019 at 02:35:34PM +0800, kernel test robot wrote:
> > > Greeting,
> > >
> > > FYI, we noticed a -25.9% regression of will-it-scale.per_process_ops due to commit:
> > >
> > >
> > > commit: 42a300353577ccc17ecc627b8570a89fa1678bec ("mm: memcontrol: fix recursive statistics correctness & scalabilty")
> > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > >
> > > in testcase: will-it-scale
> > > on test machine: 192 threads Skylake-SP with 256G memory
> > > with following parameters:
> >
> > Ouch. That has to be the additional cache footprint of the split
> > local/recursive stat counters, rather than the extra instructions.
> >
> > Could you please try re-running the test on that host with the below
> > patch applied?
>
> Hi,
>
> The patch can fix the regression.
>
> tests: 1
> testcase/path_params/tbox_group/run: will-it-scale/performance-process-100%-page_fault3/lkp-skl-4sp1
>
> db9adbcbe7 ("mm: memcontrol: move stat/event counting functions out-of-line")
> 8d8245997d ("mm: memcontrol: don't batch updates of local VM stats and events")
>
> db9adbcbe740e098 8d8245997dbd17c5056094f15c
> ---------------- --------------------------
> %stddev change %stddev
> \ | \
> 87819982 85307742 will-it-scale.workload
> 457395 444310 will-it-scale.per_process_ops
Fantastic, thank you for verifying! I'm going to take that as a
Tested-by.
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: kernel test robot <rong.a.chen@intel.com>
Cc: lkp@01.org, LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeelb@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Roman Gushchin <guro@fb.com>
Subject: Re: [LKP] [mm] 42a3003535: will-it-scale.per_process_ops -25.9% regression
Date: Tue, 21 May 2019 11:13:55 -0400 [thread overview]
Message-ID: <20190521151355.GA2870@cmpxchg.org> (raw)
In-Reply-To: <20190521134646.GE19312@shao2-debian>
On Tue, May 21, 2019 at 09:46:46PM +0800, kernel test robot wrote:
> On Mon, May 20, 2019 at 05:53:28PM -0400, Johannes Weiner wrote:
> > Hello,
> >
> > On Mon, May 20, 2019 at 02:35:34PM +0800, kernel test robot wrote:
> > > Greeting,
> > >
> > > FYI, we noticed a -25.9% regression of will-it-scale.per_process_ops due to commit:
> > >
> > >
> > > commit: 42a300353577ccc17ecc627b8570a89fa1678bec ("mm: memcontrol: fix recursive statistics correctness & scalabilty")
> > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > >
> > > in testcase: will-it-scale
> > > on test machine: 192 threads Skylake-SP with 256G memory
> > > with following parameters:
> >
> > Ouch. That has to be the additional cache footprint of the split
> > local/recursive stat counters, rather than the extra instructions.
> >
> > Could you please try re-running the test on that host with the below
> > patch applied?
>
> Hi,
>
> The patch can fix the regression.
>
> tests: 1
> testcase/path_params/tbox_group/run: will-it-scale/performance-process-100%-page_fault3/lkp-skl-4sp1
>
> db9adbcbe7 ("mm: memcontrol: move stat/event counting functions out-of-line")
> 8d8245997d ("mm: memcontrol: don't batch updates of local VM stats and events")
>
> db9adbcbe740e098 8d8245997dbd17c5056094f15c
> ---------------- --------------------------
> %stddev change %stddev
> \ | \
> 87819982 85307742 will-it-scale.workload
> 457395 444310 will-it-scale.per_process_ops
Fantastic, thank you for verifying! I'm going to take that as a
Tested-by.
next prev parent reply other threads:[~2019-05-21 15:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 6:35 [mm] 42a3003535: will-it-scale.per_process_ops -25.9% regression kernel test robot
2019-05-20 6:35 ` kernel test robot
2019-05-20 21:53 ` Johannes Weiner
2019-05-20 21:53 ` Johannes Weiner
2019-05-21 13:46 ` kernel test robot
2019-05-21 13:46 ` [LKP] " kernel test robot
2019-05-21 15:13 ` Johannes Weiner [this message]
2019-05-21 15:13 ` Johannes Weiner
2019-05-21 15:16 ` [PATCH] mm: memcontrol: don't batch updates of local VM stats and events Johannes Weiner
2019-05-21 15:16 ` Johannes Weiner
2019-05-28 16:00 ` Shakeel Butt
2019-05-28 16:00 ` Shakeel Butt
2019-05-28 17:37 ` Linus Torvalds
2019-05-28 17:37 ` Linus Torvalds
2019-05-28 20:32 ` Johannes Weiner
2019-05-28 20:32 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521151355.GA2870@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.