* Unhandle NONE type device model broke QDISK backend @ 2019-05-21 14:37 ` Wei Liu 0 siblings, 0 replies; 12+ messages in thread From: Wei Liu @ 2019-05-21 14:37 UTC (permalink / raw) To: Olaf Hering; +Cc: Xen-devel, Wei Liu Hi Olaf It appears there is at least one instance that's not properly handled. See http://logs.test-lab.xenproject.org/osstest/logs/136440/test-amd64-amd64-xl-qcow2/10.ts-debian-di-install.log bxl: debug: libxl_device.c:380:libxl__device_disk_set_backend: Disk vdev=xvda spec.backend=qdisk libxl: debug: libxl_linux.c:235:libxl__get_hotplug_script_info: Domain 1:backend_kind 3, no need to execute scripts libxl: debug: libxl_device.c:1174:device_hotplug: Domain 1:No hotplug script to execute libxl: debug: libxl_event.c:689:libxl__ev_xswatch_deregister: watch w=0x556be6153370: deregister unregistered libxl: error: libxl_dm.c:326:libxl__domain_device_model: invalid device model version 3 libxl: error: libxl_dm.c:2747:device_model_spawn_outcome: Domain 1:(null): spawn failed (rc=-3) The same thing showed up in the vhd test. Both test cases use QDISK backend. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Xen-devel] Unhandle NONE type device model broke QDISK backend @ 2019-05-21 14:37 ` Wei Liu 0 siblings, 0 replies; 12+ messages in thread From: Wei Liu @ 2019-05-21 14:37 UTC (permalink / raw) To: Olaf Hering; +Cc: Xen-devel, Wei Liu Hi Olaf It appears there is at least one instance that's not properly handled. See http://logs.test-lab.xenproject.org/osstest/logs/136440/test-amd64-amd64-xl-qcow2/10.ts-debian-di-install.log bxl: debug: libxl_device.c:380:libxl__device_disk_set_backend: Disk vdev=xvda spec.backend=qdisk libxl: debug: libxl_linux.c:235:libxl__get_hotplug_script_info: Domain 1:backend_kind 3, no need to execute scripts libxl: debug: libxl_device.c:1174:device_hotplug: Domain 1:No hotplug script to execute libxl: debug: libxl_event.c:689:libxl__ev_xswatch_deregister: watch w=0x556be6153370: deregister unregistered libxl: error: libxl_dm.c:326:libxl__domain_device_model: invalid device model version 3 libxl: error: libxl_dm.c:2747:device_model_spawn_outcome: Domain 1:(null): spawn failed (rc=-3) The same thing showed up in the vhd test. Both test cases use QDISK backend. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Unhandle NONE type device model broke QDISK backend @ 2019-05-21 14:41 ` Olaf Hering 0 siblings, 0 replies; 12+ messages in thread From: Olaf Hering @ 2019-05-21 14:41 UTC (permalink / raw) To: Wei Liu; +Cc: Xen-devel [-- Attachment #1.1: Type: text/plain, Size: 358 bytes --] Am Tue, 21 May 2019 15:37:02 +0100 schrieb Wei Liu <wei.liu2@citrix.com>: > bxl: debug: libxl_device.c:380:libxl__device_disk_set_backend: Disk vdev=xvda spec.backend=qdisk > libxl: debug: libxl_linux.c:235:libxl__get_hotplug_script_info: Domain 1:backend_kind 3, no need to execute scripts I will check why qdisk does not trigger QEMU_XEN. Olaf [-- Attachment #1.2: Digitale Signatur von OpenPGP --] [-- Type: application/pgp-signature, Size: 195 bytes --] [-- Attachment #2: Type: text/plain, Size: 157 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] Unhandle NONE type device model broke QDISK backend @ 2019-05-21 14:41 ` Olaf Hering 0 siblings, 0 replies; 12+ messages in thread From: Olaf Hering @ 2019-05-21 14:41 UTC (permalink / raw) To: Wei Liu; +Cc: Xen-devel [-- Attachment #1.1: Type: text/plain, Size: 358 bytes --] Am Tue, 21 May 2019 15:37:02 +0100 schrieb Wei Liu <wei.liu2@citrix.com>: > bxl: debug: libxl_device.c:380:libxl__device_disk_set_backend: Disk vdev=xvda spec.backend=qdisk > libxl: debug: libxl_linux.c:235:libxl__get_hotplug_script_info: Domain 1:backend_kind 3, no need to execute scripts I will check why qdisk does not trigger QEMU_XEN. Olaf [-- Attachment #1.2: Digitale Signatur von OpenPGP --] [-- Type: application/pgp-signature, Size: 195 bytes --] [-- Attachment #2: Type: text/plain, Size: 157 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Unhandle NONE type device model broke QDISK backend @ 2019-05-21 14:43 ` Wei Liu 0 siblings, 0 replies; 12+ messages in thread From: Wei Liu @ 2019-05-21 14:43 UTC (permalink / raw) To: Olaf Hering; +Cc: Xen-devel, Wei Liu On Tue, May 21, 2019 at 04:41:22PM +0200, Olaf Hering wrote: > Am Tue, 21 May 2019 15:37:02 +0100 > schrieb Wei Liu <wei.liu2@citrix.com>: > > > bxl: debug: libxl_device.c:380:libxl__device_disk_set_backend: Disk vdev=xvda spec.backend=qdisk > > libxl: debug: libxl_linux.c:235:libxl__get_hotplug_script_info: Domain 1:backend_kind 3, no need to execute scripts > > I will check why qdisk does not trigger QEMU_XEN. Yeah, that's indeed strange. Thanks for having a look. Wei. > > Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] Unhandle NONE type device model broke QDISK backend @ 2019-05-21 14:43 ` Wei Liu 0 siblings, 0 replies; 12+ messages in thread From: Wei Liu @ 2019-05-21 14:43 UTC (permalink / raw) To: Olaf Hering; +Cc: Xen-devel, Wei Liu On Tue, May 21, 2019 at 04:41:22PM +0200, Olaf Hering wrote: > Am Tue, 21 May 2019 15:37:02 +0100 > schrieb Wei Liu <wei.liu2@citrix.com>: > > > bxl: debug: libxl_device.c:380:libxl__device_disk_set_backend: Disk vdev=xvda spec.backend=qdisk > > libxl: debug: libxl_linux.c:235:libxl__get_hotplug_script_info: Domain 1:backend_kind 3, no need to execute scripts > > I will check why qdisk does not trigger QEMU_XEN. Yeah, that's indeed strange. Thanks for having a look. Wei. > > Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Unhandle NONE type device model broke QDISK backend @ 2019-05-21 14:58 ` Olaf Hering 0 siblings, 0 replies; 12+ messages in thread From: Olaf Hering @ 2019-05-21 14:58 UTC (permalink / raw) To: Wei Liu; +Cc: Xen-devel [-- Attachment #1.1: Type: text/plain, Size: 228 bytes --] Am Tue, 21 May 2019 15:43:15 +0100 schrieb Wei Liu <wei.liu2@citrix.com>: > Yeah, that's indeed strange. Thanks for having a look. Is the used domU.cfg available? I think In my testing disk=[] had backend=qdisk. Olaf [-- Attachment #1.2: Digitale Signatur von OpenPGP --] [-- Type: application/pgp-signature, Size: 195 bytes --] [-- Attachment #2: Type: text/plain, Size: 157 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] Unhandle NONE type device model broke QDISK backend @ 2019-05-21 14:58 ` Olaf Hering 0 siblings, 0 replies; 12+ messages in thread From: Olaf Hering @ 2019-05-21 14:58 UTC (permalink / raw) To: Wei Liu; +Cc: Xen-devel [-- Attachment #1.1: Type: text/plain, Size: 228 bytes --] Am Tue, 21 May 2019 15:43:15 +0100 schrieb Wei Liu <wei.liu2@citrix.com>: > Yeah, that's indeed strange. Thanks for having a look. Is the used domU.cfg available? I think In my testing disk=[] had backend=qdisk. Olaf [-- Attachment #1.2: Digitale Signatur von OpenPGP --] [-- Type: application/pgp-signature, Size: 195 bytes --] [-- Attachment #2: Type: text/plain, Size: 157 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Unhandle NONE type device model broke QDISK backend @ 2019-05-21 15:00 ` Wei Liu 0 siblings, 0 replies; 12+ messages in thread From: Wei Liu @ 2019-05-21 15:00 UTC (permalink / raw) To: Olaf Hering; +Cc: Xen-devel, Wei Liu On Tue, May 21, 2019 at 04:58:18PM +0200, Olaf Hering wrote: > Am Tue, 21 May 2019 15:43:15 +0100 > schrieb Wei Liu <wei.liu2@citrix.com>: > > > Yeah, that's indeed strange. Thanks for having a look. > > Is the used domU.cfg available? I think In my testing disk=[] had backend=qdisk. See http://logs.test-lab.xenproject.org/osstest/logs/136440/test-amd64-amd64-xl-qcow2/baroque0---etc-xen-debian.stretch.guest.osstest.cfg Wei. > > Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] Unhandle NONE type device model broke QDISK backend @ 2019-05-21 15:00 ` Wei Liu 0 siblings, 0 replies; 12+ messages in thread From: Wei Liu @ 2019-05-21 15:00 UTC (permalink / raw) To: Olaf Hering; +Cc: Xen-devel, Wei Liu On Tue, May 21, 2019 at 04:58:18PM +0200, Olaf Hering wrote: > Am Tue, 21 May 2019 15:43:15 +0100 > schrieb Wei Liu <wei.liu2@citrix.com>: > > > Yeah, that's indeed strange. Thanks for having a look. > > Is the used domU.cfg available? I think In my testing disk=[] had backend=qdisk. See http://logs.test-lab.xenproject.org/osstest/logs/136440/test-amd64-amd64-xl-qcow2/baroque0---etc-xen-debian.stretch.guest.osstest.cfg Wei. > > Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Unhandle NONE type device model broke QDISK backend @ 2019-05-21 15:33 ` Olaf Hering 0 siblings, 0 replies; 12+ messages in thread From: Olaf Hering @ 2019-05-21 15:33 UTC (permalink / raw) To: Wei Liu; +Cc: Xen-devel [-- Attachment #1.1: Type: text/plain, Size: 2157 bytes --] On Tue, May 21, Wei Liu wrote: > bxl: debug: libxl_device.c:380:libxl__device_disk_set_backend: Disk vdev=xvda spec.backend=qdisk > libxl: debug: libxl_linux.c:235:libxl__get_hotplug_script_info: Domain 1:backend_kind 3, no need to execute scripts The backtrace looks like that: (gdb) bt #0 libxl_device_disk_dm_needed (e=0x5555557950b0, domid=0) at libxl_disk.c:1151 #1 0x00007ffff791c9a9 in libxl__need_xenpv_qemu (gc=gc@entry=0x555555795570, d_config=d_config@entry=0x7fffffffdb90) at libxl_dm.c:3196 #2 0x00007ffff7911bdb in libxl__domain_set_device_model (gc=gc@entry=0x555555795570, d_config=d_config@entry=0x7fffffffdb90) at libxl_create.c:50 #3 0x00007ffff7914a36 in initiate_domain_create (egc=egc@entry=0x7fffffffd970, dcs=dcs@entry=0x555555797960) at libxl_create.c:967 #4 0x00007ffff791505f in do_domain_create (ctx=ctx@entry=0x555555790860, d_config=d_config@entry=0x7fffffffdb90, domid=domid@entry=0x7fffffffdac8, restore_fd=restore_fd@entry=-1, send_back_fd=send_back_fd@entry=-1, params=params@entry=0x0, ao_how=0x0, aop_console_how=0x0) at libxl_create.c:1766 #5 0x00007ffff7915c8e in libxl_domain_create_new (ctx=0x555555790860, d_config=0x7fffffffdb90, domid=0x7fffffffdac8, ao_how=0x0, aop_console_how=0x0) at libxl_create.c:1980 #6 0x0000555555579a98 in create_domain (dom_info=0x7fffffffe0f0) at xl_vmcontrol.c:932 #7 0x000055555557abfa in main_create (argc=3, argv=0x7fffffffe3c8) at xl_vmcontrol.c:1242 #8 0x0000555555561116 in main (argc=3, argv=0x7fffffffe3c8) at xl.c:413 (gdb) p *elem $2 = {backend_domid = 0, backend_domname = 0x0, pdev_path = 0x55555579b120 "/nfs_vmimages/sle12sp2/vdisk.pv_sle12sp2_c_qcow2.disk0.qcow2", vdev = 0x555555794670 "xvda", backend = LIBXL_DISK_BACKEND_UNKNOWN, format = LIBXL_DISK_FORMAT_QCOW2, script = 0x0, removable = 0, readwrite = 1, is_cdrom = 0, direct_io_safe = false, discard_enable = {val = 0}, colo_enable = {val = 0}, colo_restore_enable = {val = -1}, colo_host = 0x0, colo_port = 0, colo_export = 0x0, active_disk = 0x0, hidden_disk = 0x0} backend is not initialized at this point. With 'backend=qdisk' it will be initialized, so there is some ordering bug. Olaf [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] [-- Attachment #2: Type: text/plain, Size: 157 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Xen-devel] Unhandle NONE type device model broke QDISK backend @ 2019-05-21 15:33 ` Olaf Hering 0 siblings, 0 replies; 12+ messages in thread From: Olaf Hering @ 2019-05-21 15:33 UTC (permalink / raw) To: Wei Liu; +Cc: Xen-devel [-- Attachment #1.1: Type: text/plain, Size: 2157 bytes --] On Tue, May 21, Wei Liu wrote: > bxl: debug: libxl_device.c:380:libxl__device_disk_set_backend: Disk vdev=xvda spec.backend=qdisk > libxl: debug: libxl_linux.c:235:libxl__get_hotplug_script_info: Domain 1:backend_kind 3, no need to execute scripts The backtrace looks like that: (gdb) bt #0 libxl_device_disk_dm_needed (e=0x5555557950b0, domid=0) at libxl_disk.c:1151 #1 0x00007ffff791c9a9 in libxl__need_xenpv_qemu (gc=gc@entry=0x555555795570, d_config=d_config@entry=0x7fffffffdb90) at libxl_dm.c:3196 #2 0x00007ffff7911bdb in libxl__domain_set_device_model (gc=gc@entry=0x555555795570, d_config=d_config@entry=0x7fffffffdb90) at libxl_create.c:50 #3 0x00007ffff7914a36 in initiate_domain_create (egc=egc@entry=0x7fffffffd970, dcs=dcs@entry=0x555555797960) at libxl_create.c:967 #4 0x00007ffff791505f in do_domain_create (ctx=ctx@entry=0x555555790860, d_config=d_config@entry=0x7fffffffdb90, domid=domid@entry=0x7fffffffdac8, restore_fd=restore_fd@entry=-1, send_back_fd=send_back_fd@entry=-1, params=params@entry=0x0, ao_how=0x0, aop_console_how=0x0) at libxl_create.c:1766 #5 0x00007ffff7915c8e in libxl_domain_create_new (ctx=0x555555790860, d_config=0x7fffffffdb90, domid=0x7fffffffdac8, ao_how=0x0, aop_console_how=0x0) at libxl_create.c:1980 #6 0x0000555555579a98 in create_domain (dom_info=0x7fffffffe0f0) at xl_vmcontrol.c:932 #7 0x000055555557abfa in main_create (argc=3, argv=0x7fffffffe3c8) at xl_vmcontrol.c:1242 #8 0x0000555555561116 in main (argc=3, argv=0x7fffffffe3c8) at xl.c:413 (gdb) p *elem $2 = {backend_domid = 0, backend_domname = 0x0, pdev_path = 0x55555579b120 "/nfs_vmimages/sle12sp2/vdisk.pv_sle12sp2_c_qcow2.disk0.qcow2", vdev = 0x555555794670 "xvda", backend = LIBXL_DISK_BACKEND_UNKNOWN, format = LIBXL_DISK_FORMAT_QCOW2, script = 0x0, removable = 0, readwrite = 1, is_cdrom = 0, direct_io_safe = false, discard_enable = {val = 0}, colo_enable = {val = 0}, colo_restore_enable = {val = -1}, colo_host = 0x0, colo_port = 0, colo_export = 0x0, active_disk = 0x0, hidden_disk = 0x0} backend is not initialized at this point. With 'backend=qdisk' it will be initialized, so there is some ordering bug. Olaf [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] [-- Attachment #2: Type: text/plain, Size: 157 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-05-21 15:34 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-05-21 14:37 Unhandle NONE type device model broke QDISK backend Wei Liu 2019-05-21 14:37 ` [Xen-devel] " Wei Liu 2019-05-21 14:41 ` Olaf Hering 2019-05-21 14:41 ` [Xen-devel] " Olaf Hering 2019-05-21 14:43 ` Wei Liu 2019-05-21 14:43 ` [Xen-devel] " Wei Liu 2019-05-21 14:58 ` Olaf Hering 2019-05-21 14:58 ` [Xen-devel] " Olaf Hering 2019-05-21 15:00 ` Wei Liu 2019-05-21 15:00 ` [Xen-devel] " Wei Liu 2019-05-21 15:33 ` Olaf Hering 2019-05-21 15:33 ` [Xen-devel] " Olaf Hering
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.