From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Dan Murphy <dmurphy@ti.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] leds: TI LMU: remove redundant u8 comparisons with less than zero
Date: Wed, 22 May 2019 09:53:17 +0000 [thread overview]
Message-ID: <20190522095317.GT31203@kadam> (raw)
In-Reply-To: <20190522082627.18354-1-colin.king@canonical.com>
No. This isn't the right fix. We should declare them as int instead.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Dan Murphy <dmurphy@ti.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] leds: TI LMU: remove redundant u8 comparisons with less than zero
Date: Wed, 22 May 2019 12:53:17 +0300 [thread overview]
Message-ID: <20190522095317.GT31203@kadam> (raw)
In-Reply-To: <20190522082627.18354-1-colin.king@canonical.com>
No. This isn't the right fix. We should declare them as int instead.
regards,
dan carpenter
next prev parent reply other threads:[~2019-05-22 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 8:26 [PATCH][next] leds: TI LMU: remove redundant u8 comparisons with less than zero Colin King
2019-05-22 8:26 ` Colin King
2019-05-22 9:53 ` Dan Carpenter [this message]
2019-05-22 9:53 ` Dan Carpenter
2019-05-22 10:00 ` Colin Ian King
2019-05-22 10:00 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522095317.GT31203@kadam \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.