From: Kees Cook <keescook@chromium.org>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: onenand_base: Avoid fall-through warnings
Date: Wed, 22 May 2019 15:20:06 -0700 [thread overview]
Message-ID: <201905221519.88B9364E@keescook> (raw)
In-Reply-To: <20190522235738.68059906@collabora.com>
On Wed, May 22, 2019 at 11:57:38PM +0200, Boris Brezillon wrote:
> All this look suspicious, and even if the fall through logic
> has no side effects in practice (which I'm still not sure is the case),
> I think it'd be better to explicitly set the flags that have
> to be set in each case statement and add breaks.
Yeah, totally agreed. :)
--
Kees Cook
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: onenand_base: Avoid fall-through warnings
Date: Wed, 22 May 2019 15:20:06 -0700 [thread overview]
Message-ID: <201905221519.88B9364E@keescook> (raw)
In-Reply-To: <20190522235738.68059906@collabora.com>
On Wed, May 22, 2019 at 11:57:38PM +0200, Boris Brezillon wrote:
> All this look suspicious, and even if the fall through logic
> has no side effects in practice (which I'm still not sure is the case),
> I think it'd be better to explicitly set the flags that have
> to be set in each case statement and add breaks.
Yeah, totally agreed. :)
--
Kees Cook
next prev parent reply other threads:[~2019-05-22 22:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 18:04 [PATCH] mtd: onenand_base: Avoid fall-through warnings Gustavo A. R. Silva
2019-05-22 18:04 ` Gustavo A. R. Silva
2019-05-22 21:30 ` Kees Cook
2019-05-22 21:30 ` Kees Cook
2019-05-22 21:57 ` Boris Brezillon
2019-05-22 21:57 ` Boris Brezillon
2019-05-22 22:20 ` Kees Cook [this message]
2019-05-22 22:20 ` Kees Cook
2019-05-22 22:30 ` Gustavo A. R. Silva
2019-05-22 22:30 ` Gustavo A. R. Silva
2019-05-22 21:37 ` Boris Brezillon
2019-05-22 21:37 ` Boris Brezillon
2019-05-22 21:45 ` Kees Cook
2019-05-22 21:45 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201905221519.88B9364E@keescook \
--to=keescook@chromium.org \
--cc=boris.brezillon@collabora.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gustavo@embeddedor.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.