All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t] lib/i915: Fix test enumeration on legacy kernels
Date: Thu, 23 May 2019 11:52:58 +0300	[thread overview]
Message-ID: <20190523085258.GB3110@intel.intel> (raw)
In-Reply-To: <20190523083929.6015-1-tvrtko.ursulin@linux.intel.com>

Hi Tvrtko,

On Thu, May 23, 2019 at 09:39:29AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Where engine discovery and context engine map are not supported we must
> not call the asserting gem_class_instance_to_eb_flags from the engine
> list initalizer. (Since not all engines can be addressed using the legacy
> execbuf API.)
> 
> Instead extract the code into lower level __gem_class_instance_to_eb_flags
> helper which can return errors the caller can manually handle then.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>

Chris was after this: 

https://patchwork.freedesktop.org/patch/306446/

Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] lib/i915: Fix test enumeration on legacy kernels
Date: Thu, 23 May 2019 11:52:58 +0300	[thread overview]
Message-ID: <20190523085258.GB3110@intel.intel> (raw)
In-Reply-To: <20190523083929.6015-1-tvrtko.ursulin@linux.intel.com>

Hi Tvrtko,

On Thu, May 23, 2019 at 09:39:29AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Where engine discovery and context engine map are not supported we must
> not call the asserting gem_class_instance_to_eb_flags from the engine
> list initalizer. (Since not all engines can be addressed using the legacy
> execbuf API.)
> 
> Instead extract the code into lower level __gem_class_instance_to_eb_flags
> helper which can return errors the caller can manually handle then.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>

Chris was after this: 

https://patchwork.freedesktop.org/patch/306446/

Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-05-23  8:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23  8:39 [igt-dev] [PATCH i-g-t] lib/i915: Fix test enumeration on legacy kernels Tvrtko Ursulin
2019-05-23  8:39 ` Tvrtko Ursulin
2019-05-23  8:52 ` Andi Shyti [this message]
2019-05-23  8:52   ` Andi Shyti
2019-05-23  9:30 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-24  5:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523085258.GB3110@intel.intel \
    --to=andi.shyti@intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.