From: Shawn Guo <shawnguo@kernel.org>
To: Anson Huang <anson.huang@nxp.com>
Cc: Abel Vesa <abel.vesa@nxp.com>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Leonard Crestez <leonard.crestez@nxp.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling
Date: Thu, 23 May 2019 20:40:45 +0800 [thread overview]
Message-ID: <20190523124044.GT9261@dragon> (raw)
In-Reply-To: <1558430013-18346-1-git-send-email-Anson.Huang@nxp.com>
On Tue, May 21, 2019 at 09:18:43AM +0000, Anson Huang wrote:
> of_node_put() is called after of_match_node() successfully called,
> then in the following error handling, of_node_put() is called again
> which is unnecessary, this patch adjusts the location of of_node_put()
> to avoid such scenario.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Again, there are '=20' in the patch content and I cannot apply it.
Shawn
> ---
> drivers/soc/imx/soc-imx8.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c
> index b1bd8e2..944add2 100644
> --- a/drivers/soc/imx/soc-imx8.c
> +++ b/drivers/soc/imx/soc-imx8.c
> @@ -86,8 +86,6 @@ static int __init imx8_soc_init(void)
> if (!id)
> goto free_soc;
>
> - of_node_put(root);
> -
> data = id->data;
> if (data) {
> soc_dev_attr->soc_id = data->name;
> @@ -106,6 +104,8 @@ static int __init imx8_soc_init(void)
> if (IS_ENABLED(CONFIG_ARM_IMX_CPUFREQ_DT))
> platform_device_register_simple("imx-cpufreq-dt", -1, NULL, 0);
>
> + of_node_put(root);
> +
> return 0;
>
> free_rev:
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Anson Huang <anson.huang@nxp.com>
Cc: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Abel Vesa <abel.vesa@nxp.com>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling
Date: Thu, 23 May 2019 20:40:45 +0800 [thread overview]
Message-ID: <20190523124044.GT9261@dragon> (raw)
In-Reply-To: <1558430013-18346-1-git-send-email-Anson.Huang@nxp.com>
On Tue, May 21, 2019 at 09:18:43AM +0000, Anson Huang wrote:
> of_node_put() is called after of_match_node() successfully called,
> then in the following error handling, of_node_put() is called again
> which is unnecessary, this patch adjusts the location of of_node_put()
> to avoid such scenario.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Again, there are '=20' in the patch content and I cannot apply it.
Shawn
> ---
> drivers/soc/imx/soc-imx8.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c
> index b1bd8e2..944add2 100644
> --- a/drivers/soc/imx/soc-imx8.c
> +++ b/drivers/soc/imx/soc-imx8.c
> @@ -86,8 +86,6 @@ static int __init imx8_soc_init(void)
> if (!id)
> goto free_soc;
>
> - of_node_put(root);
> -
> data = id->data;
> if (data) {
> soc_dev_attr->soc_id = data->name;
> @@ -106,6 +104,8 @@ static int __init imx8_soc_init(void)
> if (IS_ENABLED(CONFIG_ARM_IMX_CPUFREQ_DT))
> platform_device_register_simple("imx-cpufreq-dt", -1, NULL, 0);
>
> + of_node_put(root);
> +
> return 0;
>
> free_rev:
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-05-23 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 9:18 [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling Anson Huang
2019-05-21 9:18 ` Anson Huang
2019-05-21 9:18 ` [PATCH 2/2] soc: imx: soc-imx8: Correct return value of error handle Anson Huang
2019-05-21 9:18 ` Anson Huang
2019-05-21 11:03 ` [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling Leonard Crestez
2019-05-21 11:03 ` Leonard Crestez
2019-05-23 12:40 ` Shawn Guo [this message]
2019-05-23 12:40 ` Shawn Guo
2019-05-24 5:53 ` Anson Huang
2019-05-24 5:53 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523124044.GT9261@dragon \
--to=shawnguo@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=anson.huang@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.