From: Petr Vorel <pvorel@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Cyril Hrubis <chrubis@suse.cz>,
ltp@lists.linux.it, overlayfs <linux-unionfs@vger.kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
"J. Bruce Fields" <bfields@fieldses.org>,
Li Wang <liwang@redhat.com>
Subject: Re: [LTP] [PATCH] [COMMITTED] syscalls/fcntl33: Fix typo overlapfs -> overlayfs
Date: Thu, 23 May 2019 22:01:26 +0200 [thread overview]
Message-ID: <20190523200125.GA20104@dell5510> (raw)
In-Reply-To: <CAOQ4uxhHVG9f1njmPgei8-QO4UEivXbxoHkqKi4f50XN6Gup9A@mail.gmail.com>
Hi,
> On Thu, May 23, 2019 at 4:45 PM Cyril Hrubis <chrubis@suse.cz> wrote:
> > Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> > ---
> > testcases/kernel/syscalls/fcntl/fcntl33.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/testcases/kernel/syscalls/fcntl/fcntl33.c b/testcases/kernel/syscalls/fcntl/fcntl33.c
> > index 43dc5a2af..627823c5c 100644
> > --- a/testcases/kernel/syscalls/fcntl/fcntl33.c
> > +++ b/testcases/kernel/syscalls/fcntl/fcntl33.c
> > @@ -117,7 +117,7 @@ static void do_test(unsigned int i)
> > if (TST_RET == -1) {
> > if (type == TST_OVERLAYFS_MAGIC && TST_ERR == EAGAIN) {
> > tst_res(TINFO | TTERRNO,
> > - "fcntl(F_SETLEASE, F_WRLCK) failed on overlapfs as expected");
> > + "fcntl(F_SETLEASE, F_WRLCK) failed on overlayfs as expected");
> You have 3 more of this typo in fcntl tests.
Thanks for report, Amir. Cyril will fix it tomorrow I guess.
> If you ask me, silencing this error seems wrong.
> While the error is *expected* it is still a broken interface.
> It may be just a matter of terminology, but I am reading this message as:
> TEST PASSED: Overlayfs failed as expected
> While it really should be more along the lines of:
> TEST SKIPPED: Overlayfs doesn't support write leased
+1, so besides changed phrasing use TCONF instead of TINFO in the error message.
> Besides, this problem looks quite easy to fix.
> I think Bruce was already looking at changing the implementation of
> check_conflicting_open(), so if the test is not failing, nobody is going to
> nudge for a fix...
> Thanks,
> Amir.
Kind regards,
Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] [COMMITTED] syscalls/fcntl33: Fix typo overlapfs -> overlayfs
Date: Thu, 23 May 2019 22:01:26 +0200 [thread overview]
Message-ID: <20190523200125.GA20104@dell5510> (raw)
In-Reply-To: <CAOQ4uxhHVG9f1njmPgei8-QO4UEivXbxoHkqKi4f50XN6Gup9A@mail.gmail.com>
Hi,
> On Thu, May 23, 2019 at 4:45 PM Cyril Hrubis <chrubis@suse.cz> wrote:
> > Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> > ---
> > testcases/kernel/syscalls/fcntl/fcntl33.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/testcases/kernel/syscalls/fcntl/fcntl33.c b/testcases/kernel/syscalls/fcntl/fcntl33.c
> > index 43dc5a2af..627823c5c 100644
> > --- a/testcases/kernel/syscalls/fcntl/fcntl33.c
> > +++ b/testcases/kernel/syscalls/fcntl/fcntl33.c
> > @@ -117,7 +117,7 @@ static void do_test(unsigned int i)
> > if (TST_RET == -1) {
> > if (type == TST_OVERLAYFS_MAGIC && TST_ERR == EAGAIN) {
> > tst_res(TINFO | TTERRNO,
> > - "fcntl(F_SETLEASE, F_WRLCK) failed on overlapfs as expected");
> > + "fcntl(F_SETLEASE, F_WRLCK) failed on overlayfs as expected");
> You have 3 more of this typo in fcntl tests.
Thanks for report, Amir. Cyril will fix it tomorrow I guess.
> If you ask me, silencing this error seems wrong.
> While the error is *expected* it is still a broken interface.
> It may be just a matter of terminology, but I am reading this message as:
> TEST PASSED: Overlayfs failed as expected
> While it really should be more along the lines of:
> TEST SKIPPED: Overlayfs doesn't support write leased
+1, so besides changed phrasing use TCONF instead of TINFO in the error message.
> Besides, this problem looks quite easy to fix.
> I think Bruce was already looking at changing the implementation of
> check_conflicting_open(), so if the test is not failing, nobody is going to
> nudge for a fix...
> Thanks,
> Amir.
Kind regards,
Petr
next prev parent reply other threads:[~2019-05-23 20:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 13:45 [LTP] [PATCH] [COMMITTED] syscalls/fcntl33: Fix typo overlapfs -> overlayfs Cyril Hrubis
2019-05-23 15:42 ` Amir Goldstein
2019-05-23 15:42 ` Amir Goldstein
2019-05-23 16:46 ` J. Bruce Fields
2019-05-23 16:46 ` J. Bruce Fields
2019-05-23 17:26 ` Amir Goldstein
2019-05-23 17:26 ` Amir Goldstein
2019-05-23 17:40 ` J. Bruce Fields
2019-05-23 17:40 ` J. Bruce Fields
2019-05-23 20:01 ` Petr Vorel [this message]
2019-05-23 20:01 ` Petr Vorel
2019-05-24 8:59 ` Cyril Hrubis
2019-05-24 8:59 ` Cyril Hrubis
2019-05-24 11:03 ` Amir Goldstein
2019-05-24 11:03 ` Amir Goldstein
2019-05-24 13:45 ` Cyril Hrubis
2019-05-24 13:45 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523200125.GA20104@dell5510 \
--to=pvorel@suse.cz \
--cc=amir73il@gmail.com \
--cc=bfields@fieldses.org \
--cc=chrubis@suse.cz \
--cc=linux-unionfs@vger.kernel.org \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.