From: Pavel Machek <pavel@ucw.cz>
To: Angus Ainslie <angus@akkea.ca>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel-owner@vger.kernel.org,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
angus.ainslie@puri.sm, Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v13 2/4] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit
Date: Fri, 24 May 2019 00:06:10 +0200 [thread overview]
Message-ID: <20190523220610.GB15523@amd> (raw)
In-Reply-To: <9626cd324eaaab2b49c37cf3c824aa5e@www.akkea.ca>
[-- Attachment #1.1: Type: text/plain, Size: 1486 bytes --]
Hi!
> >>This is for the development kit board for the Librem 5. The current
> >>level
> >>of support yields a working console and is able to boot userspace from
> >>the network or eMMC.
> >>
> >>Additional subsystems that are active :
> >
> >>- haptic motor
> >
> >Haptic motor is not a LED. It should be controlled by input subsystem.
> >
> >>+ pwmleds {
> >>+ compatible = "pwm-leds";
> >>+
> >>+ haptic {
> >>+ label = "librem5::haptic";
> >>+ pwms = <&pwm2 0 200000>;
> >>+ active-low;
> >>+ max-brightness = <255>;
> >>+ power-supply = <®_3v3_p>;
> >>+ };
> >>+ };
> >
> >You can take a look at N900, that has reasonable interface.
>
> I wanted to control the haptic with the pwm-vibra driver but "fsl,imx27-pwm"
> doesn't seem to respect the PWM_POLARITY_INVERTED flag so when I start the
> system the vibrator is full on.
Ok, lets fix that :-).
> I could use gpio-vibrator but that seemed like a waste when the device is
> connected to pwm.
>
> I figured the using the pwm-leds interface was a reasonable compromise until
> I had an opportunity to make changes the the imx27-pwm driver.
I guess in such case it would be best to leave out this section for
now... or keep it disabled / something. We don't want incorrect device
trees to stick around.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Angus Ainslie <angus@akkea.ca>
Cc: angus.ainslie@puri.sm, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH v13 2/4] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit
Date: Fri, 24 May 2019 00:06:10 +0200 [thread overview]
Message-ID: <20190523220610.GB15523@amd> (raw)
In-Reply-To: <9626cd324eaaab2b49c37cf3c824aa5e@www.akkea.ca>
[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]
Hi!
> >>This is for the development kit board for the Librem 5. The current
> >>level
> >>of support yields a working console and is able to boot userspace from
> >>the network or eMMC.
> >>
> >>Additional subsystems that are active :
> >
> >>- haptic motor
> >
> >Haptic motor is not a LED. It should be controlled by input subsystem.
> >
> >>+ pwmleds {
> >>+ compatible = "pwm-leds";
> >>+
> >>+ haptic {
> >>+ label = "librem5::haptic";
> >>+ pwms = <&pwm2 0 200000>;
> >>+ active-low;
> >>+ max-brightness = <255>;
> >>+ power-supply = <®_3v3_p>;
> >>+ };
> >>+ };
> >
> >You can take a look at N900, that has reasonable interface.
>
> I wanted to control the haptic with the pwm-vibra driver but "fsl,imx27-pwm"
> doesn't seem to respect the PWM_POLARITY_INVERTED flag so when I start the
> system the vibrator is full on.
Ok, lets fix that :-).
> I could use gpio-vibrator but that seemed like a waste when the device is
> connected to pwm.
>
> I figured the using the pwm-leds interface was a reasonable compromise until
> I had an opportunity to make changes the the imx27-pwm driver.
I guess in such case it would be best to leave out this section for
now... or keep it disabled / something. We don't want incorrect device
trees to stick around.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-05-23 22:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 14:23 [PATCH v13 0/4] Add support for the Purism Librem5 devkit Angus Ainslie (Purism)
2019-05-20 14:23 ` Angus Ainslie (Purism)
2019-05-20 14:23 ` [PATCH v13 1/4] MAINTAINERS: add an entry for for arm64 imx devicetrees Angus Ainslie (Purism)
2019-05-20 14:23 ` Angus Ainslie (Purism)
2019-05-20 14:23 ` Angus Ainslie (Purism)
2019-05-20 14:23 ` [PATCH v13 2/4] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit Angus Ainslie (Purism)
2019-05-20 14:23 ` Angus Ainslie (Purism)
2019-05-23 19:19 ` Pavel Machek
2019-05-23 19:19 ` Pavel Machek
2019-05-23 19:19 ` Pavel Machek
2019-05-23 21:52 ` Angus Ainslie
2019-05-23 21:52 ` Angus Ainslie
2019-05-23 22:06 ` Pavel Machek [this message]
2019-05-23 22:06 ` Pavel Machek
2019-05-23 19:19 ` Pavel Machek
2019-05-23 19:19 ` Pavel Machek
2019-05-23 19:19 ` Pavel Machek
2019-05-24 22:00 ` Angus Ainslie
2019-05-24 22:00 ` Angus Ainslie
2019-05-24 22:20 ` Angus Ainslie
2019-05-24 22:20 ` Angus Ainslie
2019-05-20 14:23 ` [PATCH v13 3/4] dt-bindings: Add an entry for Purism SPC Angus Ainslie (Purism)
2019-05-20 14:23 ` Angus Ainslie (Purism)
2019-05-20 23:00 ` Rob Herring
2019-05-20 23:00 ` Rob Herring
2019-05-20 14:23 ` [PATCH v13 4/4] dt-bindings: arm: fsl: Add the imx8mq boards Angus Ainslie (Purism)
2019-05-20 14:23 ` Angus Ainslie (Purism)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523220610.GB15523@amd \
--to=pavel@ucw.cz \
--cc=angus.ainslie@puri.sm \
--cc=angus@akkea.ca \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.