From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Grzegorz Halat <ghalat@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jiri Slaby <jslaby@suse.com>,
Oleksandr Natalenko <oleksandr@redhat.com>
Subject: Re: [PATCH] vt/fbcon: deinitialize resources in visual_init() after failed memory allocation
Date: Fri, 24 May 2019 08:06:02 +0000 [thread overview]
Message-ID: <20190524080602.GA19514@kroah.com> (raw)
In-Reply-To: <CAKbGCscqbvOaXPTdmxatNLBygdu=WC0hVUKx0_WnqUR4+dj_zQ@mail.gmail.com>
On Thu, May 16, 2019 at 04:33:40PM +0200, Grzegorz Halat wrote:
> On Fri, 26 Apr 2019 at 16:59, Grzegorz Halat <ghalat@redhat.com> wrote:
> >
> > After memory allocation failure vc_allocate() doesn't clean up data
> > which has been initialized in visual_init(). In case of fbcon this
> > leads to divide-by-0 in fbcon_init() on next open of the same tty.
>
> Hi,
> A gentle reminder. Could you please review my patch? I've seen two
> crashes caused by this bug.
How? How are you triggering a memory allocation failure in a "normal"
system?
Anyway, I'll queue this up, but it really does not seem like anything
anyone would see "in the wild".
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Grzegorz Halat <ghalat@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jiri Slaby <jslaby@suse.com>,
Oleksandr Natalenko <oleksandr@redhat.com>
Subject: Re: [PATCH] vt/fbcon: deinitialize resources in visual_init() after failed memory allocation
Date: Fri, 24 May 2019 10:06:02 +0200 [thread overview]
Message-ID: <20190524080602.GA19514@kroah.com> (raw)
In-Reply-To: <CAKbGCscqbvOaXPTdmxatNLBygdu=WC0hVUKx0_WnqUR4+dj_zQ@mail.gmail.com>
On Thu, May 16, 2019 at 04:33:40PM +0200, Grzegorz Halat wrote:
> On Fri, 26 Apr 2019 at 16:59, Grzegorz Halat <ghalat@redhat.com> wrote:
> >
> > After memory allocation failure vc_allocate() doesn't clean up data
> > which has been initialized in visual_init(). In case of fbcon this
> > leads to divide-by-0 in fbcon_init() on next open of the same tty.
>
> Hi,
> A gentle reminder. Could you please review my patch? I've seen two
> crashes caused by this bug.
How? How are you triggering a memory allocation failure in a "normal"
system?
Anyway, I'll queue this up, but it really does not seem like anything
anyone would see "in the wild".
thanks,
greg k-h
next prev parent reply other threads:[~2019-05-24 8:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190426145959epcas3p452b4b80025c58916331820abbb0060ed@epcas3p4.samsung.com>
2019-04-26 14:59 ` [PATCH] vt/fbcon: deinitialize resources in visual_init() after failed memory allocation Grzegorz Halat
2019-04-26 14:59 ` Grzegorz Halat
2019-05-16 14:33 ` Grzegorz Halat
2019-05-16 14:33 ` Grzegorz Halat
2019-05-24 8:06 ` Greg Kroah-Hartman [this message]
2019-05-24 8:06 ` Greg Kroah-Hartman
2019-05-24 13:52 ` Grzegorz Halat
2019-05-24 13:52 ` Grzegorz Halat
2019-05-24 15:08 ` Greg Kroah-Hartman
2019-05-24 15:08 ` Greg Kroah-Hartman
2019-05-17 11:24 ` Bartlomiej Zolnierkiewicz
2019-05-17 11:24 ` Bartlomiej Zolnierkiewicz
[not found] <20190426144357.25826-1-ghalat@redhat.com>
2019-05-21 6:27 ` Oleksandr Natalenko
2019-05-21 6:27 ` Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524080602.GA19514@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=ghalat@redhat.com \
--cc=jslaby@suse.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.