From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] package/busybox: Avoid "can't create /proc/sys/kernel/hotplug" error
Date: Fri, 24 May 2019 16:25:48 +0300 [thread overview]
Message-ID: <20190524132548.GU9224@smile.fi.intel.com> (raw)
In-Reply-To: <87pno8qol1.fsf@dell.be.48ers.dk>
On Fri, May 24, 2019 at 09:49:30AM +0200, Peter Korsgaard wrote:
> >>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>
> >>>>> "Andy" == Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> >> At runtime on most of the modern kernels [1] S10mdev script produces an error:
> >> /etc/init.d/S10mdev: line 9: can't create /proc/sys/kernel/hotplug: nonexistent directory
>
> >> since the commit
>
> >> caae7fa1d737 ("busybox: register mdev as hotplug helper when selected")
>
> >> added it unconditionally.
>
> >> Check the presence of procfs node before writing to it.
>
> >> [1]: Linux kernels with the commit
> >> 86d56134f1b6 ("kobject: Make support for uevent_helper optional.")
> >> applied.
>
> > But how can mdev work on such setups?
At least the script is used to initialize modules at the boot time.
What happens afterwards I didn't investigate. I have no such issues.
> To be clear, if mdev needs CONFIG_UEVENT_HELPER=y for hotplug
> notifications, then we should rather force that in linux/linux.mk and
> mention the dependency in the mdev help text rather than silently not
> having hotplug work.
>
> I have marked this patch as changes requested in patchwork.
Kernel can be built outside of Buildroot. Still this needs to be fixed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-05-24 13:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 13:14 [Buildroot] [PATCH v1] package/busybox: Avoid "can't create /proc/sys/kernel/hotplug" error Andy Shevchenko
2019-05-23 14:33 ` Peter Korsgaard
2019-05-24 7:49 ` Peter Korsgaard
2019-05-24 13:25 ` Andy Shevchenko [this message]
2019-05-24 21:12 ` Peter Korsgaard
2019-05-24 21:39 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524132548.GU9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.