All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] package/busybox: Avoid "can't create /proc/sys/kernel/hotplug" error
Date: Fri, 24 May 2019 23:12:17 +0200	[thread overview]
Message-ID: <87sgt3pnf2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190524132548.GU9224@smile.fi.intel.com> (Andy Shevchenko's message of "Fri, 24 May 2019 16:25:48 +0300")

>>>>> "Andy" == Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

 >> > But how can mdev work on such setups?

 > At least the script is used to initialize modules at the boot time.
 > What happens afterwards I didn't investigate. I have no such issues.

You mean the:

        # coldplug modules
        find /sys/ -name modalias -print0 | xargs -0 sort -u | tr '\n' '\0' | \
            xargs -0 modprobe -abq

That indeed does not depend on mdev working.


 >> To be clear, if mdev needs CONFIG_UEVENT_HELPER=y for hotplug
 >> notifications, then we should rather force that in linux/linux.mk and
 >> mention the dependency in the mdev help text rather than silently not
 >> having hotplug work.
 >> 
 >> I have marked this patch as changes requested in patchwork.

 > Kernel can be built outside of Buildroot. Still this needs to be fixed.

And just like all other packages that require specific kernel options
enabled, if you are not using Buildroot to build the kernel then you
have to ensure the kernel has the right config options enabled.

I am not sure what you mean exactly with "Still this needs to be
fixed". The only fix I can think of is what I mentioned above,
E.G. document the need for CONFIG_UEVENT_HELPER in the help text and
automatically enable it in linux.mk.

Expecting mdev to work sensible on a system without uevent helper
support isn't sensible, it is similar to having radvd (IPv6 router
advertising daemon) work on a system without IPv6.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2019-05-24 21:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 13:14 [Buildroot] [PATCH v1] package/busybox: Avoid "can't create /proc/sys/kernel/hotplug" error Andy Shevchenko
2019-05-23 14:33 ` Peter Korsgaard
2019-05-24  7:49   ` Peter Korsgaard
2019-05-24 13:25     ` Andy Shevchenko
2019-05-24 21:12       ` Peter Korsgaard [this message]
2019-05-24 21:39         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgt3pnf2.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.