All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Angus Ainslie <angus@akkea.ca>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	angus.ainslie@puri.sm, Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v14 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit
Date: Fri, 24 May 2019 22:42:39 +0200	[thread overview]
Message-ID: <20190524204239.GA18646@amd> (raw)
In-Reply-To: <20190524183257.16066-2-angus@akkea.ca>


[-- Attachment #1.1: Type: text/plain, Size: 1332 bytes --]

Hi!

> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_gpio_leds>;
> +
> +		led1 {
> +			label = "LED 1";
> +			gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
> +			default-state = "off";
> +		};
> +	};

I had comments about these...

> +	vibrator {
> +		compatible = "gpio-vibrator";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_haptic>;
> +	        enable-gpios = <&gpio5 4 GPIO_ACTIVE_LOW>;
> +		vcc-supply = <&reg_3v3_p>;
> +	};

Thanks!

> +	charger@6b { /* bq25896 */
> +		compatible = "ti,bq25890";
> +		reg = <0x6b>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_charger>;
> +		interrupt-parent = <&gpio3>;
> +		interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
> +		ti,battery-regulation-voltage = <4192000>; /* 4.192V */
> +		ti,charge-current = <1600000>; /* 1.6 A */
> +		ti,termination-current = <66000>;  /* 66mA */
> +		ti,precharge-current = <1300000>; /* 1.3A */
> +		ti,minimum-sys-voltage = <2750000>; /* 2.75V */
> +		ti,boost-voltage = <5000000>; /* 5V */
> +		ti,boost-max-current = <50000>; /* 50mA */
> +	};

And this. Did they get lost somewhere?
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Angus Ainslie <angus@akkea.ca>
Cc: angus.ainslie@puri.sm, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v14 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit
Date: Fri, 24 May 2019 22:42:39 +0200	[thread overview]
Message-ID: <20190524204239.GA18646@amd> (raw)
In-Reply-To: <20190524183257.16066-2-angus@akkea.ca>

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]

Hi!

> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_gpio_leds>;
> +
> +		led1 {
> +			label = "LED 1";
> +			gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
> +			default-state = "off";
> +		};
> +	};

I had comments about these...

> +	vibrator {
> +		compatible = "gpio-vibrator";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_haptic>;
> +	        enable-gpios = <&gpio5 4 GPIO_ACTIVE_LOW>;
> +		vcc-supply = <&reg_3v3_p>;
> +	};

Thanks!

> +	charger@6b { /* bq25896 */
> +		compatible = "ti,bq25890";
> +		reg = <0x6b>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_charger>;
> +		interrupt-parent = <&gpio3>;
> +		interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
> +		ti,battery-regulation-voltage = <4192000>; /* 4.192V */
> +		ti,charge-current = <1600000>; /* 1.6 A */
> +		ti,termination-current = <66000>;  /* 66mA */
> +		ti,precharge-current = <1300000>; /* 1.3A */
> +		ti,minimum-sys-voltage = <2750000>; /* 2.75V */
> +		ti,boost-voltage = <5000000>; /* 5V */
> +		ti,boost-max-current = <50000>; /* 50mA */
> +	};

And this. Did they get lost somewhere?
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2019-05-24 20:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24 18:32 [PATCH v14 0/3] Add support for the Purism Librem5 devkit Angus Ainslie
2019-05-24 18:32 ` Angus Ainslie
2019-05-24 18:32 ` [PATCH v14 1/3] arm64: dts: fsl: librem5: Add a device tree for the " Angus Ainslie
2019-05-24 18:32   ` Angus Ainslie
2019-05-24 20:42   ` Pavel Machek [this message]
2019-05-24 20:42     ` Pavel Machek
2019-05-24 20:49   ` Pavel Machek
2019-05-24 20:49     ` Pavel Machek
2019-05-24 18:32 ` [PATCH v14 2/3] dt-bindings: Add an entry for Purism SPC Angus Ainslie
2019-05-24 18:32   ` Angus Ainslie
2019-05-24 18:32 ` [PATCH v14 3/3] dt-bindings: arm: fsl: Add the imx8mq boards Angus Ainslie
2019-05-24 18:32   ` Angus Ainslie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190524204239.GA18646@amd \
    --to=pavel@ucw.cz \
    --cc=angus.ainslie@puri.sm \
    --cc=angus@akkea.ca \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.