From: Joerg Roedel <joro@8bytes.org>
To: Lukasz Odzioba <lukasz.odzioba@intel.com>
Cc: iommu@lists.linux-foundation.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] iommu/vt-d: Remove unnecessary rcu_read_locks
Date: Mon, 27 May 2019 16:05:15 +0200 [thread overview]
Message-ID: <20190527140514.GE8420@8bytes.org> (raw)
In-Reply-To: <1558359688-21804-1-git-send-email-lukasz.odzioba@intel.com>
On Mon, May 20, 2019 at 03:41:28PM +0200, Lukasz Odzioba wrote:
> We use RCU's for rarely updated lists like iommus, rmrr, atsr units.
>
> I'm not sure why domain_remove_dev_info() in domain_exit() was surrounded
> by rcu_read_lock. Lock was present before refactoring in d160aca527,
> but it was related to rcu list, not domain_remove_dev_info function.
>
> dmar_remove_one_dev_info() doesn't touch any of those lists, so it doesn't
> require a lock. In fact it is called 6 times without it anyway.
>
> Fixes: d160aca5276d ("iommu/vt-d: Unify domain->iommu attach/detachment")
>
> Signed-off-by: Lukasz Odzioba <lukasz.odzioba@intel.com>
Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Lukasz Odzioba <lukasz.odzioba@intel.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
dwmw2@infradead.org, grzegorz.andrejczuk@intel.com
Subject: Re: [PATCH 1/1] iommu/vt-d: Remove unnecessary rcu_read_locks
Date: Mon, 27 May 2019 16:05:15 +0200 [thread overview]
Message-ID: <20190527140514.GE8420@8bytes.org> (raw)
In-Reply-To: <1558359688-21804-1-git-send-email-lukasz.odzioba@intel.com>
On Mon, May 20, 2019 at 03:41:28PM +0200, Lukasz Odzioba wrote:
> We use RCU's for rarely updated lists like iommus, rmrr, atsr units.
>
> I'm not sure why domain_remove_dev_info() in domain_exit() was surrounded
> by rcu_read_lock. Lock was present before refactoring in d160aca527,
> but it was related to rcu list, not domain_remove_dev_info function.
>
> dmar_remove_one_dev_info() doesn't touch any of those lists, so it doesn't
> require a lock. In fact it is called 6 times without it anyway.
>
> Fixes: d160aca5276d ("iommu/vt-d: Unify domain->iommu attach/detachment")
>
> Signed-off-by: Lukasz Odzioba <lukasz.odzioba@intel.com>
Applied, thanks.
next prev parent reply other threads:[~2019-05-27 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 13:41 [PATCH 1/1] iommu/vt-d: Remove unnecessary rcu_read_locks Lukasz Odzioba
2019-05-20 13:41 ` Lukasz Odzioba
2019-05-27 14:05 ` Joerg Roedel [this message]
2019-05-27 14:05 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527140514.GE8420@8bytes.org \
--to=joro@8bytes.org \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.odzioba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.