From: Ezequiel Garcia <ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
To: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Hans Verkuil
<hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: Nicolas Dufresne
<nicolas.dufresne-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Jonas Karlman <jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org>,
Tomasz Figa <tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Boris Brezillon
<boris.brezillon-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org,
Ezequiel Garcia
<ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Subject: [PATCH v6 00/16] Add MPEG-2 decoding to Rockchip VPU
Date: Tue, 28 May 2019 14:02:16 -0300 [thread overview]
Message-ID: <20190528170232.2091-1-ezequiel@collabora.com> (raw)
This series introduces the decoding infrastructure that will be
used to add support for other codecs such as VP8, VP9 and H.264.
The driver is exposes two video device nodes, the encoder being
/dev/video0, and decoder /dev/video1. Both devices are associated
to a single memory-to-memory queue, and same media device /dev/media0.
This work has been possible thanks to Jonas Karlman, who did
the initial MPEG-2 decoding work and also got mpv+ffmpeg working using
the Request API.
Patchset applies cleanly on top of:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.3c
For those wanting to test, please find a branch here:
http://git.infradead.org/users/ezequielg/linux/shortlog/refs/heads/vpu-mpeg2-v6
Future plans
------------
Once this series is merged the plan is to rename the driver to Hantro
VPU, and add support to i.MX8, and then add VP8 and H264 decoding
support.
v6:
* Change fill_fmt() helpers to accept only user-defined sizeimage,
but not bytesperline.
* Add RK3328 support, contributed by Jonas Karlman.
v5:
* Add helper to clamp height/width based on frmsize
* Modify fill_fmt() helpers to keep user-defined sizeimage/bytesperline
when they're big enough
* Fixed a bunch of problems reported by Hans (see per-patch changelog
for more details)
v4:
* Fix issues in the probe/remove path preventing the driver from being
unloaded/reloaded (Jonas)
* Rework the media controller registration code to simplify the
error/remove path (Boris)
* Split the MPEG2 patches (one adding the generic code and one patch
per platform)
v3:
* Share more code between the encoder/decoder logic (VB2/V4L2
interface implementation)
* Add a patch to support MPEG2 decoding on RK3288 (Jonas)
* Several fixes/improvements all over the place (see changelog
in each patch for more details)
v2:
* Fixed some minor issues brought up by v4l2-compliance.
* Fixed bytesused wrongly assigned 0 on the MPEG-2 decoder.
* Addressed comments from Hans and Tomasz on the pixel format
helpers.
Boris Brezillon (8):
media: v4l2-common: Fix v4l2_fill_pixfmt[_mp]() prototypes
media: v4l2-common: Add an helper to apply frmsize constraints
media: v4l2-common: Support custom imagesize in fill_pixfmt()
rockchip/vpu: Use v4l2_apply_frmsize_constraints() where appropriate
rockchip/vpu: Rename rockchip_vpu_common.h into rockchip_vpu_v4l2.h
rockchip/vpu: Move encoder logic to a common place
rockchip/vpu: Provide a helper to reset both src and dst formats
rockchip/vpu: Prepare things to support decoders
Ezequiel Garcia (4):
rockchip/vpu: Open-code media controller register
rockchip/vpu: Support the Request API
rockchip/vpu: Add decoder boilerplate
rockchip/vpu: Add support for non-standard controls
Jonas Karlman (4):
rockchip/vpu: Add infra to support MPEG-2 decoding
rockchip/vpu: Add MPEG2 decoding support to RK3399
rockchip/vpu: Add support for MPEG-2 decoding on RK3288
rockchip/vpu: Add support for MPEG-2 decoding on RK3328
drivers/media/v4l2-core/v4l2-common.c | 90 ++-
drivers/staging/media/rockchip/vpu/Kconfig | 1 +
drivers/staging/media/rockchip/vpu/Makefile | 7 +-
.../media/rockchip/vpu/rk3288_vpu_hw.c | 59 +-
.../rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 2 +-
.../rockchip/vpu/rk3288_vpu_hw_mpeg2_dec.c | 261 +++++++
.../media/rockchip/vpu/rk3288_vpu_regs.h | 1 +
.../media/rockchip/vpu/rk3399_vpu_hw.c | 71 +-
.../rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c | 8 +-
.../rockchip/vpu/rk3399_vpu_hw_mpeg2_dec.c | 267 +++++++
.../staging/media/rockchip/vpu/rockchip_vpu.h | 110 ++-
.../media/rockchip/vpu/rockchip_vpu_drv.c | 466 ++++++++++--
.../media/rockchip/vpu/rockchip_vpu_enc.c | 571 ---------------
.../media/rockchip/vpu/rockchip_vpu_hw.h | 17 +
.../media/rockchip/vpu/rockchip_vpu_mpeg2.c | 61 ++
.../media/rockchip/vpu/rockchip_vpu_v4l2.c | 692 ++++++++++++++++++
...kchip_vpu_common.h => rockchip_vpu_v4l2.h} | 15 +-
include/media/v4l2-common.h | 10 +-
18 files changed, 2026 insertions(+), 683 deletions(-)
create mode 100644 drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_mpeg2_dec.c
create mode 100644 drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_mpeg2_dec.c
delete mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c
create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_mpeg2.c
create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c
rename drivers/staging/media/rockchip/vpu/{rockchip_vpu_common.h => rockchip_vpu_v4l2.h} (50%)
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@collabora.com>
To: linux-media@vger.kernel.org, Hans Verkuil <hans.verkuil@cisco.com>
Cc: kernel@collabora.com,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Tomasz Figa <tfiga@chromium.org>,
linux-rockchip@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>, Jonas Karlman <jonas@kwiboo.se>,
Philipp Zabel <p.zabel@pengutronix.de>,
Boris Brezillon <boris.brezillon@collabora.com>,
Ezequiel Garcia <ezequiel@collabora.com>
Subject: [PATCH v6 00/16] Add MPEG-2 decoding to Rockchip VPU
Date: Tue, 28 May 2019 14:02:16 -0300 [thread overview]
Message-ID: <20190528170232.2091-1-ezequiel@collabora.com> (raw)
This series introduces the decoding infrastructure that will be
used to add support for other codecs such as VP8, VP9 and H.264.
The driver is exposes two video device nodes, the encoder being
/dev/video0, and decoder /dev/video1. Both devices are associated
to a single memory-to-memory queue, and same media device /dev/media0.
This work has been possible thanks to Jonas Karlman, who did
the initial MPEG-2 decoding work and also got mpv+ffmpeg working using
the Request API.
Patchset applies cleanly on top of:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.3c
For those wanting to test, please find a branch here:
http://git.infradead.org/users/ezequielg/linux/shortlog/refs/heads/vpu-mpeg2-v6
Future plans
------------
Once this series is merged the plan is to rename the driver to Hantro
VPU, and add support to i.MX8, and then add VP8 and H264 decoding
support.
v6:
* Change fill_fmt() helpers to accept only user-defined sizeimage,
but not bytesperline.
* Add RK3328 support, contributed by Jonas Karlman.
v5:
* Add helper to clamp height/width based on frmsize
* Modify fill_fmt() helpers to keep user-defined sizeimage/bytesperline
when they're big enough
* Fixed a bunch of problems reported by Hans (see per-patch changelog
for more details)
v4:
* Fix issues in the probe/remove path preventing the driver from being
unloaded/reloaded (Jonas)
* Rework the media controller registration code to simplify the
error/remove path (Boris)
* Split the MPEG2 patches (one adding the generic code and one patch
per platform)
v3:
* Share more code between the encoder/decoder logic (VB2/V4L2
interface implementation)
* Add a patch to support MPEG2 decoding on RK3288 (Jonas)
* Several fixes/improvements all over the place (see changelog
in each patch for more details)
v2:
* Fixed some minor issues brought up by v4l2-compliance.
* Fixed bytesused wrongly assigned 0 on the MPEG-2 decoder.
* Addressed comments from Hans and Tomasz on the pixel format
helpers.
Boris Brezillon (8):
media: v4l2-common: Fix v4l2_fill_pixfmt[_mp]() prototypes
media: v4l2-common: Add an helper to apply frmsize constraints
media: v4l2-common: Support custom imagesize in fill_pixfmt()
rockchip/vpu: Use v4l2_apply_frmsize_constraints() where appropriate
rockchip/vpu: Rename rockchip_vpu_common.h into rockchip_vpu_v4l2.h
rockchip/vpu: Move encoder logic to a common place
rockchip/vpu: Provide a helper to reset both src and dst formats
rockchip/vpu: Prepare things to support decoders
Ezequiel Garcia (4):
rockchip/vpu: Open-code media controller register
rockchip/vpu: Support the Request API
rockchip/vpu: Add decoder boilerplate
rockchip/vpu: Add support for non-standard controls
Jonas Karlman (4):
rockchip/vpu: Add infra to support MPEG-2 decoding
rockchip/vpu: Add MPEG2 decoding support to RK3399
rockchip/vpu: Add support for MPEG-2 decoding on RK3288
rockchip/vpu: Add support for MPEG-2 decoding on RK3328
drivers/media/v4l2-core/v4l2-common.c | 90 ++-
drivers/staging/media/rockchip/vpu/Kconfig | 1 +
drivers/staging/media/rockchip/vpu/Makefile | 7 +-
.../media/rockchip/vpu/rk3288_vpu_hw.c | 59 +-
.../rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 2 +-
.../rockchip/vpu/rk3288_vpu_hw_mpeg2_dec.c | 261 +++++++
.../media/rockchip/vpu/rk3288_vpu_regs.h | 1 +
.../media/rockchip/vpu/rk3399_vpu_hw.c | 71 +-
.../rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c | 8 +-
.../rockchip/vpu/rk3399_vpu_hw_mpeg2_dec.c | 267 +++++++
.../staging/media/rockchip/vpu/rockchip_vpu.h | 110 ++-
.../media/rockchip/vpu/rockchip_vpu_drv.c | 466 ++++++++++--
.../media/rockchip/vpu/rockchip_vpu_enc.c | 571 ---------------
.../media/rockchip/vpu/rockchip_vpu_hw.h | 17 +
.../media/rockchip/vpu/rockchip_vpu_mpeg2.c | 61 ++
.../media/rockchip/vpu/rockchip_vpu_v4l2.c | 692 ++++++++++++++++++
...kchip_vpu_common.h => rockchip_vpu_v4l2.h} | 15 +-
include/media/v4l2-common.h | 10 +-
18 files changed, 2026 insertions(+), 683 deletions(-)
create mode 100644 drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_mpeg2_dec.c
create mode 100644 drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_mpeg2_dec.c
delete mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c
create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_mpeg2.c
create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c
rename drivers/staging/media/rockchip/vpu/{rockchip_vpu_common.h => rockchip_vpu_v4l2.h} (50%)
--
2.20.1
next reply other threads:[~2019-05-28 17:02 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 17:02 Ezequiel Garcia [this message]
2019-05-28 17:02 ` [PATCH v6 00/16] Add MPEG-2 decoding to Rockchip VPU Ezequiel Garcia
[not found] ` <20190528170232.2091-1-ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-05-28 17:02 ` [PATCH v6 01/16] media: v4l2-common: Fix v4l2_fill_pixfmt[_mp]() prototypes Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 02/16] media: v4l2-common: Add an helper to apply frmsize constraints Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 03/16] media: v4l2-common: Support custom imagesize in fill_pixfmt() Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
[not found] ` <20190528170232.2091-4-ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-05-29 11:28 ` Mauro Carvalho Chehab
2019-05-29 11:28 ` Mauro Carvalho Chehab
[not found] ` <20190529082809.0b9f3553-qA1ZUp+OV9c@public.gmane.org>
2019-05-29 11:43 ` Hans Verkuil
2019-05-29 11:43 ` Hans Verkuil
[not found] ` <cc51be76-81c3-1c54-2005-1b99d00a8ac1-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2019-05-29 11:58 ` Mauro Carvalho Chehab
2019-05-29 11:58 ` Mauro Carvalho Chehab
[not found] ` <20190529085854.6c689f8d-qA1ZUp+OV9c@public.gmane.org>
2019-05-29 12:16 ` Boris Brezillon
2019-05-29 12:16 ` Boris Brezillon
[not found] ` <20190529141633.19c5079b-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-05-29 12:26 ` Mauro Carvalho Chehab
2019-05-29 12:26 ` Mauro Carvalho Chehab
[not found] ` <20190529092632.779f5f1b-qA1ZUp+OV9c@public.gmane.org>
2019-05-29 12:29 ` Mauro Carvalho Chehab
2019-05-29 12:29 ` Mauro Carvalho Chehab
2019-05-29 12:31 ` Boris Brezillon
2019-05-29 12:31 ` Boris Brezillon
2019-05-29 12:31 ` Hans Verkuil
2019-05-29 12:31 ` Hans Verkuil
[not found] ` <223a757d-f008-398c-64ce-18b0aaf390c5-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2019-05-29 12:39 ` Boris Brezillon
2019-05-29 12:39 ` Boris Brezillon
2019-05-29 14:04 ` Ezequiel Garcia
2019-05-29 14:04 ` Ezequiel Garcia
[not found] ` <04cb574b530c987a04b098962c93940c49e944d8.camel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-05-29 14:06 ` Boris Brezillon
2019-05-29 14:06 ` Boris Brezillon
[not found] ` <20190529160610.169c6e00-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-05-29 14:17 ` Boris Brezillon
2019-05-29 14:17 ` Boris Brezillon
[not found] ` <20190529161753.7ffa5276-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-05-29 14:47 ` Ezequiel Garcia
2019-05-29 14:47 ` Ezequiel Garcia
2019-05-29 13:54 ` Nicolas Dufresne
2019-05-29 13:54 ` Nicolas Dufresne
[not found] ` <4ef64e22f4035fccf09fbb7f0be04a9778b1230d.camel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-05-29 14:02 ` Mauro Carvalho Chehab
2019-05-29 14:02 ` Mauro Carvalho Chehab
2019-05-28 17:02 ` [PATCH v6 04/16] rockchip/vpu: Use v4l2_apply_frmsize_constraints() where appropriate Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 05/16] rockchip/vpu: Open-code media controller register Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 06/16] rockchip/vpu: Support the Request API Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 07/16] rockchip/vpu: Rename rockchip_vpu_common.h into rockchip_vpu_v4l2.h Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 08/16] rockchip/vpu: Move encoder logic to a common place Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 09/16] rockchip/vpu: Provide a helper to reset both src and dst formats Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 10/16] rockchip/vpu: Prepare things to support decoders Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 11/16] rockchip/vpu: Add decoder boilerplate Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 12/16] rockchip/vpu: Add support for non-standard controls Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 13/16] rockchip/vpu: Add infra to support MPEG-2 decoding Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 14/16] rockchip/vpu: Add MPEG2 decoding support to RK3399 Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 15/16] rockchip/vpu: Add support for MPEG-2 decoding on RK3288 Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
2019-05-28 17:02 ` [PATCH v6 16/16] rockchip/vpu: Add support for MPEG-2 decoding on RK3328 Ezequiel Garcia
2019-05-28 17:02 ` Ezequiel Garcia
[not found] ` <20190528170232.2091-17-ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-05-29 8:11 ` Hans Verkuil
2019-05-29 8:11 ` Hans Verkuil
[not found] ` <2ef056a2-e9dc-52b1-855b-2bef759af9b6-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2019-05-29 8:50 ` Jonas Karlman
2019-05-29 8:50 ` Jonas Karlman
[not found] ` <VI1PR03MB42066B8C9F364ACF7CFFF241AC1F0-269e4kb9IIlWSsgAM8bhN8eAHadYHfrlvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-05-29 9:00 ` Hans Verkuil
2019-05-29 9:00 ` Hans Verkuil
2019-05-29 14:59 ` Ezequiel Garcia
2019-05-29 14:59 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528170232.2091-1-ezequiel@collabora.com \
--to=ezequiel-zgy8ohtn/8qb+jhodadfcq@public.gmane.org \
--cc=boris.brezillon-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=jonas-uIzNG4q0ceqzQB+pC5nmwQ@public.gmane.org \
--cc=kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=nicolas.dufresne-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.