From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V3 01/10] arch/csky: Use VDSP instead of DSP
Date: Wed, 29 May 2019 09:21:28 +0200 [thread overview]
Message-ID: <20190529092128.36183371@windsurf.home> (raw)
In-Reply-To: <1559114328-23357-2-git-send-email-guoren@kernel.org>
Hello Guo,
Thanks for this new iteration. I apologize, but unfortunately it's
still not good, and doesn't match the suggestions I did.
On Wed, 29 May 2019 15:18:39 +0800
guoren at kernel.org wrote:
> From: Guo Ren <ren_guo@c-sky.com>
>
> Use VDSP enhanced instructions Co-processor instead of DSP.
Your commit log should explain why.
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> ---
> arch/Config.in.csky | 17 +++--------------
> arch/arch.mk.csky | 24 ++++++++++++++++++++++++
The change to using arch.mk.csky should be done separately. So this
commit should be split into two:
- One switching to using arch.mk.sky, without changing DSP -> VDSP
- A follow-up one changing DSP -> VDSP, with a commit log that
explains why you make this chang
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: guoren@kernel.org
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
arnout@mind.be, linux-csky@vger.kernel.org,
buildroot@buildroot.org, Guo Ren <ren_guo@c-sky.com>
Subject: Re: [PATCH V3 01/10] arch/csky: Use VDSP instead of DSP
Date: Wed, 29 May 2019 09:21:28 +0200 [thread overview]
Message-ID: <20190529092128.36183371@windsurf.home> (raw)
In-Reply-To: <1559114328-23357-2-git-send-email-guoren@kernel.org>
Hello Guo,
Thanks for this new iteration. I apologize, but unfortunately it's
still not good, and doesn't match the suggestions I did.
On Wed, 29 May 2019 15:18:39 +0800
guoren@kernel.org wrote:
> From: Guo Ren <ren_guo@c-sky.com>
>
> Use VDSP enhanced instructions Co-processor instead of DSP.
Your commit log should explain why.
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> ---
> arch/Config.in.csky | 17 +++--------------
> arch/arch.mk.csky | 24 ++++++++++++++++++++++++
The change to using arch.mk.csky should be done separately. So this
commit should be split into two:
- One switching to using arch.mk.sky, without changing DSP -> VDSP
- A follow-up one changing DSP -> VDSP, with a commit log that
explains why you make this chang
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-05-29 7:21 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 7:18 [Buildroot] [PATCH V3 00/10] Update arch/csky for buildroot guoren at kernel.org
2019-05-29 7:18 ` guoren
2019-05-29 7:18 ` [Buildroot] [PATCH V3 01/10] arch/csky: Use VDSP instead of DSP guoren at kernel.org
2019-05-29 7:18 ` guoren
2019-05-29 7:21 ` Thomas Petazzoni [this message]
2019-05-29 7:21 ` Thomas Petazzoni
2019-05-29 7:30 ` [Buildroot] " Guo Ren
2019-05-29 7:30 ` Guo Ren
2019-05-29 7:56 ` [Buildroot] " Thomas Petazzoni
2019-05-29 7:56 ` Thomas Petazzoni
2019-05-29 8:12 ` [Buildroot] " Guo Ren
2019-05-29 8:12 ` Guo Ren
2019-05-29 8:38 ` [Buildroot] " Thomas Petazzoni
2019-05-29 8:38 ` Thomas Petazzoni
2019-05-29 9:02 ` [Buildroot] " Guo Ren
2019-05-29 9:02 ` Guo Ren
2019-05-29 9:06 ` [Buildroot] " Guo Ren
2019-05-29 9:06 ` Guo Ren
2019-05-29 9:23 ` [Buildroot] " Thomas Petazzoni
2019-05-29 9:23 ` Thomas Petazzoni
2019-05-29 9:45 ` [Buildroot] " Guo Ren
2019-05-29 9:45 ` Guo Ren
2019-05-29 11:58 ` [Buildroot] " Thomas Petazzoni
2019-05-29 11:58 ` Thomas Petazzoni
2019-05-29 12:34 ` [Buildroot] " Guo Ren
2019-05-29 12:34 ` Guo Ren
2019-05-29 7:18 ` [Buildroot] [PATCH V3 02/10] arch/csky: Add ck860 supported guoren at kernel.org
2019-05-29 7:18 ` guoren
2019-05-29 7:18 ` [Buildroot] [PATCH V3 03/10] arch/csky: Add FLOAT_ABI compiler options guoren at kernel.org
2019-05-29 7:18 ` guoren
2019-05-29 7:23 ` [Buildroot] " Thomas Petazzoni
2019-05-29 7:23 ` Thomas Petazzoni
2019-05-29 7:30 ` [Buildroot] " Guo Ren
2019-05-29 7:30 ` Guo Ren
2019-05-29 7:57 ` [Buildroot] " Thomas Petazzoni
2019-05-29 7:57 ` Thomas Petazzoni
2019-05-29 8:30 ` [Buildroot] " Guo Ren
2019-05-29 8:30 ` Guo Ren
2019-05-29 8:39 ` [Buildroot] " Thomas Petazzoni
2019-05-29 8:39 ` Thomas Petazzoni
2019-05-29 8:53 ` [Buildroot] " Guo Ren
2019-05-29 8:53 ` Guo Ren
2019-05-29 7:39 ` [Buildroot] " Guo Ren
2019-05-29 7:39 ` Guo Ren
2019-05-29 7:18 ` [Buildroot] [PATCH V3 04/10] arch/csky: Add ABI variable for toolchain build guoren at kernel.org
2019-05-29 7:18 ` guoren
2019-05-29 7:18 ` [Buildroot] [PATCH V3 05/10] package/binutils: Add C-SKY support guoren at kernel.org
2019-05-29 7:18 ` guoren
2019-05-29 7:18 ` [Buildroot] [PATCH V3 06/10] package/gcc: " guoren at kernel.org
2019-05-29 7:18 ` guoren
2019-05-29 7:18 ` [Buildroot] [PATCH V3 07/10] package/gdb: " guoren at kernel.org
2019-05-29 7:18 ` guoren
2019-05-29 7:18 ` [Buildroot] [PATCH V3 08/10] package/glibc: " guoren at kernel.org
2019-05-29 7:18 ` guoren
2019-05-29 7:18 ` [Buildroot] [PATCH V3 09/10] configs/qemu_cskyXXX_virt: new defconfig guoren at kernel.org
2019-05-29 7:18 ` guoren
2019-05-29 7:18 ` [Buildroot] [PATCH V3 10/10] arch/csky: Enable csky toolchain build guoren at kernel.org
2019-05-29 7:18 ` guoren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529092128.36183371@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.