All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: selftest_lrc: Check the correct variable
@ 2019-05-29 11:03 ` Dan Carpenter
  0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2019-05-29 11:03 UTC (permalink / raw)
  To: Jani Nikula, Chris Wilson
  Cc: kernel-janitors, David Airlie, intel-gfx, dri-devel

We should check "request[n]" instead of just "request".

Fixes: 78e41ddd2198 ("drm/i915: Apply an execution_mask to the virtual_engine")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/i915/gt/selftest_lrc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index a8c50900e2d4..13674f836955 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -1526,8 +1526,8 @@ static int mask_virtual_engine(struct drm_i915_private *i915,
 
 	for (n = 0; n < nsibling; n++) {
 		request[n] = i915_request_create(ve);
-		if (IS_ERR(request)) {
-			err = PTR_ERR(request);
+		if (IS_ERR(request[n])) {
+			err = PTR_ERR(request[n]);
 			nsibling = n;
 			goto out;
 		}
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] drm/i915: selftest_lrc: Check the correct variable
@ 2019-05-29 11:03 ` Dan Carpenter
  0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2019-05-29 11:03 UTC (permalink / raw)
  To: Jani Nikula, Chris Wilson
  Cc: kernel-janitors, David Airlie, intel-gfx, dri-devel

We should check "request[n]" instead of just "request".

Fixes: 78e41ddd2198 ("drm/i915: Apply an execution_mask to the virtual_engine")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/i915/gt/selftest_lrc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index a8c50900e2d4..13674f836955 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -1526,8 +1526,8 @@ static int mask_virtual_engine(struct drm_i915_private *i915,
 
 	for (n = 0; n < nsibling; n++) {
 		request[n] = i915_request_create(ve);
-		if (IS_ERR(request)) {
-			err = PTR_ERR(request);
+		if (IS_ERR(request[n])) {
+			err = PTR_ERR(request[n]);
 			nsibling = n;
 			goto out;
 		}
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: selftest_lrc: Check the correct variable
  2019-05-29 11:03 ` Dan Carpenter
@ 2019-05-29 11:06   ` Chris Wilson
  -1 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2019-05-29 11:06 UTC (permalink / raw)
  To: Dan Carpenter, Jani Nikula
  Cc: kernel-janitors, Tvrtko Ursulin, David Airlie, Mika Kuoppala,
	intel-gfx, Matthew Auld, dri-devel, Rodrigo Vivi

Quoting Dan Carpenter (2019-05-29 12:03:55)
> We should check "request[n]" instead of just "request".
> 
> Fixes: 78e41ddd2198 ("drm/i915: Apply an execution_mask to the virtual_engine")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Oops.
Reviewd-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: selftest_lrc: Check the correct variable
@ 2019-05-29 11:06   ` Chris Wilson
  0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2019-05-29 11:06 UTC (permalink / raw)
  To: Dan Carpenter, Jani Nikula
  Cc: kernel-janitors, Tvrtko Ursulin, David Airlie, Mika Kuoppala,
	intel-gfx, Matthew Auld, dri-devel, Rodrigo Vivi

Quoting Dan Carpenter (2019-05-29 12:03:55)
> We should check "request[n]" instead of just "request".
> 
> Fixes: 78e41ddd2198 ("drm/i915: Apply an execution_mask to the virtual_engine")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Oops.
Reviewd-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: selftest_lrc: Check the correct variable
  2019-05-29 11:06   ` Chris Wilson
@ 2019-05-29 12:28     ` Chris Wilson
  -1 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2019-05-29 12:28 UTC (permalink / raw)
  To: Dan Carpenter, Jani Nikula
  Cc: kernel-janitors, David Airlie, intel-gfx, dri-devel

Quoting Chris Wilson (2019-05-29 12:06:57)
> Quoting Dan Carpenter (2019-05-29 12:03:55)
> > We should check "request[n]" instead of just "request".
> > 
> > Fixes: 78e41ddd2198 ("drm/i915: Apply an execution_mask to the virtual_engine")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Oops.
> Reviewd-by: Chris Wilson <chris@chris-wilson.co.uk>

s/Reviewd/Reviewed/
And pushed, thanks for the fix.
-Chris

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: selftest_lrc: Check the correct variable
@ 2019-05-29 12:28     ` Chris Wilson
  0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2019-05-29 12:28 UTC (permalink / raw)
  To: Dan Carpenter, Jani Nikula
  Cc: kernel-janitors, David Airlie, intel-gfx, dri-devel

Quoting Chris Wilson (2019-05-29 12:06:57)
> Quoting Dan Carpenter (2019-05-29 12:03:55)
> > We should check "request[n]" instead of just "request".
> > 
> > Fixes: 78e41ddd2198 ("drm/i915: Apply an execution_mask to the virtual_engine")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Oops.
> Reviewd-by: Chris Wilson <chris@chris-wilson.co.uk>

s/Reviewd/Reviewed/
And pushed, thanks for the fix.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: selftest_lrc: Check the correct variable
  2019-05-29 11:03 ` Dan Carpenter
  (?)
  (?)
@ 2019-05-29 15:33 ` Patchwork
  -1 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-05-29 15:33 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: selftest_lrc: Check the correct variable
URL   : https://patchwork.freedesktop.org/series/61312/
State : failure

== Summary ==

Applying: drm/i915: selftest_lrc: Check the correct variable
Using index info to reconstruct a base tree...
M	drivers/gpu/drm/i915/gt/selftest_lrc.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/i915/gt/selftest_lrc.c
No changes -- Patch already applied.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-05-29 15:33 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-29 11:03 [PATCH] drm/i915: selftest_lrc: Check the correct variable Dan Carpenter
2019-05-29 11:03 ` Dan Carpenter
2019-05-29 11:06 ` Chris Wilson
2019-05-29 11:06   ` Chris Wilson
2019-05-29 12:28   ` Chris Wilson
2019-05-29 12:28     ` Chris Wilson
2019-05-29 15:33 ` ✗ Fi.CI.BAT: failure for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.