All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Gen Zhang <blackgod016574@gmail.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
	dm-devel@redhat.com, agk@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: dm-init: fix 2 incorrect use of kstrndup()
Date: Thu, 30 May 2019 12:11:03 -0400	[thread overview]
Message-ID: <20190530161103.GA30026@redhat.com> (raw)
In-Reply-To: <20190529152443.GA4076@zhanggen-UX430UQ>

On Wed, May 29 2019 at 11:24am -0400,
Gen Zhang <blackgod016574@gmail.com> wrote:

> On Wed, May 29, 2019 at 05:23:53AM -0700, Bart Van Assche wrote:
> > On 5/28/19 6:33 PM, Gen Zhang wrote:
> > > In drivers/md/dm-init.c, kstrndup() is incorrectly used twice.
> > > 
> > > It should be: char *kstrndup(const char *s, size_t max, gfp_t gfp);
> > 
> > Should the following be added to this patch?
> > 
> > Fixes: 6bbc923dfcf5 ("dm: add support to directly boot to a mapped
> > device") # v5.1.
> > Cc: stable
> > 
> > Thanks,
> > 
> > Bart.
> Personally, I am not quite sure about this question, because I am not 
> the maintainer of this part.

Yes, it should have the tags Bart suggested.

I'll take care it.

Thanks,
Mike

  reply	other threads:[~2019-05-30 16:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29  1:33 [PATCH] dm-init: fix 2 incorrect use of kstrndup() Gen Zhang
2019-05-29 12:23 ` [dm-devel] " Bart Van Assche
2019-05-29 15:24   ` Gen Zhang
2019-05-30 16:11     ` Mike Snitzer [this message]
2019-05-31  0:44       ` Gen Zhang
2019-06-06  9:27       ` Gen Zhang
2019-06-17  9:27         ` Gen Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190530161103.GA30026@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=blackgod016574@gmail.com \
    --cc=bvanassche@acm.org \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.