From: Alexey Dobriyan <adobriyan@gmail.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] add typeof_member() macro
Date: Thu, 30 May 2019 22:57:25 +0300 [thread overview]
Message-ID: <20190530195724.GA2870@avx2> (raw)
In-Reply-To: <a32bb1376821422fa3c647c01f3f1a95@AcuMS.aculab.com>
On Thu, May 30, 2019 at 11:37:42AM +0000, David Laight wrote:
> From: Alexey Dobriyan
> > +#define typeof_member(T, m) typeof(((T*)0)->m)
>
> Should probably be 't' (not 'T') and upper case ?
T comes from C++ where they uppercase types in template arguments.
It makes sense as types stand out sligthly around lowercase identifiers.
> Hmmm.... the #define is longer that what it expands to ...
It hides cast of 0 which is implementation detail :^)
Proper syntax would be
typeof(struct foo::bar)
but one can only dream.
prev parent reply other threads:[~2019-05-30 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 19:07 [PATCH 1/2] add typeof_member() macro Alexey Dobriyan
2019-05-29 19:11 ` [PATCH 2/2] proc: use " Alexey Dobriyan
2019-05-29 22:33 ` Andrew Morton
2019-05-30 11:37 ` [PATCH 1/2] add " David Laight
2019-05-30 11:53 ` Joe Perches
2019-05-30 19:57 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530195724.GA2870@avx2 \
--to=adobriyan@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.