From: Oleg Nesterov <oleg@redhat.com>
To: Jann Horn <jannh@google.com>
Cc: "Eric W . Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
David Howells <dhowells@redhat.com>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ptrace: restore smp_rmb() in __ptrace_may_access()
Date: Fri, 31 May 2019 15:35:36 +0200 [thread overview]
Message-ID: <20190531133535.GB31323@redhat.com> (raw)
In-Reply-To: <CAG48ez0ivQ+gfwKMife-3ZwBuqAuc1BhDGW3dtYTHMq0sByuNw@mail.gmail.com>
On 05/31, Jann Horn wrote:
>
> So I guess I should make a v2 that still adds the smp_rmb() in
> __ptrace_may_access(), but gets rid of the smp_wmb() in
> commit_creds()? (With a comment above the rcu_assign_pointer() that
> explains the ordering?)
I am fine either way, whatever you like more.
If you prefer v1 (this patch), feel free to add
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2019-05-31 13:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 11:31 [PATCH] ptrace: restore smp_rmb() in __ptrace_may_access() Jann Horn
2019-05-29 15:59 ` Eric W. Biederman
2019-05-29 16:01 ` Jann Horn
2019-05-29 16:21 ` Oleg Nesterov
2019-05-29 17:38 ` Jann Horn
2019-05-30 1:41 ` Eric W. Biederman
2019-05-31 15:04 ` Jann Horn
2019-05-30 10:34 ` Andrea Parri
2019-05-31 9:08 ` Peter Zijlstra
2019-05-30 12:05 ` Oleg Nesterov
2019-05-31 9:12 ` Peter Zijlstra
2019-05-31 9:55 ` Oleg Nesterov
2019-05-29 21:02 ` Jann Horn
2019-05-29 18:55 ` Kees Cook
2019-05-30 12:34 ` Oleg Nesterov
2019-05-31 11:56 ` Jann Horn
2019-05-31 13:35 ` Oleg Nesterov [this message]
2019-05-31 19:37 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531133535.GB31323@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.