From: ebiederm@xmission.com (Eric W. Biederman)
To: Jann Horn <jannh@google.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
David Howells <dhowells@redhat.com>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ptrace: restore smp_rmb() in __ptrace_may_access()
Date: Wed, 29 May 2019 20:41:55 -0500 [thread overview]
Message-ID: <87ef4gzpjw.fsf@xmission.com> (raw)
In-Reply-To: <CAG48ez3S1c_cd8RNSb9TrF66d+1AMAxD4zh-kixQ6uSEnmS-tg@mail.gmail.com> (Jann Horn's message of "Wed, 29 May 2019 19:38:46 +0200")
Jann Horn <jannh@google.com> writes:
> I'm actually trying to get rid of the ->mm access in
> __ptrace_may_access() entirely by moving the dumpability and the
> user_ns into the signal_struct, but I don't have patches for that
> ready (yet).
Do you have a plan for dealing with old linux-threads style threads
where you have two processes that share the same mm, but have different
signal_structs.
I don't think it is required to share any other structures except
mm_struct when you share mm_struct. Maybe sighand_struct.
Not to derail your idea. Only needing to look at signal_struct sounds
very nice. I just know we have some other somewhat bizarre cases the
kernel still supports.
Eric
next prev parent reply other threads:[~2019-05-30 1:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 11:31 [PATCH] ptrace: restore smp_rmb() in __ptrace_may_access() Jann Horn
2019-05-29 15:59 ` Eric W. Biederman
2019-05-29 16:01 ` Jann Horn
2019-05-29 16:21 ` Oleg Nesterov
2019-05-29 17:38 ` Jann Horn
2019-05-30 1:41 ` Eric W. Biederman [this message]
2019-05-31 15:04 ` Jann Horn
2019-05-30 10:34 ` Andrea Parri
2019-05-31 9:08 ` Peter Zijlstra
2019-05-30 12:05 ` Oleg Nesterov
2019-05-31 9:12 ` Peter Zijlstra
2019-05-31 9:55 ` Oleg Nesterov
2019-05-29 21:02 ` Jann Horn
2019-05-29 18:55 ` Kees Cook
2019-05-30 12:34 ` Oleg Nesterov
2019-05-31 11:56 ` Jann Horn
2019-05-31 13:35 ` Oleg Nesterov
2019-05-31 19:37 ` Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef4gzpjw.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.