From: Eduardo Habkost <ehabkost@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
Igor Mammedov <imammedo@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-arm] [PATCH v4] numa: improve cpu hotplug error message with a wrong node-id
Date: Fri, 31 May 2019 16:49:44 -0300 [thread overview]
Message-ID: <20190531194944.GL22103@habkost.net> (raw)
In-Reply-To: <20190529160747.778-1-lvivier@redhat.com>
On Wed, May 29, 2019 at 06:07:47PM +0200, Laurent Vivier wrote:
> On pseries, core-ids are strongly binded to a node-id by the command
> line option. If an user tries to add a CPU to the wrong node, he has
> an error but it is not really helpful:
>
> qemu-system-ppc64 ... -smp 1,maxcpus=64,cores=1,threads=1,sockets=1 \
> -numa node,nodeid=0 -numa node,nodeid=1 ...
>
> (qemu) device_add power9_v2.0-spapr-cpu-core,core-id=30,node-id=1
> Error: node-id=1 must match numa node specified with -numa option
>
> This patch improves this error message by giving to the user the good
> node-id to use with the core-id he's providing
>
> Error: invalid node-id, must be 0
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Queued, thanks.
--
Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
Igor Mammedov <imammedo@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH v4] numa: improve cpu hotplug error message with a wrong node-id
Date: Fri, 31 May 2019 16:49:44 -0300 [thread overview]
Message-ID: <20190531194944.GL22103@habkost.net> (raw)
In-Reply-To: <20190529160747.778-1-lvivier@redhat.com>
On Wed, May 29, 2019 at 06:07:47PM +0200, Laurent Vivier wrote:
> On pseries, core-ids are strongly binded to a node-id by the command
> line option. If an user tries to add a CPU to the wrong node, he has
> an error but it is not really helpful:
>
> qemu-system-ppc64 ... -smp 1,maxcpus=64,cores=1,threads=1,sockets=1 \
> -numa node,nodeid=0 -numa node,nodeid=1 ...
>
> (qemu) device_add power9_v2.0-spapr-cpu-core,core-id=30,node-id=1
> Error: node-id=1 must match numa node specified with -numa option
>
> This patch improves this error message by giving to the user the good
> node-id to use with the core-id he's providing
>
> Error: invalid node-id, must be 0
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Queued, thanks.
--
Eduardo
next prev parent reply other threads:[~2019-05-31 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 16:07 [Qemu-arm] [PATCH v4] numa: improve cpu hotplug error message with a wrong node-id Laurent Vivier
2019-05-29 16:07 ` [Qemu-devel] " Laurent Vivier
2019-05-30 9:00 ` [Qemu-arm] " Igor Mammedov
2019-05-30 9:00 ` Igor Mammedov
2019-05-31 19:49 ` Eduardo Habkost [this message]
2019-05-31 19:49 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531194944.GL22103@habkost.net \
--to=ehabkost@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.