* [PATCH] lrzsz: Add implicit declaration fixes from Debian
@ 2019-06-01 21:58 Adrian Bunk
2019-06-02 10:36 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2019-06-01 21:58 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
.../lrzsz/lrzsz-0.12.20/include.patch | 23 +++++++++++++++++++
meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb | 1 +
2 files changed, 24 insertions(+)
create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
diff --git a/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
new file mode 100644
index 0000000000..3925fc8c86
--- /dev/null
+++ b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
@@ -0,0 +1,23 @@
+Signed-off-by: Adrian Bunk <bunk@stusta.de>
+Upstream-Status: Inappropriate [upstream is dead]
+
+--- lrzsz-0.12.21.orig/lib/long-options.c
++++ lrzsz-0.12.21/lib/long-options.c
+@@ -22,6 +22,7 @@
+ #endif
+
+ #include <stdio.h>
++#include <stdlib.h>
+ #include <getopt.h>
+ #include "long-options.h"
+
+--- lrzsz-0.12.21.orig/src/lsyslog.c
++++ lrzsz-0.12.21/src/lsyslog.c
+@@ -22,6 +22,7 @@
+ #ifdef ENABLE_SYSLOG
+ #include "zglobal.h"
+ #include <pwd.h>
++#include <stdio.h>
+ #include <stdlib.h>
+ #include <string.h>
+ #endif
diff --git a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
index 002c774c6d..34556b2c29 100644
--- a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
+++ b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
@@ -20,6 +20,7 @@ SRC_URI = "http://www.ohse.de/uwe/releases/lrzsz-${PV}.tar.gz \
file://lrzsz_fix_for_automake-1.12.patch \
file://lrzsz-check-locale.h.patch \
file://cve-2018-10195.patch \
+ file://include.patch \
"
SRC_URI[md5sum] = "b5ce6a74abc9b9eb2af94dffdfd372a4"
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] lrzsz: Add implicit declaration fixes from Debian
2019-06-01 21:58 [PATCH] lrzsz: Add implicit declaration fixes from Debian Adrian Bunk
@ 2019-06-02 10:36 ` Richard Purdie
2019-06-03 6:47 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2019-06-02 10:36 UTC (permalink / raw)
To: Adrian Bunk, openembedded-core
On Sun, 2019-06-02 at 00:58 +0300, Adrian Bunk wrote:
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> ---
> .../lrzsz/lrzsz-0.12.20/include.patch | 23
> +++++++++++++++++++
> meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb | 1 +
> 2 files changed, 24 insertions(+)
> create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-
> 0.12.20/include.patch
>
> diff --git a/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
> b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
> new file mode 100644
> index 0000000000..3925fc8c86
> --- /dev/null
> +++ b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
> @@ -0,0 +1,23 @@
> +Signed-off-by: Adrian Bunk <bunk@stusta.de>
> +Upstream-Status: Inappropriate [upstream is dead]
Could you put at least something in the patch header to say what the
patch does please?
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] lrzsz: Add implicit declaration fixes from Debian
2019-06-02 10:36 ` Richard Purdie
@ 2019-06-03 6:47 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2019-06-03 6:47 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On Sun, Jun 02, 2019 at 11:36:51AM +0100, Richard Purdie wrote:
>
> Could you put at least something in the patch header to say what the
> patch does please?
Added in v2.
> Cheers,
>
> Richard
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] lrzsz: Add implicit declaration fixes from Debian
@ 2019-06-03 6:47 Adrian Bunk
2019-06-05 8:18 ` Martin Jansa
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2019-06-03 6:47 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--
v2: Add comment in the patch header.
---
.../lrzsz/lrzsz-0.12.20/include.patch | 25 +++++++++++++++++++
meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb | 1 +
2 files changed, 26 insertions(+)
create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
diff --git a/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
new file mode 100644
index 0000000000..5fcb3aa92b
--- /dev/null
+++ b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
@@ -0,0 +1,25 @@
+Implicit declaration compile warning fixes from Debian
+
+Signed-off-by: Adrian Bunk <bunk@stusta.de>
+Upstream-Status: Inappropriate [upstream is dead]
+
+--- lrzsz-0.12.21.orig/lib/long-options.c
++++ lrzsz-0.12.21/lib/long-options.c
+@@ -22,6 +22,7 @@
+ #endif
+
+ #include <stdio.h>
++#include <stdlib.h>
+ #include <getopt.h>
+ #include "long-options.h"
+
+--- lrzsz-0.12.21.orig/src/lsyslog.c
++++ lrzsz-0.12.21/src/lsyslog.c
+@@ -22,6 +22,7 @@
+ #ifdef ENABLE_SYSLOG
+ #include "zglobal.h"
+ #include <pwd.h>
++#include <stdio.h>
+ #include <stdlib.h>
+ #include <string.h>
+ #endif
diff --git a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
index 002c774c6d..34556b2c29 100644
--- a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
+++ b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
@@ -20,6 +20,7 @@ SRC_URI = "http://www.ohse.de/uwe/releases/lrzsz-${PV}.tar.gz \
file://lrzsz_fix_for_automake-1.12.patch \
file://lrzsz-check-locale.h.patch \
file://cve-2018-10195.patch \
+ file://include.patch \
"
SRC_URI[md5sum] = "b5ce6a74abc9b9eb2af94dffdfd372a4"
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] lrzsz: Add implicit declaration fixes from Debian
2019-06-03 6:47 Adrian Bunk
@ 2019-06-05 8:18 ` Martin Jansa
2019-06-05 9:29 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2019-06-05 8:18 UTC (permalink / raw)
To: Adrian Bunk; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2584 bytes --]
On Mon, Jun 03, 2019 at 09:47:02AM +0300, Adrian Bunk wrote:
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> --
You need one more dash here, now this v2 comment ended in final commit message
which I believe wasn't the intention.
http://git.openembedded.org/openembedded-core/commit/?id=6fa60ac102f6d3977df4236bd5a22680298bdac2
the same with tcp-wrappers change:
http://git.openembedded.org/openembedded-core/commit/?id=cd1dc2334fd3e3d1db9be1d26e888051e3f59c5a
> v2: Add comment in the patch header.
> ---
> .../lrzsz/lrzsz-0.12.20/include.patch | 25 +++++++++++++++++++
> meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb | 1 +
> 2 files changed, 26 insertions(+)
> create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
>
> diff --git a/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
> new file mode 100644
> index 0000000000..5fcb3aa92b
> --- /dev/null
> +++ b/meta/recipes-bsp/lrzsz/lrzsz-0.12.20/include.patch
> @@ -0,0 +1,25 @@
> +Implicit declaration compile warning fixes from Debian
> +
> +Signed-off-by: Adrian Bunk <bunk@stusta.de>
> +Upstream-Status: Inappropriate [upstream is dead]
> +
> +--- lrzsz-0.12.21.orig/lib/long-options.c
> ++++ lrzsz-0.12.21/lib/long-options.c
> +@@ -22,6 +22,7 @@
> + #endif
> +
> + #include <stdio.h>
> ++#include <stdlib.h>
> + #include <getopt.h>
> + #include "long-options.h"
> +
> +--- lrzsz-0.12.21.orig/src/lsyslog.c
> ++++ lrzsz-0.12.21/src/lsyslog.c
> +@@ -22,6 +22,7 @@
> + #ifdef ENABLE_SYSLOG
> + #include "zglobal.h"
> + #include <pwd.h>
> ++#include <stdio.h>
> + #include <stdlib.h>
> + #include <string.h>
> + #endif
> diff --git a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
> index 002c774c6d..34556b2c29 100644
> --- a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
> +++ b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb
> @@ -20,6 +20,7 @@ SRC_URI = "http://www.ohse.de/uwe/releases/lrzsz-${PV}.tar.gz \
> file://lrzsz_fix_for_automake-1.12.patch \
> file://lrzsz-check-locale.h.patch \
> file://cve-2018-10195.patch \
> + file://include.patch \
> "
>
> SRC_URI[md5sum] = "b5ce6a74abc9b9eb2af94dffdfd372a4"
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] lrzsz: Add implicit declaration fixes from Debian
2019-06-05 8:18 ` Martin Jansa
@ 2019-06-05 9:29 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2019-06-05 9:29 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-core
On Wed, Jun 05, 2019 at 10:18:31AM +0200, Martin Jansa wrote:
> On Mon, Jun 03, 2019 at 09:47:02AM +0300, Adrian Bunk wrote:
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > --
>
> You need one more dash here, now this v2 comment ended in final commit message
> which I believe wasn't the intention.
>
> http://git.openembedded.org/openembedded-core/commit/?id=6fa60ac102f6d3977df4236bd5a22680298bdac2
>
> the same with tcp-wrappers change:
> http://git.openembedded.org/openembedded-core/commit/?id=cd1dc2334fd3e3d1db9be1d26e888051e3f59c5a
>...
Yes thanks, I already noticed my mistake.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-05 9:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-01 21:58 [PATCH] lrzsz: Add implicit declaration fixes from Debian Adrian Bunk
2019-06-02 10:36 ` Richard Purdie
2019-06-03 6:47 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2019-06-03 6:47 Adrian Bunk
2019-06-05 8:18 ` Martin Jansa
2019-06-05 9:29 ` Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.