* [PATCH v2] mfd: madera: Add missing of table registration
@ 2019-05-11 10:03 ` Daniel Gomez
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Gomez @ 2019-05-11 10:03 UTC (permalink / raw)
To: Charles Keepax, Richard Fitzgerald, Lee Jones
Cc: dagmcr, javier, moderated list:CIRRUS LOGIC MADERA CODEC DRIVERS,
open list:CIRRUS LOGIC MADERA CODEC DRIVERS, open list
MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
OF mathing mechanism and register it.
Before this patch:
modinfo ./drivers/mfd/madera.ko | grep alias
After this patch:
modinfo ./drivers/mfd/madera.ko | grep alias
alias: of:N*T*Ccirrus,wm1840C*
alias: of:N*T*Ccirrus,wm1840
alias: of:N*T*Ccirrus,cs47l91C*
alias: of:N*T*Ccirrus,cs47l91
alias: of:N*T*Ccirrus,cs47l90C*
alias: of:N*T*Ccirrus,cs47l90
alias: of:N*T*Ccirrus,cs47l85C*
alias: of:N*T*Ccirrus,cs47l85
alias: of:N*T*Ccirrus,cs47l35C*
alias: of:N*T*Ccirrus,cs47l35
Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
---
drivers/mfd/madera-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index 2a77988..826b971 100644
--- a/drivers/mfd/madera-core.c
+++ b/drivers/mfd/madera-core.c
@@ -286,6 +286,7 @@ const struct of_device_id madera_of_match[] = {
{ .compatible = "cirrus,wm1840", .data = (void *)WM1840 },
{}
};
+MODULE_DEVICE_TABLE(of, madera_of_match);
EXPORT_SYMBOL_GPL(madera_of_match);
static int madera_get_reset_gpio(struct madera *madera)
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2] mfd: madera: Add missing of table registration
@ 2019-05-11 10:03 ` Daniel Gomez
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Gomez @ 2019-05-11 10:03 UTC (permalink / raw)
To: Charles Keepax, Richard Fitzgerald, Lee Jones,
moderated list:CIRRUS LOGIC MADERA CODEC DRIVERS,
open list:CIRRUS LOGIC MADERA CODEC DRIVERS, open list
Cc: dagmcr, javier, moderated list:CIRRUS LOGIC MADERA CODEC DRIVERS,
open list:CIRRUS LOGIC MADERA CODEC DRIVERS, open list
MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
OF mathing mechanism and register it.
Before this patch:
modinfo ./drivers/mfd/madera.ko | grep alias
After this patch:
modinfo ./drivers/mfd/madera.ko | grep alias
alias: of:N*T*Ccirrus,wm1840C*
alias: of:N*T*Ccirrus,wm1840
alias: of:N*T*Ccirrus,cs47l91C*
alias: of:N*T*Ccirrus,cs47l91
alias: of:N*T*Ccirrus,cs47l90C*
alias: of:N*T*Ccirrus,cs47l90
alias: of:N*T*Ccirrus,cs47l85C*
alias: of:N*T*Ccirrus,cs47l85
alias: of:N*T*Ccirrus,cs47l35C*
alias: of:N*T*Ccirrus,cs47l35
Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
---
drivers/mfd/madera-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index 2a77988..826b971 100644
--- a/drivers/mfd/madera-core.c
+++ b/drivers/mfd/madera-core.c
@@ -286,6 +286,7 @@ const struct of_device_id madera_of_match[] = {
{ .compatible = "cirrus,wm1840", .data = (void *)WM1840 },
{}
};
+MODULE_DEVICE_TABLE(of, madera_of_match);
EXPORT_SYMBOL_GPL(madera_of_match);
static int madera_get_reset_gpio(struct madera *madera)
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] mfd: madera: Add missing of table registration
2019-05-11 10:03 ` Daniel Gomez
@ 2019-05-13 8:15 ` Charles Keepax
-1 siblings, 0 replies; 5+ messages in thread
From: Charles Keepax @ 2019-05-13 8:15 UTC (permalink / raw)
To: Daniel Gomez
Cc: Richard Fitzgerald, Lee Jones,
moderated list:CIRRUS LOGIC MADERA CODEC DRIVERS,
open list:CIRRUS LOGIC MADERA CODEC DRIVERS, open list, javier
On Sat, May 11, 2019 at 12:03:58PM +0200, Daniel Gomez wrote:
> MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
> OF mathing mechanism and register it.
>
> Before this patch:
> modinfo ./drivers/mfd/madera.ko | grep alias
>
> After this patch:
> modinfo ./drivers/mfd/madera.ko | grep alias
> alias: of:N*T*Ccirrus,wm1840C*
> alias: of:N*T*Ccirrus,wm1840
> alias: of:N*T*Ccirrus,cs47l91C*
> alias: of:N*T*Ccirrus,cs47l91
> alias: of:N*T*Ccirrus,cs47l90C*
> alias: of:N*T*Ccirrus,cs47l90
> alias: of:N*T*Ccirrus,cs47l85C*
> alias: of:N*T*Ccirrus,cs47l85
> alias: of:N*T*Ccirrus,cs47l35C*
> alias: of:N*T*Ccirrus,cs47l35
>
> Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
> Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] mfd: madera: Add missing of table registration
@ 2019-05-13 8:15 ` Charles Keepax
0 siblings, 0 replies; 5+ messages in thread
From: Charles Keepax @ 2019-05-13 8:15 UTC (permalink / raw)
To: Daniel Gomez
Cc: Richard Fitzgerald, Lee Jones,
moderated list:CIRRUS LOGIC MADERA CODEC DRIVERS,
open list:CIRRUS LOGIC MADERA CODEC DRIVERS, open list, javier
On Sat, May 11, 2019 at 12:03:58PM +0200, Daniel Gomez wrote:
> MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
> OF mathing mechanism and register it.
>
> Before this patch:
> modinfo ./drivers/mfd/madera.ko | grep alias
>
> After this patch:
> modinfo ./drivers/mfd/madera.ko | grep alias
> alias: of:N*T*Ccirrus,wm1840C*
> alias: of:N*T*Ccirrus,wm1840
> alias: of:N*T*Ccirrus,cs47l91C*
> alias: of:N*T*Ccirrus,cs47l91
> alias: of:N*T*Ccirrus,cs47l90C*
> alias: of:N*T*Ccirrus,cs47l90
> alias: of:N*T*Ccirrus,cs47l85C*
> alias: of:N*T*Ccirrus,cs47l85
> alias: of:N*T*Ccirrus,cs47l35C*
> alias: of:N*T*Ccirrus,cs47l35
>
> Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
> Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] mfd: madera: Add missing of table registration
2019-05-11 10:03 ` Daniel Gomez
(?)
(?)
@ 2019-06-03 7:30 ` Lee Jones
-1 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2019-06-03 7:30 UTC (permalink / raw)
To: Daniel Gomez
Cc: Charles Keepax, Richard Fitzgerald,
moderated list:CIRRUS LOGIC MADERA CODEC DRIVERS,
open list:CIRRUS LOGIC MADERA CODEC DRIVERS, open list, javier
On Sat, 11 May 2019, Daniel Gomez wrote:
> MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
> OF mathing mechanism and register it.
>
> Before this patch:
> modinfo ./drivers/mfd/madera.ko | grep alias
>
> After this patch:
> modinfo ./drivers/mfd/madera.ko | grep alias
> alias: of:N*T*Ccirrus,wm1840C*
> alias: of:N*T*Ccirrus,wm1840
> alias: of:N*T*Ccirrus,cs47l91C*
> alias: of:N*T*Ccirrus,cs47l91
> alias: of:N*T*Ccirrus,cs47l90C*
> alias: of:N*T*Ccirrus,cs47l90
> alias: of:N*T*Ccirrus,cs47l85C*
> alias: of:N*T*Ccirrus,cs47l85
> alias: of:N*T*Ccirrus,cs47l35C*
> alias: of:N*T*Ccirrus,cs47l35
>
> Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
> Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
> ---
> drivers/mfd/madera-core.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-03 7:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-11 10:03 [PATCH v2] mfd: madera: Add missing of table registration Daniel Gomez
2019-05-11 10:03 ` Daniel Gomez
2019-05-13 8:15 ` Charles Keepax
2019-05-13 8:15 ` Charles Keepax
2019-06-03 7:30 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.