[PATCH iproute2] man: tc-skbedit.8: document 'inheritdsfield'

[PATCH iproute2] man: tc-skbedit.8: document 'inheritdsfield'

[Davide Caratti]

while at it, fix missing square bracket near 'ptype' and a typo in the
action description (it's -> its).

Signed-off-by: Davide Caratti <dcaratti@redhat.com>
---
 man/man8/tc-skbedit.8 | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/man/man8/tc-skbedit.8 b/man/man8/tc-skbedit.8
index 003f05c93f7c..2459198261e6 100644
--- a/man/man8/tc-skbedit.8
+++ b/man/man8/tc-skbedit.8
@@ -10,9 +10,10 @@ skbedit - SKB editing action
 .B priority
 .IR PRIORITY " ] ["
 .B mark
-.IR MARK " ]"
+.IR MARK " ] ["
 .B ptype
-.IR PTYPE " ]"
+.IR PTYPE " ] ["
+.BR inheritdsfield " ]"
 .SH DESCRIPTION
 The
 .B skbedit
@@ -22,7 +23,7 @@ action, which in turn allows to change parts of the packet data itself.
 
 The most unique feature of
 .B skbedit
-is it's ability to decide over which queue of an interface with multiple
+is its ability to decide over which queue of an interface with multiple
 transmit queues the packet is to be sent out. The number of available transmit
 queues is reflected by sysfs entries within
 .I /sys/class/net/<interface>/queues
@@ -61,6 +62,12 @@ needing to allow ingressing packets with the wrong MAC address but
 correct IP address.
 .I PTYPE
 is one of: host, otherhost, broadcast, multicast
+.TP
+.BI inheritdsfield
+Override the packet classification decision, and any value specified with
+.BR priority ", "
+using the information stored in the Differentiated Services Field of the
+IPv6/IPv4 header (RFC2474).
 .SH SEE ALSO
 .BR tc (8),
 .BR tc-pedit (8)
-- 
2.20.1

Re: [PATCH iproute2] man: tc-skbedit.8: document 'inheritdsfield'

[Andrea Claudi]

On Fri, May 31, 2019 at 2:12 PM Davide Caratti <dcaratti@redhat.com> wrote:
>
> while at it, fix missing square bracket near 'ptype' and a typo in the
> action description (it's -> its).
>
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
> ---
>  man/man8/tc-skbedit.8 | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/man/man8/tc-skbedit.8 b/man/man8/tc-skbedit.8
> index 003f05c93f7c..2459198261e6 100644
> --- a/man/man8/tc-skbedit.8
> +++ b/man/man8/tc-skbedit.8
> @@ -10,9 +10,10 @@ skbedit - SKB editing action
>  .B priority
>  .IR PRIORITY " ] ["
>  .B mark
> -.IR MARK " ]"
> +.IR MARK " ] ["
>  .B ptype
> -.IR PTYPE " ]"
> +.IR PTYPE " ] ["
> +.BR inheritdsfield " ]"
>  .SH DESCRIPTION
>  The
>  .B skbedit
> @@ -22,7 +23,7 @@ action, which in turn allows to change parts of the packet data itself.
>
>  The most unique feature of
>  .B skbedit
> -is it's ability to decide over which queue of an interface with multiple
> +is its ability to decide over which queue of an interface with multiple
>  transmit queues the packet is to be sent out. The number of available transmit
>  queues is reflected by sysfs entries within
>  .I /sys/class/net/<interface>/queues
> @@ -61,6 +62,12 @@ needing to allow ingressing packets with the wrong MAC address but
>  correct IP address.
>  .I PTYPE
>  is one of: host, otherhost, broadcast, multicast
> +.TP
> +.BI inheritdsfield
> +Override the packet classification decision, and any value specified with
> +.BR priority ", "
> +using the information stored in the Differentiated Services Field of the
> +IPv6/IPv4 header (RFC2474).
>  .SH SEE ALSO
>  .BR tc (8),
>  .BR tc-pedit (8)
> --
> 2.20.1
>

Acked-by: Andrea Claudi <aclaudi@redhat.com>

Re: [PATCH iproute2] man: tc-skbedit.8: document 'inheritdsfield'

[Stephen Hemminger]

On Fri, 31 May 2019 14:12:15 +0200
Davide Caratti <dcaratti@redhat.com> wrote:

> while at it, fix missing square bracket near 'ptype' and a typo in the
> action description (it's -> its).
> 
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>

Applied. Thanks