All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: jacek.anaszewski@gmail.com, pavel@ucw.cz, broonie@kernel.org,
	lgirdwood@gmail.com
Cc: lee.jones@linaro.org, linux-leds@vger.kernel.org,
	linux-kernel@vger.kernel.org, Dan Murphy <dmurphy@ti.com>
Subject: [PATCH v5 1/6] regulator: lm363x: Make the gpio register enable flexible
Date: Tue, 4 Jun 2019 12:43:40 -0500	[thread overview]
Message-ID: <20190604174345.14841-2-dmurphy@ti.com> (raw)
In-Reply-To: <20190604174345.14841-1-dmurphy@ti.com>

The use of and enablement of the GPIO can be used across devices.
Use the enable_reg in the regulator descriptor for the register to
write.

Signed-off-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
---

v5 - No changes to the patch changes requested in this patch were done in
patch 4 of this series - https://lore.kernel.org/patchwork/patch/1077408/

 drivers/regulator/lm363x-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/lm363x-regulator.c b/drivers/regulator/lm363x-regulator.c
index e02fdd1dd092..1b5d7d2f26b8 100644
--- a/drivers/regulator/lm363x-regulator.c
+++ b/drivers/regulator/lm363x-regulator.c
@@ -263,8 +263,8 @@ static int lm363x_regulator_probe(struct platform_device *pdev)
 
 	if (gpiod) {
 		cfg.ena_gpiod = gpiod;
-
-		ret = regmap_update_bits(regmap, LM3632_REG_BIAS_CONFIG,
+		ret = regmap_update_bits(regmap,
+					 lm363x_regulator_desc[id].enable_reg,
 					 LM3632_EXT_EN_MASK,
 					 LM3632_EXT_EN_MASK);
 		if (ret) {
-- 
2.21.0.5.gaeb582a983

WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
	<broonie@kernel.org>, <lgirdwood@gmail.com>
Cc: <lee.jones@linaro.org>, <linux-leds@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Dan Murphy <dmurphy@ti.com>
Subject: [PATCH v5 1/6] regulator: lm363x: Make the gpio register enable flexible
Date: Tue, 4 Jun 2019 12:43:40 -0500	[thread overview]
Message-ID: <20190604174345.14841-2-dmurphy@ti.com> (raw)
In-Reply-To: <20190604174345.14841-1-dmurphy@ti.com>

The use of and enablement of the GPIO can be used across devices.
Use the enable_reg in the regulator descriptor for the register to
write.

Signed-off-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
---

v5 - No changes to the patch changes requested in this patch were done in
patch 4 of this series - https://lore.kernel.org/patchwork/patch/1077408/

 drivers/regulator/lm363x-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/lm363x-regulator.c b/drivers/regulator/lm363x-regulator.c
index e02fdd1dd092..1b5d7d2f26b8 100644
--- a/drivers/regulator/lm363x-regulator.c
+++ b/drivers/regulator/lm363x-regulator.c
@@ -263,8 +263,8 @@ static int lm363x_regulator_probe(struct platform_device *pdev)
 
 	if (gpiod) {
 		cfg.ena_gpiod = gpiod;
-
-		ret = regmap_update_bits(regmap, LM3632_REG_BIAS_CONFIG,
+		ret = regmap_update_bits(regmap,
+					 lm363x_regulator_desc[id].enable_reg,
 					 LM3632_EXT_EN_MASK,
 					 LM3632_EXT_EN_MASK);
 		if (ret) {
-- 
2.21.0.5.gaeb582a983


  reply	other threads:[~2019-06-04 17:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04 17:43 [PATCH v5 0/6] LM36274 Introduction Dan Murphy
2019-06-04 17:43 ` Dan Murphy
2019-06-04 17:43 ` Dan Murphy [this message]
2019-06-04 17:43   ` [PATCH v5 1/6] regulator: lm363x: Make the gpio register enable flexible Dan Murphy
2019-06-05 10:01   ` Mark Brown
2019-06-05 12:02     ` Dan Murphy
2019-06-05 12:02       ` Dan Murphy
2019-06-05 12:47       ` Dan Murphy
2019-06-05 12:47         ` Dan Murphy
2019-06-05 16:31         ` Mark Brown
2019-06-05 16:32           ` Dan Murphy
2019-06-05 16:32             ` Dan Murphy
2019-06-06  9:47   ` Pavel Machek
2019-06-04 17:43 ` [PATCH v5 2/6] dt-bindings: mfd: Add lm36274 bindings to ti-lmu Dan Murphy
2019-06-04 17:43   ` Dan Murphy
2019-06-06  9:49   ` Pavel Machek
2019-06-04 17:43 ` [PATCH v5 3/6] mfd: ti-lmu: Add LM36274 support to the ti-lmu Dan Murphy
2019-06-04 17:43   ` Dan Murphy
2019-06-04 17:43 ` [PATCH v5 4/6] regulator: lm363x: Add support for LM36274 Dan Murphy
2019-06-04 17:43   ` Dan Murphy
2019-06-04 17:43 ` [PATCH v5 5/6] dt-bindings: leds: Add LED bindings for the LM36274 Dan Murphy
2019-06-04 17:43   ` Dan Murphy
2019-06-04 17:43 ` [PATCH v5 6/6] leds: lm36274: Introduce the TI LM36274 LED driver Dan Murphy
2019-06-04 17:43   ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190604174345.14841-2-dmurphy@ti.com \
    --to=dmurphy@ti.com \
    --cc=broonie@kernel.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.