All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <wsa@the-dreams.de>, <mika.westerberg@linux.intel.com>,
	<jarkko.nikula@linux.intel.com>, <linux-i2c@vger.kernel.org>,
	<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<benjamin.tissoires@redhat.com>, <jbroadus@gmail.com>,
	<patches@opensource.cirrus.com>
Subject: Re: [PATCH v3 4/6] i2c: core: Move ACPI IRQ handling to probe time
Date: Wed, 5 Jun 2019 09:22:49 +0100	[thread overview]
Message-ID: <20190605082249.GL28362@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20190604170404.GR9224@smile.fi.intel.com>

On Tue, Jun 04, 2019 at 08:04:04PM +0300, Andy Shevchenko wrote:
> On Tue, May 28, 2019 at 03:28:58PM +0100, Charles Keepax wrote:
> > Bring the ACPI path in sync with the device tree path and handle all the
> > IRQ fetching at probe time. This leaves the only IRQ handling at device
> > registration time being that which is passed directly through the board
> > info as either a resource or an actual IRQ number.
> > 
> 
> It seems my comments weren't addressed by one or another reason.
> This one I would rather to split with exporting function as a separate patch.
> 

With the switch to passing in i2c_client it makes for some fairly
awkward gymnastics and "ping pong" programming to do so. I guess
we could leave the function taking in an acpi_device but just
felt like a slightly less user friendly interface. Any thoughts?

Thanks,
Charles

WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: wsa@the-dreams.de, mika.westerberg@linux.intel.com,
	jarkko.nikula@linux.intel.com, linux-i2c@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	benjamin.tissoires@redhat.com, jbroadus@gmail.com,
	patches@opensource.cirrus.com
Subject: Re: [PATCH v3 4/6] i2c: core: Move ACPI IRQ handling to probe time
Date: Wed, 5 Jun 2019 09:22:49 +0100	[thread overview]
Message-ID: <20190605082249.GL28362@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20190604170404.GR9224@smile.fi.intel.com>

On Tue, Jun 04, 2019 at 08:04:04PM +0300, Andy Shevchenko wrote:
> On Tue, May 28, 2019 at 03:28:58PM +0100, Charles Keepax wrote:
> > Bring the ACPI path in sync with the device tree path and handle all the
> > IRQ fetching at probe time. This leaves the only IRQ handling at device
> > registration time being that which is passed directly through the board
> > info as either a resource or an actual IRQ number.
> > 
> 
> It seems my comments weren't addressed by one or another reason.
> This one I would rather to split with exporting function as a separate patch.
> 

With the switch to passing in i2c_client it makes for some fairly
awkward gymnastics and "ping pong" programming to do so. I guess
we could leave the function taking in an acpi_device but just
felt like a slightly less user friendly interface. Any thoughts?

Thanks,
Charles

  reply	other threads:[~2019-06-05  8:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 14:28 [PATCH v3 1/6] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Charles Keepax
2019-05-28 14:28 ` Charles Keepax
2019-05-28 14:28 ` [PATCH v3 2/6] i2c: acpi: Use available IRQ helper functions Charles Keepax
2019-05-28 14:28   ` Charles Keepax
2019-05-29  7:35   ` Mika Westerberg
2019-06-04 17:00   ` Andy Shevchenko
2019-06-05  8:26     ` Charles Keepax
2019-06-05  8:26       ` Charles Keepax
2019-05-28 14:28 ` [PATCH v3 3/6] i2c: acpi: Factor out getting the IRQ from ACPI Charles Keepax
2019-05-28 14:28   ` Charles Keepax
2019-05-29  7:36   ` Mika Westerberg
2019-05-28 14:28 ` [PATCH v3 4/6] i2c: core: Move ACPI IRQ handling to probe time Charles Keepax
2019-05-28 14:28   ` Charles Keepax
2019-05-29  7:43   ` Mika Westerberg
2019-06-04 17:04   ` Andy Shevchenko
2019-06-05  8:22     ` Charles Keepax [this message]
2019-06-05  8:22       ` Charles Keepax
2019-05-28 14:28 ` [PATCH v3 5/6] i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq Charles Keepax
2019-05-28 14:28   ` Charles Keepax
2019-05-29  7:43   ` Mika Westerberg
2019-05-28 14:29 ` [PATCH v3 6/6] i2c: core: Tidy up handling of init_irq Charles Keepax
2019-05-28 14:29   ` Charles Keepax
2019-05-29  7:44   ` Mika Westerberg
2019-05-29  7:34 ` [PATCH v3 1/6] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605082249.GL28362@ediswmail.ad.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jbroadus@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=patches@opensource.cirrus.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.