* [PATCH v4 1/3] dt-bindings: display: Add GiantPlus GPM940B0 panel documentation
@ 2019-06-03 15:35 Paul Cercueil
2019-06-03 15:35 ` [PATCH v4 2/3] media: uapi: Add RGB bus format for the GiantPlus GPM940B0 panel Paul Cercueil
2019-06-03 15:35 ` [PATCH v4 3/3] drm/panel: simple: Add GiantPlus GPM940B0 panel support Paul Cercueil
0 siblings, 2 replies; 5+ messages in thread
From: Paul Cercueil @ 2019-06-03 15:35 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, Mauro Carvalho Chehab, Hans Verkuil
Cc: dri-devel, linux-media, devicetree, linux-kernel, od,
Paul Cercueil, Rob Herring
The GPM940B0 is a 3.0" 320x240 24-bit TFT LCD panel.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Notes:
v2: New patch
v3: Add Rob's ack
v4: No change
.../bindings/display/panel/giantplus,gpm940b0.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt
diff --git a/Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt b/Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt
new file mode 100644
index 000000000000..3dab52f92c26
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/giantplus,gpm940b0.txt
@@ -0,0 +1,12 @@
+GiantPlus 3.0" (320x240 pixels) 24-bit TFT LCD panel
+
+Required properties:
+- compatible: should be "giantplus,gpm940b0"
+- power-supply: as specified in the base binding
+
+Optional properties:
+- backlight: as specified in the base binding
+- enable-gpios: as specified in the base binding
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
--
2.21.0.593.g511ec345e18
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v4 2/3] media: uapi: Add RGB bus format for the GiantPlus GPM940B0 panel 2019-06-03 15:35 [PATCH v4 1/3] dt-bindings: display: Add GiantPlus GPM940B0 panel documentation Paul Cercueil @ 2019-06-03 15:35 ` Paul Cercueil 2019-06-05 14:26 ` Mauro Carvalho Chehab 2019-06-03 15:35 ` [PATCH v4 3/3] drm/panel: simple: Add GiantPlus GPM940B0 panel support Paul Cercueil 1 sibling, 1 reply; 5+ messages in thread From: Paul Cercueil @ 2019-06-03 15:35 UTC (permalink / raw) To: Thierry Reding, Sam Ravnborg, Mauro Carvalho Chehab, Hans Verkuil Cc: dri-devel, linux-media, devicetree, linux-kernel, od, Paul Cercueil The GiantPlus GPM940B0 is a 24-bit TFT panel where the RGB components are transferred sequentially on a 8-bit bus. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- Notes: v2: New patch v3: No change v4: Add only MEDIA_BUS_FMT_RGB888_3X8, as we don't have to care about endianness include/uapi/linux/media-bus-format.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h index 2a6b253cfb05..16c1fa2d89a4 100644 --- a/include/uapi/linux/media-bus-format.h +++ b/include/uapi/linux/media-bus-format.h @@ -34,7 +34,7 @@ #define MEDIA_BUS_FMT_FIXED 0x0001 -/* RGB - next is 0x101c */ +/* RGB - next is 0x101d */ #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 @@ -55,6 +55,7 @@ #define MEDIA_BUS_FMT_RGB888_1X24 0x100a #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c +#define MEDIA_BUS_FMT_RGB888_3X8 0x101c #define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG 0x1011 #define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA 0x1012 #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d -- 2.21.0.593.g511ec345e18 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v4 2/3] media: uapi: Add RGB bus format for the GiantPlus GPM940B0 panel 2019-06-03 15:35 ` [PATCH v4 2/3] media: uapi: Add RGB bus format for the GiantPlus GPM940B0 panel Paul Cercueil @ 2019-06-05 14:26 ` Mauro Carvalho Chehab 2019-06-05 21:59 ` Paul Cercueil 0 siblings, 1 reply; 5+ messages in thread From: Mauro Carvalho Chehab @ 2019-06-05 14:26 UTC (permalink / raw) To: Paul Cercueil Cc: Thierry Reding, Sam Ravnborg, Hans Verkuil, dri-devel, linux-media, devicetree, linux-kernel, od Em Mon, 3 Jun 2019 17:35:10 +0200 Paul Cercueil <paul@crapouillou.net> escreveu: > The GiantPlus GPM940B0 is a 24-bit TFT panel where the RGB components > are transferred sequentially on a 8-bit bus. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > > Notes: > v2: New patch > > v3: No change > > v4: Add only MEDIA_BUS_FMT_RGB888_3X8, as we don't have to care about > endianness Same comment as on version 3: You should also patch the documentation text at: Documentation/media/uapi/v4l/subdev-formats.rst In order to describe the new format that will be included. > > include/uapi/linux/media-bus-format.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > index 2a6b253cfb05..16c1fa2d89a4 100644 > --- a/include/uapi/linux/media-bus-format.h > +++ b/include/uapi/linux/media-bus-format.h > @@ -34,7 +34,7 @@ > > #define MEDIA_BUS_FMT_FIXED 0x0001 > > -/* RGB - next is 0x101c */ > +/* RGB - next is 0x101d */ > #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 > @@ -55,6 +55,7 @@ > #define MEDIA_BUS_FMT_RGB888_1X24 0x100a > #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b > #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c > +#define MEDIA_BUS_FMT_RGB888_3X8 0x101c > #define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG 0x1011 > #define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA 0x1012 > #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d Thanks, Mauro ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 2/3] media: uapi: Add RGB bus format for the GiantPlus GPM940B0 panel 2019-06-05 14:26 ` Mauro Carvalho Chehab @ 2019-06-05 21:59 ` Paul Cercueil 0 siblings, 0 replies; 5+ messages in thread From: Paul Cercueil @ 2019-06-05 21:59 UTC (permalink / raw) To: Mauro Carvalho Chehab Cc: Thierry Reding, Sam Ravnborg, Hans Verkuil, dri-devel, linux-media, devicetree, linux-kernel, od Le mer. 5 juin 2019 à 16:26, Mauro Carvalho Chehab <mchehab+samsung@kernel.org> a écrit : > Em Mon, 3 Jun 2019 17:35:10 +0200 > Paul Cercueil <paul@crapouillou.net> escreveu: > >> The GiantPlus GPM940B0 is a 24-bit TFT panel where the RGB >> components >> are transferred sequentially on a 8-bit bus. >> >> Signed-off-by: Paul Cercueil <paul@crapouillou.net> >> --- >> >> Notes: >> v2: New patch >> >> v3: No change >> >> v4: Add only MEDIA_BUS_FMT_RGB888_3X8, as we don't have to care >> about >> endianness > > Same comment as on version 3: > > You should also patch the documentation text at: > > Documentation/media/uapi/v4l/subdev-formats.rst > > In order to describe the new format that will be included. Ouch. Sorry. Will do. -Paul > >> >> include/uapi/linux/media-bus-format.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/include/uapi/linux/media-bus-format.h >> b/include/uapi/linux/media-bus-format.h >> index 2a6b253cfb05..16c1fa2d89a4 100644 >> --- a/include/uapi/linux/media-bus-format.h >> +++ b/include/uapi/linux/media-bus-format.h >> @@ -34,7 +34,7 @@ >> >> #define MEDIA_BUS_FMT_FIXED 0x0001 >> >> -/* RGB - next is 0x101c */ >> +/* RGB - next is 0x101d */ >> #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 >> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 >> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 >> @@ -55,6 +55,7 @@ >> #define MEDIA_BUS_FMT_RGB888_1X24 0x100a >> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b >> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c >> +#define MEDIA_BUS_FMT_RGB888_3X8 0x101c >> #define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG 0x1011 >> #define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA 0x1012 >> #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d > > > > Thanks, > Mauro ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4 3/3] drm/panel: simple: Add GiantPlus GPM940B0 panel support 2019-06-03 15:35 [PATCH v4 1/3] dt-bindings: display: Add GiantPlus GPM940B0 panel documentation Paul Cercueil 2019-06-03 15:35 ` [PATCH v4 2/3] media: uapi: Add RGB bus format for the GiantPlus GPM940B0 panel Paul Cercueil @ 2019-06-03 15:35 ` Paul Cercueil 1 sibling, 0 replies; 5+ messages in thread From: Paul Cercueil @ 2019-06-03 15:35 UTC (permalink / raw) To: Thierry Reding, Sam Ravnborg, Mauro Carvalho Chehab, Hans Verkuil Cc: dri-devel, linux-media, devicetree, linux-kernel, od, Paul Cercueil, Artur Rojek The GiantPlus GPM940B0 is a simple 3.0" 320x240 24-bit TFT panel. Signed-off-by: Paul Cercueil <paul@crapouillou.net> Tested-by: Artur Rojek <contact@artur-rojek.eu> --- Notes: v2: Change bus format to MEDIA_BUS_FMT_RGB888_3X8_BE v3: No change v4: Change bus format to MEDIA_BUS_FMT_RGB888_3X8 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 5a93c4edf1e4..eec9a9efcc73 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1335,6 +1335,31 @@ static const struct panel_desc giantplus_gpg482739qs5 = { .bus_format = MEDIA_BUS_FMT_RGB888_1X24, }; +static const struct display_timing giantplus_gpm940b0_timing = { + .pixelclock = { 13500000, 27000000, 27500000 }, + .hactive = { 320, 320, 320 }, + .hfront_porch = { 14, 686, 718 }, + .hback_porch = { 50, 70, 255 }, + .hsync_len = { 1, 1, 1 }, + .vactive = { 240, 240, 240 }, + .vfront_porch = { 1, 1, 179 }, + .vback_porch = { 1, 21, 31 }, + .vsync_len = { 1, 1, 6 }, + .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW, +}; + +static const struct panel_desc giantplus_gpm940b0 = { + .timings = &giantplus_gpm940b0_timing, + .num_timings = 1, + .bpc = 8, + .size = { + .width = 60, + .height = 45, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_3X8, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE, +}; + static const struct display_timing hannstar_hsd070pww1_timing = { .pixelclock = { 64300000, 71100000, 82000000 }, .hactive = { 1280, 1280, 1280 }, @@ -2882,6 +2907,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "giantplus,gpg482739qs5", .data = &giantplus_gpg482739qs5 + }, { + .compatible = "giantplus,gpm940b0", + .data = &giantplus_gpm940b0, }, { .compatible = "hannstar,hsd070pww1", .data = &hannstar_hsd070pww1, -- 2.21.0.593.g511ec345e18 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-05 21:59 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-06-03 15:35 [PATCH v4 1/3] dt-bindings: display: Add GiantPlus GPM940B0 panel documentation Paul Cercueil 2019-06-03 15:35 ` [PATCH v4 2/3] media: uapi: Add RGB bus format for the GiantPlus GPM940B0 panel Paul Cercueil 2019-06-05 14:26 ` Mauro Carvalho Chehab 2019-06-05 21:59 ` Paul Cercueil 2019-06-03 15:35 ` [PATCH v4 3/3] drm/panel: simple: Add GiantPlus GPM940B0 panel support Paul Cercueil
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.